Jakub Kicinski df493f676f bpf: pull before calling skb_postpull_rcsum() ... [ Upstream commit 54c3f1a814 ] Anand hit a BUG() when pulling off headers on egress to a SW tunnel. We get to skb_checksum_help() with an invalid checksum offset (commit d7ea0d9df2 ("net: remove two BUG() from skb_checksum_help()") converted those BUGs to WARN_ONs()). He points out oddness in how skb_postpull_rcsum() gets used. Indeed looks like we should pull before "postpull", otherwise the CHECKSUM_PARTIAL fixup from skb_postpull_rcsum() will not be able to do its job: if (skb->ip_summed == CHECKSUM_PARTIAL && skb_checksum_start_offset(skb) < 0) skb->ip_summed = CHECKSUM_NONE; Reported-by: Anand Parthasarathy <anpartha@meta.com> Fixes: 6578171a7f ("bpf: add bpf_skb_change_proto helper") Signed-off-by: Jakub Kicinski <kuba@kernel.org> Acked-by: Stanislav Fomichev <sdf@google.com> Link: https://lore.kernel.org/r/20221220004701.402165-1-kuba@kernel.org Signed-off-by: Martin KaFai Lau <martin.lau@kernel.org> Signed-off-by: Sasha Levin <sashal@kernel.org>		2023-01-12 11:59:08 +01:00
..
bpf_sk_storage.c	net: Fix data-races around sysctl_optmem_max.	2022-08-31 17:16:43 +02:00
datagram.c	tcp: TX zerocopy should not sense pfmemalloc status	2022-09-15 11:30:05 +02:00
datagram.h
dev_addr_lists.c	net: dev_addr_list: handle first address in __hw_addr_add_ex	2021-09-30 13:29:09 +01:00
dev_ioctl.c	net: core: don't call SIOCBRADD/DELIF for non-bridge devices	2021-08-05 11:36:59 +01:00
dev.c	net: add atomic_long_t to net_device_stats fields	2022-12-31 13:14:42 +01:00
devlink.c	devlink: Fix use-after-free after a failed reload	2022-08-25 11:40:06 +02:00
drop_monitor.c	net: skb: introduce kfree_skb_reason()	2022-07-29 17:25:15 +02:00
dst_cache.c	wireguard: device: reset peer src endpoint when netns exits	2021-12-08 09:04:46 +01:00
dst.c	net: Remove redundant if statements	2021-08-05 13:27:50 +01:00
failover.c
fib_notifier.c
fib_rules.c	ipv6: fix memory leak in fib6_rule_suppress	2021-12-08 09:04:43 +01:00
filter.c	bpf: pull before calling skb_postpull_rcsum()	2023-01-12 11:59:08 +01:00
flow_dissector.c	netfilter: conntrack: Fix data-races around ct mark	2022-12-02 17:41:04 +01:00
flow_offload.c	netfilter: nf_tables: bail out early if hardware offload is not supported	2022-06-14 18:36:17 +02:00
gen_estimator.c	net_sched: gen_estimator: support large ewma log	2021-01-15 18:11:06 -08:00
gen_stats.c
gro_cells.c	net: Fix data-races around netdev_max_backlog.	2022-08-31 17:16:42 +02:00
hwbm.c
link_watch.c	net: Write lock dev_base_lock without disabling bottom halves.	2022-06-29 09:03:22 +02:00
lwt_bpf.c	bpf, lwt: Fix crash when using bpf_skb_set_tunnel_key() from bpf_xmit lwt hook	2022-05-09 09:14:35 +02:00
lwtunnel.c	lwtunnel: Validate RTA_ENCAP_TYPE attribute length	2022-01-11 15:35:14 +01:00
Makefile	of: net: move of_net under net/	2022-03-08 19:12:41 +01:00
neighbour.c	net, neigh: Fix null-ptr-deref in neigh_table_clear()	2022-11-10 18:15:31 +01:00
net_namespace.c	net: fix UAF issue in nfqnl_nf_hook_drop() when ops_init() failed	2022-11-03 23:59:16 +09:00
net-procfs.c	net-procfs: show net devices bound packet types	2022-02-01 17:27:08 +01:00
net-sysfs.c	net: fix data-race in dev_isalive()	2022-06-29 09:03:22 +02:00
net-sysfs.h
net-traces.c	tcp: add tracepoint for checksum errors	2021-05-14 15:26:03 -07:00
netclassid_cgroup.c	bpf, cgroups: Fix cgroup v2 fallback on v1/v2 mixed mode	2021-09-13 16:35:58 -07:00
netevent.c	net: core: Correct function name netevent_unregister_notifier() in the kerneldoc	2021-03-28 17:56:56 -07:00
netpoll.c	asm-generic/unaligned: Unify asm/unaligned.h around struct helper	2021-07-02 12:43:40 -07:00
netprio_cgroup.c	bpf, cgroups: Fix cgroup v2 fallback on v1/v2 mixed mode	2021-09-13 16:35:58 -07:00
of_net.c	of: net: move of_net under net/	2022-03-08 19:12:41 +01:00
page_pool.c	page_pool: use relaxed atomic for release side accounting	2021-08-24 10:46:31 +01:00
pktgen.c	pktgen: remove unused variable	2021-09-03 11:48:28 +01:00
ptp_classifier.c	bpf: Refactor BPF_PROG_RUN into a function	2021-08-17 00:45:07 +02:00
request_sock.c
rtnetlink.c	net: Write lock dev_base_lock without disabling bottom halves.	2022-06-29 09:03:22 +02:00
scm.c	memcg: enable accounting for scm_fp_list objects	2021-07-20 06:00:38 -07:00
secure_seq.c	tcp: Fix data-races around sysctl knobs related to SYN option.	2022-07-29 17:25:22 +02:00
selftests.c	net: selftests: add MTU test	2021-07-22 00:52:04 -07:00
skbuff.c	skbuff: Account for tail adjustment during pull operations	2022-12-31 13:14:38 +01:00
skmsg.c	bpf, sockmap: Fix missing BPF_F_INGRESS flag when using apply_bytes	2022-12-31 13:14:14 +01:00
sock_destructor.h	skb_expand_head() adjust skb->truesize incorrectly	2021-10-22 12:35:51 -07:00
sock_diag.c	bpf, net: Rework cookie generator as per-cpu one	2020-09-30 11:50:35 -07:00
sock_map.c	bpf, sockmap: fix race in sock_map_free()	2022-12-31 13:14:16 +01:00
sock_reuseport.c	soreuseport: Fix socket selection for SO_INCOMING_CPU.	2022-12-31 13:14:07 +01:00
sock.c	soreuseport: Fix socket selection for SO_INCOMING_CPU.	2022-12-31 13:14:07 +01:00
stream.c	net: stream: purge sk_error_queue in sk_stream_kill_queues()	2022-12-31 13:14:39 +01:00
sysctl_net_core.c	net: Fix data-races around weight_p and dev_weight_[rt]x_bias.	2022-08-31 17:16:42 +02:00
timestamping.c
tso.c	net: tso: add UDP segmentation support	2020-06-18 20:46:23 -07:00
utils.c
xdp.c	xdp: Move the rxq_info.mem clearing to unreg_mem_model()	2021-06-28 23:07:59 +02:00