mirror of
https://mirrors.bfsu.edu.cn/git/linux.git
synced 2024-12-15 06:55:13 +08:00
6371ca3b54
In this patch, a series of libbpf specific error numbers and
libbpf_strerror() are introduced to help reporting errors.
Functions are updated to pass correct the error number through the
CHECK_ERR() macro.
All users of bpf_object__open{_buffer}() and bpf_program__title() in
perf are modified accordingly. In addition, due to the error codes
changing, bpf__strerror_load() is also modified to use them.
bpf__strerror_head() is also changed accordingly so it can parse libbpf
errors. bpf_loader_strerror() is introduced for that purpose, and will
be improved by the following patch.
load_program() is improved not to dump log buffer if it is empty. log
buffer is also used to deduce whether the error was caused by an invalid
program or other problem.
v1 -> v2:
- Using macro for error code.
- Fetch error message based on array index, eliminate for-loop.
- Use log buffer to detect the reason of failure. 3 new error code
are introduced to replace LIBBPF_ERRNO__LOAD.
In v1:
# perf record -e ./test_ill_program.o ls
event syntax error: './test_ill_program.o'
\___ Failed to load program: Validate your program and check 'license'/'version' sections in your object
SKIP
# perf record -e ./test_kversion_nomatch_program.o ls
event syntax error: './test_kversion_nomatch_program.o'
\___ Failed to load program: Validate your program and check 'license'/'version' sections in your object
SKIP
# perf record -e ./test_big_program.o ls
event syntax error: './test_big_program.o'
\___ Failed to load program: Validate your program and check 'license'/'version' sections in your object
SKIP
In v2:
# perf record -e ./test_ill_program.o ls
event syntax error: './test_ill_program.o'
\___ Kernel verifier blocks program loading
SKIP
# perf record -e ./test_kversion_nomatch_program.o
event syntax error: './test_kversion_nomatch_program.o'
\___ Incorrect kernel version
SKIP
(Will be further improved by following patches)
# perf record -e ./test_big_program.o
event syntax error: './test_big_program.o'
\___ Program too big
SKIP
Signed-off-by: Wang Nan <wangnan0@huawei.com>
Tested-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Zefan Li <lizefan@huawei.com>
Cc: pi3orama@163.com
Link: http://lkml.kernel.org/r/1446817783-86722-2-git-send-email-wangnan0@huawei.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
96 lines
2.2 KiB
C
96 lines
2.2 KiB
C
#include <stdio.h>
|
|
#include <bpf/libbpf.h>
|
|
#include <util/llvm-utils.h>
|
|
#include <util/cache.h>
|
|
#include "tests.h"
|
|
#include "debug.h"
|
|
|
|
static int perf_config_cb(const char *var, const char *val,
|
|
void *arg __maybe_unused)
|
|
{
|
|
return perf_default_config(var, val, arg);
|
|
}
|
|
|
|
/*
|
|
* Randomly give it a "version" section since we don't really load it
|
|
* into kernel
|
|
*/
|
|
static const char test_bpf_prog[] =
|
|
"__attribute__((section(\"do_fork\"), used)) "
|
|
"int fork(void *ctx) {return 0;} "
|
|
"char _license[] __attribute__((section(\"license\"), used)) = \"GPL\";"
|
|
"int _version __attribute__((section(\"version\"), used)) = 0x40100;";
|
|
|
|
#ifdef HAVE_LIBBPF_SUPPORT
|
|
static int test__bpf_parsing(void *obj_buf, size_t obj_buf_sz)
|
|
{
|
|
struct bpf_object *obj;
|
|
|
|
obj = bpf_object__open_buffer(obj_buf, obj_buf_sz, NULL);
|
|
if (IS_ERR(obj))
|
|
return -1;
|
|
bpf_object__close(obj);
|
|
return 0;
|
|
}
|
|
#else
|
|
static int test__bpf_parsing(void *obj_buf __maybe_unused,
|
|
size_t obj_buf_sz __maybe_unused)
|
|
{
|
|
pr_debug("Skip bpf parsing\n");
|
|
return 0;
|
|
}
|
|
#endif
|
|
|
|
int test__llvm(void)
|
|
{
|
|
char *tmpl_new, *clang_opt_new;
|
|
void *obj_buf;
|
|
size_t obj_buf_sz;
|
|
int err, old_verbose;
|
|
|
|
perf_config(perf_config_cb, NULL);
|
|
|
|
/*
|
|
* Skip this test if user's .perfconfig doesn't set [llvm] section
|
|
* and clang is not found in $PATH, and this is not perf test -v
|
|
*/
|
|
if (verbose == 0 && !llvm_param.user_set_param && llvm__search_clang()) {
|
|
pr_debug("No clang and no verbosive, skip this test\n");
|
|
return TEST_SKIP;
|
|
}
|
|
|
|
old_verbose = verbose;
|
|
/*
|
|
* llvm is verbosity when error. Suppress all error output if
|
|
* not 'perf test -v'.
|
|
*/
|
|
if (verbose == 0)
|
|
verbose = -1;
|
|
|
|
if (!llvm_param.clang_bpf_cmd_template)
|
|
return -1;
|
|
|
|
if (!llvm_param.clang_opt)
|
|
llvm_param.clang_opt = strdup("");
|
|
|
|
err = asprintf(&tmpl_new, "echo '%s' | %s", test_bpf_prog,
|
|
llvm_param.clang_bpf_cmd_template);
|
|
if (err < 0)
|
|
return -1;
|
|
err = asprintf(&clang_opt_new, "-xc %s", llvm_param.clang_opt);
|
|
if (err < 0)
|
|
return -1;
|
|
|
|
llvm_param.clang_bpf_cmd_template = tmpl_new;
|
|
llvm_param.clang_opt = clang_opt_new;
|
|
err = llvm__compile_bpf("-", &obj_buf, &obj_buf_sz);
|
|
|
|
verbose = old_verbose;
|
|
if (err)
|
|
return TEST_FAIL;
|
|
|
|
err = test__bpf_parsing(obj_buf, obj_buf_sz);
|
|
free(obj_buf);
|
|
return err;
|
|
}
|