linux/fs/ntfs3
Abdun Nihaal 1692fedd0f fs/ntfs3: Validate attribute data and valid sizes
commit 019d22eb0e upstream.

The data_size and valid_size fields of non resident attributes should be
less than the its alloc_size field, but this is not checked in
ntfs_read_mft function.

Syzbot reports a allocation order warning due to a large unchecked value
of data_size getting assigned to inode->i_size which is then passed to
kcalloc.

Add sanity check for ensuring that the data_size and valid_size fields
are not larger than alloc_size field.

Link: https://syzkaller.appspot.com/bug?extid=fa4648a5446460b7b963
Reported-and-tested-by: syzbot+fa4648a5446460b7b963@syzkaller.appspotmail.com
Fixes: (82cae269cf) fs/ntfs3: Add initialization of super block
Signed-off-by: Abdun Nihaal <abdun.nihaal@gmail.com>
Signed-off-by: Konstantin Komarov <almaz.alexandrovich@paragon-software.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2023-02-09 11:26:47 +01:00
..
lib fs/ntfs3: Add missing header and guards to lib/ headers 2021-09-13 19:41:44 +03:00
attrib.c fs/ntfs3: Fix attr_punch_hole() null pointer derenference 2023-01-24 07:22:48 +01:00
attrlist.c fs/ntfs3: Validate data run offset 2023-01-12 11:58:43 +01:00
bitfunc.c fs/ntfs3: Remove a useless shadowing variable 2021-09-23 19:05:46 +03:00
bitmap.c fs/ntfs3: Use __GFP_NOWARN allocation at wnd_init() 2023-01-12 11:58:45 +01:00
debug.h fs/ntfs3. Add forward declarations for structs to debug.h 2021-09-13 19:41:43 +03:00
dir.c fs/ntfs3: Rework ntfs_utf16_to_nls 2021-10-11 19:28:04 +03:00
file.c fs/ntfs3: don't hold ni_lock when calling truncate_setsize() 2023-01-12 11:59:15 +01:00
frecord.c fs/ntfs3: Validate data run offset 2023-01-12 11:58:43 +01:00
fslog.c fs/ntfs3: Fix slab-out-of-bounds in r_page 2023-01-12 11:58:45 +01:00
fsntfs.c fs/ntfs3: Validate index root when initialize NTFS security 2023-01-12 11:58:45 +01:00
index.c fs/ntfs3: Validate buffer length while parsing index 2023-01-12 11:58:44 +01:00
inode.c fs/ntfs3: Validate attribute data and valid sizes 2023-02-09 11:26:47 +01:00
Kconfig
lznt.c fs/ntfs3: Remove tabs before spaces from comment 2021-09-16 17:01:36 +03:00
Makefile
namei.c fs/ntfs3: Move ni_lock_dir and ni_unlock into ntfs_create_inode 2021-09-24 17:39:57 +03:00
ntfs_fs.h Fixed xfstests generic/016 generic/021 generic/022 generic/041 generic/274 generic/423, 2021-10-15 09:58:11 -04:00
ntfs.h fs/ntfs3: Change max hardlinks limit to 4000 2021-09-21 18:37:01 +03:00
record.c fs/ntfs3: Validate resident attribute name 2023-01-12 11:58:44 +01:00
run.c fs/ntfs3: Remove unneeded header files from c files 2021-09-13 19:41:46 +03:00
super.c fs/ntfs3: Use __GFP_NOWARN allocation at ntfs_fill_super() 2023-01-12 11:58:45 +01:00
upcase.c fs/ntfs3: Change right headers to upcase.c 2021-09-13 19:41:45 +03:00
xattr.c fs/ntfs3: Harden against integer overflows 2022-12-31 13:14:33 +01:00