linux/sound/soc/loongson
Arnd Bergmann 012fa2622e
ASoC: loongson: fix address space confusion
The i2s driver uses the mapped __iomem address of the FIFO as the DMA
address for the device. This apparently works on loongarch because of
the way it handles __iomem pointers as aliases of physical addresses,
but this is not portable to other architectures and causes a compiler
warning when dma addresses are not the same size as pointers:

sound/soc/loongson/loongson_i2s_pci.c: In function 'loongson_i2s_pci_probe':
sound/soc/loongson/loongson_i2s_pci.c:110:29: error: cast from pointer to integer of different size [-Werror=pointer-to-int-cast]
  110 |         tx_data->dev_addr = (dma_addr_t)i2s->reg_base + LS_I2S_TX_DATA;
      |                             ^
sound/soc/loongson/loongson_i2s_pci.c:113:29: error: cast from pointer to integer of different size [-Werror=pointer-to-int-cast]
  113 |         rx_data->dev_addr = (dma_addr_t)i2s->reg_base + LS_I2S_RX_DATA;
      |                             ^

Change the driver to instead use the physical address as stored in the
PCI BAR resource directly. Since 'dev_addr' is a 32-bit address, I think
this results in the same truncated address on loongarch but is otherwise
closer to portable code and avoids the warning.

Fixes: d84881e068 ("ASoC: Add support for Loongson I2S controller")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Link: https://lore.kernel.org/r/Message-Id: <20230622101235.3230941-1-arnd@kernel.org>
Signed-off-by: Mark Brown <broonie@kernel.org>
2023-06-22 18:02:06 +01:00
..
Kconfig ASoC: loongson: add PCI dependency 2023-06-16 12:56:08 +01:00
loongson_card.c ASoC: loongson: use snd_soc_{of_}get_dlc() 2023-06-20 12:49:27 +01:00
loongson_dma.c
loongson_dma.h
loongson_i2s_pci.c ASoC: loongson: fix address space confusion 2023-06-22 18:02:06 +01:00
loongson_i2s.c ASoC: loongson: fix compile testing on 32-bit 2023-06-16 12:56:09 +01:00
loongson_i2s.h ASoC: loongson: change the type of variable irq to int 2023-06-19 12:59:33 +01:00
Makefile ASoC: loongson: Add Loongson ASoC Sound Card Support 2023-06-15 13:53:27 +01:00