mirror of
https://mirrors.bfsu.edu.cn/git/linux.git
synced 2024-12-18 08:35:08 +08:00
5ee5a81df5
The plane allocator has been inherently racy since the beginning of the transition to atomic updates, as the allocator lock is released between free plane check (at .atomic_check() time) and the reservation (at .atomic_update() time). To fix it, create a new allocator solely based on the atomic plane states without keeping any external state and perform allocation in the .atomic_check() handler. The core idea is to replace the free planes bitmask with a collective knowledge based on the allocated hardware plane(s) for each KMS plane. The allocator then loops over all plane states to compute the free planes bitmask, allocates hardware planes based on that bitmask, and stores the result back in the plane states. For this to work we need to access the current state of planes not touched by the atomic update. To ensure that it won't be modified, we need to lock all planes using drm_atomic_get_plane_state(). This effectively serializes atomic updates from .atomic_check() up to completion, either when swapping the states if the check step has succeeded, or when freeing the states if the check step has failed. Suggested-by: Daniel Vetter <daniel.vetter@ffwll.ch> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
56 lines
1.6 KiB
C
56 lines
1.6 KiB
C
/*
|
|
* rcar_du_group.c -- R-Car Display Unit Planes and CRTCs Group
|
|
*
|
|
* Copyright (C) 2013-2014 Renesas Electronics Corporation
|
|
*
|
|
* Contact: Laurent Pinchart (laurent.pinchart@ideasonboard.com)
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation; either version 2 of the License, or
|
|
* (at your option) any later version.
|
|
*/
|
|
|
|
#ifndef __RCAR_DU_GROUP_H__
|
|
#define __RCAR_DU_GROUP_H__
|
|
|
|
#include <linux/mutex.h>
|
|
|
|
#include "rcar_du_plane.h"
|
|
|
|
struct rcar_du_device;
|
|
|
|
/*
|
|
* struct rcar_du_group - CRTCs and planes group
|
|
* @dev: the DU device
|
|
* @mmio_offset: registers offset in the device memory map
|
|
* @index: group index
|
|
* @use_count: number of users of the group (rcar_du_group_(get|put))
|
|
* @used_crtcs: number of CRTCs currently in use
|
|
* @lock: protects the DPTSR register
|
|
* @planes: planes handled by the group
|
|
*/
|
|
struct rcar_du_group {
|
|
struct rcar_du_device *dev;
|
|
unsigned int mmio_offset;
|
|
unsigned int index;
|
|
|
|
unsigned int use_count;
|
|
unsigned int used_crtcs;
|
|
|
|
struct mutex lock;
|
|
|
|
struct rcar_du_planes planes;
|
|
};
|
|
|
|
u32 rcar_du_group_read(struct rcar_du_group *rgrp, u32 reg);
|
|
void rcar_du_group_write(struct rcar_du_group *rgrp, u32 reg, u32 data);
|
|
|
|
int rcar_du_group_get(struct rcar_du_group *rgrp);
|
|
void rcar_du_group_put(struct rcar_du_group *rgrp);
|
|
void rcar_du_group_start_stop(struct rcar_du_group *rgrp, bool start);
|
|
void rcar_du_group_restart(struct rcar_du_group *rgrp);
|
|
int rcar_du_group_set_routing(struct rcar_du_group *rgrp);
|
|
|
|
#endif /* __RCAR_DU_GROUP_H__ */
|