mirror of
https://mirrors.bfsu.edu.cn/git/linux.git
synced 2025-01-11 00:04:33 +08:00
5d6de11c33
My static checker complains:
drivers/media/platform/soc_camera/mx2_camera.c:1070
mx2_emmaprp_resize() warn: no lower bound on 'num'
The heuristic is that it's looking for values which the user can
influence and we put an upper bound on them but we (perhaps
accidentally) allow negative numbers.
I am not very familiar with this code but I have looked at it and think
there might be a bug. Making the variable unsigned seems like a safe
option either way and this silences the static checker warning.
The call tree is:
-> subdev_do_ioctl()
-> mx2_camera_set_fmt()
-> mx2_emmaprp_resize()
The check:
if (num > RESIZE_NUM_MAX)
can underflow and then we use "num" on the else path.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
|
||
|---|---|---|
| .. | ||
| blackfin | ||
| coda | ||
| davinci | ||
| exynos4-is | ||
| exynos-gsc | ||
| marvell-ccic | ||
| omap | ||
| omap3isp | ||
| s3c-camif | ||
| s5p-g2d | ||
| s5p-jpeg | ||
| s5p-mfc | ||
| s5p-tv | ||
| soc_camera | ||
| ti-vpe | ||
| vivid | ||
| vsp1 | ||
| arv.c | ||
| fsl-viu.c | ||
| indycam.c | ||
| indycam.h | ||
| Kconfig | ||
| m2m-deinterlace.c | ||
| Makefile | ||
| mem2mem_testdev.c | ||
| mx2_emmaprp.c | ||
| sh_veu.c | ||
| sh_vou.c | ||
| timblogiw.c | ||
| via-camera.c | ||
| via-camera.h | ||
| vino.c | ||
| vino.h | ||