linux/drivers/nfc/st21nfca
Fedor Pchelkin 271eed1736 nfc: fix memory leak of se_io context in nfc_genl_se_io
[ Upstream commit 25ff6f8a5a ]

The callback context for sending/receiving APDUs to/from the selected
secure element is allocated inside nfc_genl_se_io and supposed to be
eventually freed in se_io_cb callback function. However, there are several
error paths where the bwi_timer is not charged to call se_io_cb later, and
the cb_context is leaked.

The patch proposes to free the cb_context explicitly on those error paths.

At the moment we can't simply check 'dev->ops->se_io()' return value as it
may be negative in both cases: when the timer was charged and was not.

Fixes: 5ce3f32b52 ("NFC: netlink: SE API implementation")
Reported-by: syzbot+df64c0a2e8d68e78a4fa@syzkaller.appspotmail.com
Signed-off-by: Fedor Pchelkin <pchelkin@ispras.ru>
Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2023-03-11 16:44:12 +01:00
..
core.c
dep.c NFC: st21nfca: add missed kfree_skb() in an error path 2020-06-10 20:24:54 +02:00
i2c.c NFC: st21nfca: Fix memory leak in device probe and remove 2022-01-05 12:37:44 +01:00
Kconfig
Makefile
se.c nfc: fix memory leak of se_io context in nfc_genl_se_io 2023-03-11 16:44:12 +01:00
st21nfca.h NFC: hci: fix sleep in atomic context bugs in nfc_hci_hcp_message_tx 2022-06-14 18:11:38 +02:00
vendor_cmds.c