Carlos Llamas 46f1dea17b binder: fix hang of unregistered readers ... commit 31643d84b8 upstream. With the introduction of binder_available_for_proc_work_ilocked() in commit 1b77e9dcc3 ("ANDROID: binder: remove proc waitqueue") a binder thread can only "wait_for_proc_work" after its thread->looper has been marked as BINDER_LOOPER_STATE_{ENTERED|REGISTERED}. This means an unregistered reader risks waiting indefinitely for work since it never gets added to the proc->waiting_threads. If there are no further references to its waitqueue either the task will hang. The same applies to readers using the (e)poll interface. I couldn't find the rationale behind this restriction. So this patch restores the previous behavior of allowing unregistered threads to "wait_for_proc_work". Note that an error message for this scenario, which had previously become unreachable, is now re-enabled. Fixes: 1b77e9dcc3 ("ANDROID: binder: remove proc waitqueue") Cc: stable@vger.kernel.org Cc: Martijn Coenen <maco@google.com> Cc: Arve Hjønnevåg <arve@google.com> Signed-off-by: Carlos Llamas <cmllamas@google.com> Link: https://lore.kernel.org/r/20240711201452.2017543-1-cmllamas@google.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2024-08-19 05:33:37 +02:00
..
binder_alloc_selftest.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 282	2019-06-05 17:36:37 +02:00
binder_alloc.c	binder: fix unused alloc->free_async_space	2024-01-25 14:34:29 -08:00
binder_alloc.h	binder: fix memory leak in binder_init()	2023-08-16 18:19:23 +02:00
binder_internal.h	binder: prevent UAF for binderfs devices II	2020-03-12 13:00:17 +01:00
binder_trace.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 282	2019-06-05 17:36:37 +02:00
binder.c	binder: fix hang of unregistered readers	2024-08-19 05:33:37 +02:00
binderfs.c	binderfs: use refcount for binder control devices too	2020-03-25 08:25:50 +01:00
Kconfig	binder: add functions to copy to/from binder buffers	2019-02-12 10:43:57 +01:00
Makefile	treewide: Add SPDX license identifier - Makefile/Kconfig	2019-05-21 10:50:46 +02:00