mirror of
https://mirrors.bfsu.edu.cn/git/linux.git
synced 2024-12-20 17:44:33 +08:00
e5f3155267
The 'imply' keyword does not do what most people think it does, it only
politely asks Kconfig to turn on another symbol, but does not prevent
it from being disabled manually or built as a loadable module when the
user is built-in. In the ICE driver, the latter now causes a link failure:
aarch64-linux-ld: drivers/net/ethernet/intel/ice/ice_main.o: in function `ice_eth_ioctl':
ice_main.c:(.text+0x13b0): undefined reference to `ice_ptp_get_ts_config'
ice_main.c:(.text+0x13b0): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `ice_ptp_get_ts_config'
aarch64-linux-ld: ice_main.c:(.text+0x13bc): undefined reference to `ice_ptp_set_ts_config'
ice_main.c:(.text+0x13bc): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `ice_ptp_set_ts_config'
aarch64-linux-ld: drivers/net/ethernet/intel/ice/ice_main.o: in function `ice_prepare_for_reset':
ice_main.c:(.text+0x31fc): undefined reference to `ice_ptp_release'
ice_main.c:(.text+0x31fc): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `ice_ptp_release'
aarch64-linux-ld: drivers/net/ethernet/intel/ice/ice_main.o: in function `ice_rebuild':
This is a recurring problem in many drivers, and we have discussed
it several times befores, without reaching a consensus. I'm providing
a link to the previous email thread for reference, which discusses
some related problems.
To solve the dependency issue better than the 'imply' keyword, introduce a
separate Kconfig symbol "CONFIG_PTP_1588_CLOCK_OPTIONAL" that any driver
can depend on if it is able to use PTP support when available, but works
fine without it. Whenever CONFIG_PTP_1588_CLOCK=m, those drivers are
then prevented from being built-in, the same way as with a 'depends on
PTP_1588_CLOCK || !PTP_1588_CLOCK' dependency that does the same trick,
but that can be rather confusing when you first see it.
Since this should cover the dependencies correctly, the IS_REACHABLE()
hack in the header is no longer needed now, and can be turned back
into a normal IS_ENABLED() check. Any driver that gets the dependency
wrong will now cause a link time failure rather than being unable to use
PTP support when that is in a loadable module.
However, the two recently added ptp_get_vclocks_index() and
ptp_convert_timestamp() interfaces are only called from builtin code with
ethtool and socket timestamps, so keep the current behavior by stubbing
those out completely when PTP is in a loadable module. This should be
addressed properly in a follow-up.
As Richard suggested, we may want to actually turn PTP support into a
'bool' option later on, preventing it from being a loadable module
altogether, which would be one way to solve the problem with the ethtool
interface.
Fixes: 06c16d89d2 ("ice: register 1588 PTP clock device object for E810 devices")
Link: https://lore.kernel.org/netdev/20210804121318.337276-1-arnd@kernel.org/
Link: https://lore.kernel.org/netdev/CAK8P3a06enZOf=XyZ+zcAwBczv41UuCTz+=0FMf2gBz1_cOnZQ@mail.gmail.com/
Link: https://lore.kernel.org/netdev/CAK8P3a3=eOxE-K25754+fB_-i_0BZzf9a9RfPTX3ppSwu9WZXw@mail.gmail.com/
Link: https://lore.kernel.org/netdev/20210726084540.3282344-1-arnd@kernel.org/
Acked-by: Shannon Nelson <snelson@pensando.io>
Acked-by: Jacob Keller <jacob.e.keller@intel.com>
Acked-by: Richard Cochran <richardcochran@gmail.com>
Reviewed-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Link: https://lore.kernel.org/r/20210812183509.1362782-1-arnd@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
108 lines
3.2 KiB
Plaintext
108 lines
3.2 KiB
Plaintext
# SPDX-License-Identifier: GPL-2.0-only
|
|
#
|
|
# Freescale device configuration
|
|
#
|
|
|
|
config NET_VENDOR_FREESCALE
|
|
bool "Freescale devices"
|
|
default y
|
|
depends on FSL_SOC || QUICC_ENGINE || CPM1 || CPM2 || PPC_MPC512x || \
|
|
M523x || M527x || M5272 || M528x || M520x || M532x || \
|
|
ARCH_MXC || ARCH_MXS || (PPC_MPC52xx && PPC_BESTCOMM) || \
|
|
ARCH_LAYERSCAPE || COMPILE_TEST
|
|
help
|
|
If you have a network (Ethernet) card belonging to this class, say Y.
|
|
|
|
Note that the answer to this question doesn't directly affect the
|
|
kernel: saying N will just cause the configurator to skip all
|
|
the questions about Freescale devices. If you say Y, you will be
|
|
asked for your specific card in the following questions.
|
|
|
|
if NET_VENDOR_FREESCALE
|
|
|
|
config FEC
|
|
tristate "FEC ethernet controller (of ColdFire and some i.MX CPUs)"
|
|
depends on (M523x || M527x || M5272 || M528x || M520x || M532x || \
|
|
ARCH_MXC || SOC_IMX28 || COMPILE_TEST)
|
|
default ARCH_MXC || SOC_IMX28 if ARM
|
|
depends on PTP_1588_CLOCK_OPTIONAL
|
|
select CRC32
|
|
select PHYLIB
|
|
imply NET_SELFTESTS
|
|
help
|
|
Say Y here if you want to use the built-in 10/100 Fast ethernet
|
|
controller on some Motorola ColdFire and Freescale i.MX processors.
|
|
|
|
config FEC_MPC52xx
|
|
tristate "FEC MPC52xx driver"
|
|
depends on PPC_MPC52xx && PPC_BESTCOMM
|
|
select CRC32
|
|
select PHYLIB
|
|
select PPC_BESTCOMM_FEC
|
|
help
|
|
This option enables support for the MPC5200's on-chip
|
|
Fast Ethernet Controller
|
|
If compiled as module, it will be called fec_mpc52xx.
|
|
|
|
config FEC_MPC52xx_MDIO
|
|
bool "FEC MPC52xx MDIO bus driver"
|
|
depends on FEC_MPC52xx
|
|
default y
|
|
help
|
|
The MPC5200's FEC can connect to the Ethernet either with
|
|
an external MII PHY chip or 10 Mbps 7-wire interface
|
|
(Motorola? industry standard).
|
|
If your board uses an external PHY connected to FEC, enable this.
|
|
If not sure, enable.
|
|
If compiled as module, it will be called fec_mpc52xx_phy.
|
|
|
|
source "drivers/net/ethernet/freescale/fs_enet/Kconfig"
|
|
source "drivers/net/ethernet/freescale/fman/Kconfig"
|
|
|
|
config FSL_PQ_MDIO
|
|
tristate "Freescale PQ MDIO"
|
|
select PHYLIB
|
|
help
|
|
This driver supports the MDIO bus used by the gianfar and UCC drivers.
|
|
|
|
config FSL_XGMAC_MDIO
|
|
tristate "Freescale XGMAC MDIO"
|
|
select PHYLIB
|
|
depends on OF
|
|
select OF_MDIO
|
|
help
|
|
This driver supports the MDIO bus on the Fman 10G Ethernet MACs, and
|
|
on the FMan mEMAC (which supports both Clauses 22 and 45)
|
|
|
|
config UCC_GETH
|
|
tristate "Freescale QE Gigabit Ethernet"
|
|
depends on QUICC_ENGINE && PPC32
|
|
select FSL_PQ_MDIO
|
|
select PHYLIB
|
|
select FIXED_PHY
|
|
help
|
|
This driver supports the Gigabit Ethernet mode of the QUICC Engine,
|
|
which is available on some Freescale SOCs.
|
|
|
|
config UGETH_TX_ON_DEMAND
|
|
bool "Transmit on Demand support"
|
|
depends on UCC_GETH
|
|
|
|
config GIANFAR
|
|
tristate "Gianfar Ethernet"
|
|
depends on HAS_DMA
|
|
select FSL_PQ_MDIO
|
|
select PHYLIB
|
|
select FIXED_PHY
|
|
select CRC32
|
|
help
|
|
This driver supports the Gigabit TSEC on the MPC83xx, MPC85xx,
|
|
and MPC86xx family of chips, the eTSEC on LS1021A and the FEC
|
|
on the 8540.
|
|
|
|
source "drivers/net/ethernet/freescale/dpaa/Kconfig"
|
|
source "drivers/net/ethernet/freescale/dpaa2/Kconfig"
|
|
source "drivers/net/ethernet/freescale/enetc/Kconfig"
|
|
|
|
endif # NET_VENDOR_FREESCALE
|