Lad Prabhakar 597f500fde thermal/core: Add a check before calling set_trip_temp() ... The thermal driver [0] for Renesas RZ/G2L SoC does not implement set_trip_temp() callback but has trips commit 9326167058 ("thermal/core: Move set_trip_temp ops to the sysfs code") changed the behaviour which causes the below panic when trying to set the trip temperature: root@smarc-rzg2l:~# echo 51000 > /sys/class/thermal/thermal_zone0/trip_point_0_temp [ 92.461521] Unable to handle kernel NULL pointer dereference at virtual address 0000000000000000 [ 92.470958] Mem abort info: [ 92.474311] ESR = 0x0000000086000004 [ 92.478546] EC = 0x21: IABT (current EL), IL = 32 bits [ 92.484290] SET = 0, FnV = 0 [ 92.487693] EA = 0, S1PTW = 0 [ 92.491153] FSC = 0x04: level 0 translation fault [ 92.496461] user pgtable: 4k pages, 48-bit VAs, pgdp=000000004e885000 [ 92.503736] [0000000000000000] pgd=0000000000000000, p4d=0000000000000000 [ 92.510869] Internal error: Oops: 86000004 [#3] PREEMPT SMP [ 92.516556] CPU: 0 PID: 290 Comm: sh Tainted: G D 6.0.0-rc4-next-20220906-arm64-renesas-00124-g84633c87c5f6-dirty #509 [ 92.528814] Hardware name: Renesas SMARC EVK based on r9a07g044l2 (DT) [ 92.535441] pstate: 60400005 (nZCv daif +PAN -UAO -TCO -DIT -SSBS BTYPE=--) [ 92.542516] pc : 0x0 [ 92.544764] lr : trip_point_temp_store+0x84/0x140 [ 92.549582] sp : ffff80000a92bc10 [ 92.552961] x29: ffff80000a92bc10 x28: ffff00000d8a45c0 x27: 0000000000000000 [ 92.560249] x26: 0000000000000000 x25: ffff8000082b53e8 x24: ffff00000eaffc20 [ 92.567532] x23: ffff80000a92bd68 x22: ffff00000d3e0f80 x21: 0000000000000006 [ 92.574814] x20: ffff800009149000 x19: ffff00000b8ab000 x18: 0000000000000000 [ 92.582097] x17: 0000000000000000 x16: 0000000000000000 x15: 0000aaab028cdee0 [ 92.589378] x14: 0000000000000000 x13: 0000000000000000 x12: ffff80000a92bbd0 [ 92.596659] x11: ffff00000d3e0f80 x10: ffff800009149eb8 x9 : 000000000000000a [ 92.603940] x8 : 00000000ffffffc9 x7 : 0000000000000005 x6 : 000000000000002a [ 92.611220] x5 : 000000000000c738 x4 : 00000000ffffffd3 x3 : 0000000000000000 [ 92.618500] x2 : 000000000000c738 x1 : 0000000000000000 x0 : ffff00000b8ab000 [ 92.625781] Call trace: [ 92.628282] 0x0 [ 92.630176] dev_attr_store+0x14/0x28 [ 92.633935] sysfs_kf_write+0x4c/0x70 [ 92.637681] kernfs_fop_write_iter+0x160/0x1e0 [ 92.642213] vfs_write+0x474/0x540 [ 92.645703] ksys_write+0x68/0xf8 [ 92.649100] __arm64_sys_write+0x18/0x20 [ 92.653111] invoke_syscall+0x40/0xf8 [ 92.656866] el0_svc_common.constprop.3+0x88/0x110 [ 92.661758] do_el0_svc+0x20/0x78 [ 92.665158] el0_svc+0x3c/0x90 [ 92.668291] el0t_64_sync_handler+0x90/0xb8 [ 92.672563] el0t_64_sync+0x148/0x14c [ 92.676322] Code: bad PC value [ 92.679453] ---[ end trace 0000000000000000 ]--- /bin/start_getty: line 40: 290 Segmentation fault ${setsid:-} ${getty} -L $1 $2 $3 Poky (Yocto Project Reference Distro) 3.2.1 smarc-rzg2l ttySC0 smarc-rzg2l login: This patch fixes the above issue by adding a check to see if set_trip_temp() callback is implemented before calling it. [0] drivers/thermal/rzg2l_thermal.c Fixes: 9326167058 ("thermal/core: Move set_trip_temp ops to the sysfs code") Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> Link: https://lore.kernel.org/r/20220908174610.7837-1-prabhakar.mahadev-lad.rj@bp.renesas.com Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>		2022-10-04 11:21:36 +02:00
..
broadcom	thermal/drivers/broadcom: Switch to new of API	2022-08-17 14:09:38 +02:00
intel	thermal: int340x: processor_thermal: Use module_pci_driver() macro	2022-09-24 19:22:09 +02:00
qcom	thermal/drivers/qcom/spmi-adc-tm5: Remove unnecessary print function dev_err()	2022-08-17 14:09:39 +02:00
samsung	thermal/drivers/samsung: Switch to new of thermal API	2022-08-17 14:09:39 +02:00
st	thermal/drivers/st: Switch to new of API	2022-08-17 14:09:38 +02:00
tegra	thermal/drivers/tegra: Switch to new of API	2022-08-17 14:09:38 +02:00
ti-soc-thermal	thermal/drivers/ti-soc: Switch to new of API	2022-08-17 14:09:38 +02:00
amlogic_thermal.c	thermal/drivers/amlogic: Switch to new of API	2022-08-17 14:09:38 +02:00
armada_thermal.c	thermal/drivers/armada: Switch to new of API	2022-08-17 14:09:38 +02:00
cpufreq_cooling.c	Merge branches 'thermal-intel' and 'thermal-drivers'	2022-10-03 20:43:32 +02:00
cpuidle_cooling.c	thermal/drivers/cpuidle_cooling: Fix use after error	2021-04-15 13:21:26 +02:00
da9062-thermal.c	thermal: da9062-thermal: Drop redundant error message	2022-08-31 20:58:25 +02:00
db8500_thermal.c	thermal/drivers/db8500: Switch to new of API	2022-08-17 14:09:38 +02:00
devfreq_cooling.c	Thermal control updates for 5.20-rc1	2022-08-02 11:27:53 -07:00
dove_thermal.c	thermal: Explicitly enable non-changing thermal zone devices	2020-06-29 20:26:37 +02:00
gov_bang_bang.c	thermal/core: Move the thermal zone lock out of the governors	2022-08-17 14:09:39 +02:00
gov_fair_share.c	thermal/core: Move the thermal zone lock out of the governors	2022-08-17 14:09:39 +02:00
gov_power_allocator.c	thermal/core: Move the thermal zone lock out of the governors	2022-08-17 14:09:39 +02:00
gov_step_wise.c	thermal/core: Move the thermal zone lock out of the governors	2022-08-17 14:09:39 +02:00
gov_user_space.c	thermal: gov_user_space: Do not lock thermal zone mutex	2022-08-30 20:18:47 +02:00
hisi_thermal.c	thermal/drivers/hisilicon: Switch to new of API	2022-08-17 14:09:38 +02:00
imx8mm_thermal.c	thermal/drivers/imx: Switch to new of API	2022-08-17 14:09:38 +02:00
imx_sc_thermal.c	thermal/drivers/imx_sc: Rely on the platform data to get the resource id	2022-10-04 11:20:59 +02:00
imx_thermal.c	thermal/drivers/imx: Implement runtime PM support	2021-11-30 15:42:28 +01:00
k3_bandgap.c	thermal/drivers/banggap: Switch to new of API	2022-08-17 14:09:38 +02:00
k3_j72xx_bandgap.c	thermal/drivers/banggap: Switch to new of API	2022-08-17 14:09:38 +02:00
Kconfig	thermal: Drop obsolete dependency on COMPILE_TEST	2022-08-03 19:15:31 +02:00
khadas_mcu_fan.c	thermal/core: Make cooling device state change private	2021-01-19 22:31:10 +01:00
kirkwood_thermal.c	thermal: Explicitly enable non-changing thermal zone devices	2020-06-29 20:26:37 +02:00
Makefile	thermal/drivers/qcom: Drop false build dependency of all QCOM drivers on QCOM_TSENS	2022-10-04 11:21:11 +02:00
max77620_thermal.c	thermal/drivers/maxim: Switch to new of API	2022-08-17 14:09:38 +02:00
mtk_thermal.c	thermal/drivers/mtk: Switch to new of API	2022-08-17 14:09:38 +02:00
qoriq_thermal.c	thermal/drivers/qoriq: Switch to new of API	2022-08-17 14:09:38 +02:00
rcar_gen3_thermal.c	thermal/drivers/rcar: Switch to new of API	2022-08-17 14:09:38 +02:00
rcar_thermal.c	thermal/drivers/rcar_thermal: Constify static thermal_zone_device_ops	2022-10-04 11:21:18 +02:00
rockchip_thermal.c	thermal/drivers/rockchip: Switch to new of API	2022-08-17 14:09:37 +02:00
rzg2l_thermal.c	thermal/drivers/rzg2l: Switch to new of API	2022-08-17 14:09:38 +02:00
spear_thermal.c	thermal: Explicitly enable non-changing thermal zone devices	2020-06-29 20:26:37 +02:00
sprd_thermal.c	thermal/drivers/sprd: Switch to new of API	2022-08-17 14:09:38 +02:00
sun8i_thermal.c	thermal/drivers/sun8i: Switch to new of API	2022-08-17 14:09:38 +02:00
thermal_core.c	thermal/core: Drop valid pointer check for type	2022-10-04 11:21:30 +02:00
thermal_core.h	thermal/core: Move the mutex inside the thermal_zone_device_update() function	2022-08-17 14:09:39 +02:00
thermal_helpers.c	thermal/core: Move the mutex inside the thermal_zone_device_update() function	2022-08-17 14:09:39 +02:00
thermal_hwmon.c	thermal: move from strlcpy() with unused retval to strscpy()	2022-08-31 21:13:35 +02:00
thermal_hwmon.h	thermal_hwmon: Add devres wrapper for thermal_add_hwmon_sysfs()	2020-01-27 10:24:32 +01:00
thermal_mmio.c	Merge branches 'thermal-intel' and 'thermal-drivers'	2022-10-03 20:43:32 +02:00
thermal_netlink.c	thermal/core: Rename 'trips' to 'num_trips'	2022-07-28 17:29:56 +02:00
thermal_netlink.h	thermal: netlink: Fix parameter type of thermal_genl_cpu_capability_event() stub	2022-02-07 20:45:42 +01:00
thermal_of.c	thermal/of: Remove the thermal_zone_of_get_sensor_id() function	2022-10-04 11:21:06 +02:00
thermal_sysfs.c	thermal/core: Add a check before calling set_trip_temp()	2022-10-04 11:21:36 +02:00
thermal-generic-adc.c	thermal/drivers/generic-adc: Switch to new of API	2022-08-17 14:09:37 +02:00
uniphier_thermal.c	thermal/drivers/uniphier: Switch to new of API	2022-08-17 14:09:37 +02:00