Shawn Lin 57678e5a3d mmc: block: Delete gendisk before cleaning up the request queue ... dd if=/dev/urandom of=/dev/mmcblk1 bs=4k count=10000 with a SD card hotplug during transfer reports a warning below introduced by commit a063057d7c ("block: Fix a race between request queue removal and the block cgroup controller"). So we should now remove the disk, partition and bdi sysfs attributes before cleaning up the request queue associated with the disk. [ 410.331226] mmc1: card 59b4 removed [ 410.348583] WARNING: CPU: 0 PID: 5 at block/blk-core.c:785 blk_cleanup_queue+0x138/0x140 [ 410.349294] Modules linked in: [ 410.349570] CPU: 0 PID: 5 Comm: kworker/0:0 Not tainted 4.16.0-rc6-next-20180321-00004-gc2ad6a7 #263 [ 410.350363] Hardware name: Excavator-RK3399 Board (DT) [ 410.350819] Workqueue: events_freezable mmc_rescan [ 410.351242] pstate: 60000005 (nZCv daif -PAN -UAO) [ 410.351663] pc : blk_cleanup_queue+0x138/0x140 [ 410.352054] lr : blk_cleanup_queue+0xac/0x140 [ 410.352436] sp : ffff0000092cbb90 [ 410.352727] x29: ffff0000092cbb90 x28: 0000000000000000 [ 410.353195] x27: ffff8000f6f23030 x26: ffff00000904e610 [ 410.353662] x25: ffff8000f17cc808 x24: ffff8000f1038200 [ 410.354128] x23: 0000000000000060 x22: 0000000000000000 [ 410.354595] x21: ffff8000f11748d8 x20: ffff8000f1038200 [ 410.355061] x19: ffff8000f1174200 x18: 0000ffff936347d8 [ 410.355528] x17: 0000ffff935b93c0 x16: ffff0000081263f8 [ 410.355994] x15: 0000000000000000 x14: 0000000000000400 [ 410.356461] x13: 0000000000000001 x12: 0000000000000001 [ 410.356927] x11: 0000000000000040 x10: ffff8000f2400028 [ 410.357393] x9 : ffff8000f2400040 x8 : 0000000000000000 [ 410.357860] x7 : ffff8000f6f3a340 x6 : ffff8000f6f3a340 [ 410.358326] x5 : ffff8000f2400000 x4 : ffff8000f6f3a340 [ 410.358792] x3 : 0000000000000000 x2 : 39c1333e45670800 [ 410.359259] x1 : 0000000000000000 x0 : 0000000000000003 [ 410.359726] Call trace: [ 410.359943] blk_cleanup_queue+0x138/0x140 [ 410.360305] mmc_cleanup_queue+0x2c/0x48 [ 410.360652] mmc_blk_remove_req+0x1c/0x98 [ 410.361005] mmc_blk_remove+0x180/0x1c0 [ 410.361343] mmc_bus_remove+0x1c/0x28 [ 410.361670] device_release_driver_internal+0x154/0x1f0 [ 410.362128] device_release_driver+0x14/0x20 [ 410.362504] bus_remove_device+0xc8/0x108 [ 410.362858] device_del+0x120/0x350 [ 410.363167] mmc_remove_card+0x5c/0xb8 [ 410.363498] mmc_sd_detect+0x40/0x78 [ 410.363813] mmc_rescan+0x19c/0x368 [ 410.364123] process_one_work+0x1ac/0x318 [ 410.364477] worker_thread+0x50/0x450 [ 410.364801] kthread+0xf8/0x128 [ 410.365081] ret_from_fork+0x10/0x18 [ 410.365395] ---[ end trace 268e87a46c28968c ]--- Reviewed-by: Bart Van Assche <bart.vanassche@wdc.com> Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com> Signed-off-by: Jens Axboe <axboe@kernel.dk>		2018-03-22 11:04:32 -06:00
..
block.c	mmc: block: Delete gendisk before cleaning up the request queue	2018-03-22 11:04:32 -06:00
block.h	mmc: block: Remove code no longer needed after the switch to blk-mq	2017-12-11 13:02:22 +01:00
bus.c	mmc: core: Remove code no longer needed after the switch to blk-mq	2017-12-11 13:05:58 +01:00
bus.h	mmc: core: Move public functions from card.h to private headers	2017-02-13 13:20:24 +01:00
card.h	mmc: core: apply NO_CMD23 quirk to some specific cards	2017-12-11 13:43:27 +01:00
core.c	mmc: avoid removing non-removable hosts during suspend	2017-12-18 13:56:59 +01:00
core.h	mmc: core: Remove code no longer needed after the switch to blk-mq	2017-12-11 13:05:58 +01:00
debugfs.c	mmc: block: Ensure that debugfs files are removed	2017-11-23 14:39:13 +01:00
host.c	mmc: core: Remove option not to use blk-mq	2017-12-11 12:55:02 +01:00
host.h	mmc: core: Remove code no longer needed after the switch to blk-mq	2017-12-11 13:05:58 +01:00
Kconfig	mmc: core: Delete bounce buffer Kconfig option	2017-06-20 10:30:17 +02:00
Makefile	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
mmc_ops.c	mmc: core: Export a few functions needed for blkmq support	2017-10-30 11:45:56 +01:00
mmc_ops.h	mmc: core: Re-factor code for sending CID	2017-06-20 10:30:45 +02:00
mmc_test.c	mmc: mmc_test: Ensure command queue is disabled for testing	2017-12-11 12:51:29 +01:00
mmc.c	mmc: core: properly init drv_type	2017-12-05 17:14:00 +01:00
pwrseq_emmc.c	mmc: core: Don't do eMMC HW reset when resuming the eMMC card	2017-06-20 10:30:10 +02:00
pwrseq_sd8787.c	mmc: pwrseq: add support for Marvell SD8787 chip	2017-02-13 13:20:33 +01:00
pwrseq_simple.c	mmc: pwrseq_simple: Parse DTS for the power-off-delay-us property	2017-05-23 14:17:36 +02:00
pwrseq.c	mmc: pwrseq: Add reset callback to the struct mmc_pwrseq_ops	2017-06-20 10:30:09 +02:00
pwrseq.h	mmc: pwrseq: Add reset callback to the struct mmc_pwrseq_ops	2017-06-20 10:30:09 +02:00
queue.c	block: Use blk_queue_flag_*() in drivers instead of queue_flag_*()	2018-03-08 14:13:48 -07:00
queue.h	mmc: block: Remove code no longer needed after the switch to blk-mq	2017-12-11 13:02:22 +01:00
quirks.h	mmc: core: apply NO_CMD23 quirk to some specific cards	2017-12-11 13:43:27 +01:00
sd_ops.c	mmc: core: add proper be32 annotation	2017-04-24 21:42:19 +02:00
sd_ops.h	mmc: core: add proper be32 annotation	2017-04-24 21:42:19 +02:00
sd.c	mmc: core: prepend 0x to OCR entry in sysfs	2017-11-29 10:46:53 +01:00
sd.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
sdio_bus.c	mmc: sdio: fix alignment issue in struct sdio_func	2017-04-18 19:18:07 +02:00
sdio_bus.h	mmc: core: First step in cleaning up private mmc header files	2017-02-13 13:20:20 +01:00
sdio_cis.c	mmc: core: remove BUG_ONs from sdio	2016-12-05 10:31:08 +01:00
sdio_cis.h	mmc: core: First step in cleaning up private mmc header files	2017-02-13 13:20:20 +01:00
sdio_io.c	mmc: core: simplify return code	2017-04-24 21:41:24 +02:00
sdio_irq.c	mmc: core: Introduce host claiming by context	2017-10-30 11:45:49 +01:00
sdio_ops.c	mmc: sdio: improve mmc_io_rw_extended	2017-04-24 21:41:42 +02:00
sdio_ops.h	mmc: sdio: Add API to manage SDIO IRQs from a workqueue	2017-06-20 10:30:11 +02:00
sdio_uart.c	mmc: block: Move files to core	2016-12-12 16:30:05 +01:00
sdio.c	mmc: sdio: Keep card runtime resumed while adding function devices	2017-06-20 10:30:39 +02:00
slot-gpio.c	mmc: slot-gpio: add a helper to check capability of GPIO WP detection	2018-01-18 09:08:56 +01:00
slot-gpio.h	mmc: core: First step in cleaning up private mmc header files	2017-02-13 13:20:20 +01:00