Fabio M. De Francesco f451fd97dd ext4: drop the call to ext4_error() from ext4_get_group_info() ... A recent patch added a call to ext4_error() which is problematic since some callers of the ext4_get_group_info() function may be holding a spinlock, whereas ext4_error() must never be called in atomic context. This triggered a report from Syzbot: "BUG: sleeping function called from invalid context in ext4_update_super" (see the link below). Therefore, drop the call to ext4_error() from ext4_get_group_info(). In the meantime use eight characters tabs instead of nine characters ones. Reported-by: syzbot+4acc7d910e617b360859@syzkaller.appspotmail.com Closes: https://lore.kernel.org/all/00000000000070575805fdc6cdb2@google.com/ Fixes: 5354b2af34 ("ext4: allow ext4_get_group_info() to fail") Suggested-by: Theodore Ts'o <tytso@mit.edu> Signed-off-by: Fabio M. De Francesco <fmdefrancesco@gmail.com> Link: https://lore.kernel.org/r/20230614100446.14337-1-fmdefrancesco@gmail.com		2023-06-14 22:24:05 -04:00
..
.kunitconfig	ext4: add .kunitconfig fragment to enable ext4-specific tests	2021-02-11 23:16:30 -05:00
acl.c	fs: port acl to mnt_idmap	2023-01-19 09:24:28 +01:00
acl.h	fs: port ->set_acl() to pass mnt_idmap	2023-01-19 09:24:27 +01:00
balloc.c	ext4: drop the call to ext4_error() from ext4_get_group_info()	2023-06-14 22:24:05 -04:00
bitmap.c	ext4: remove useless conditional branch code	2023-04-19 23:39:08 -04:00
block_validity.c	ext4: add ext4_sb_block_valid() refactored out of ext4_inode_block_valid()	2022-02-25 21:34:56 -05:00
crypto.c	ext4: refactor and move ext4_ioctl_get_encryption_pwsalt()	2022-05-21 22:24:24 -04:00
dir.c	ext4: fix spelling errors in comments	2022-05-11 15:19:06 -04:00
ext4_extents.h	ext4: fix sparse warnings	2021-08-30 23:36:50 -04:00
ext4_jbd2.c	ext4: split ext4_journal_start trace for debug	2022-12-01 10:46:54 -05:00
ext4_jbd2.h	ext4: split ext4_journal_start trace for debug	2022-12-01 10:46:54 -05:00
ext4.h	ext4: add lockdep annotations for i_data_sem for ea_inode's	2023-05-30 15:33:57 -04:00
extents_status.c	ext4: fix data races when using cached status extents	2023-05-13 18:05:04 -04:00
extents_status.h	ext4: fix extent_status trace points	2020-01-25 02:03:03 -05:00
extents.c	ext4: fix use-after-free read in ext4_find_extent for bigalloc + inline	2023-04-28 12:56:35 -04:00
fast_commit.c	ext4: use ext4_fc_tl_mem in fast-commit replay path	2023-02-09 10:43:23 -05:00
fast_commit.h	ext4: add missing validation of fast-commit record lengths	2022-12-08 21:49:24 -05:00
file.c	fs: add FMODE_DIO_PARALLEL_WRITE flag	2023-04-03 07:14:20 -06:00
fsmap.c	ext4: fix another off-by-one fsmap error on 1k block filesystems	2023-03-07 20:20:48 -05:00
fsmap.h	ext4: fsmap: fix the block/inode bitmap comment	2021-06-24 09:48:29 -04:00
fsync.c	ext4: fix fsync for non-directories	2023-05-30 15:33:57 -04:00
hash.c	ext4: improve error handling from ext4_dirhash()	2023-05-13 18:05:05 -04:00
ialloc.c	ext4: allow ext4_get_group_info() to fail	2023-05-13 18:02:46 -04:00
indirect.c	ext4: fix error code return to user-space in ext4_get_branch()	2022-12-08 21:49:24 -05:00
inline.c	ext4: bail out of ext4_xattr_ibody_get() fails for any reason	2023-05-13 18:05:05 -04:00
inode-test.c	fs: ext4: Modify inode-test.c to use KUnit parameterized testing feature	2020-12-02 16:07:25 -07:00
inode.c	ext4: disallow ea_inodes with extended attributes	2023-05-30 15:33:57 -04:00
ioctl.c	Bug fixes and regressions for ext4, the most serious of which is a	2023-03-12 08:55:55 -07:00
Kconfig	ext: EXT4_KUNIT_TESTS should depend on EXT4_FS instead of selecting it	2021-02-11 23:12:59 -05:00
Makefile	ext4: move ext4 crypto code to its own file crypto.c	2022-05-21 22:24:24 -04:00
mballoc.c	Revert "ext4: remove ac->ac_found > sbi->s_mb_min_to_scan dead check in ext4_mb_check_limits"	2023-06-02 14:47:29 -04:00
mballoc.h	ext4: Remove the logic to trim inode PAs	2023-04-06 01:13:13 -04:00
migrate.c	ext4: avoid deadlock in fs reclaim with page writeback	2023-05-13 18:05:04 -04:00
mmp.c	ext4: fix lockdep warning when enabling MMP	2023-05-07 21:11:18 -04:00
move_extent.c	- Nick Piggin's "shoot lazy tlbs" series, to improve the peformance of	2023-04-27 19:42:02 -07:00
namei.c	ext4: improve error handling from ext4_dirhash()	2023-05-13 18:05:05 -04:00
orphan.c	ext4: remove trailing newline from ext4_msg() message	2022-12-08 21:49:23 -05:00
page-io.c	ext4: remove unneeded check of nr_to_submit	2023-04-19 23:38:33 -04:00
readpage.c	ext4: Use a folio iterator in __read_end_io()	2023-04-06 13:39:52 -04:00
resize.c	ext4: remove unused group parameter in ext4_block_bitmap_csum_set	2023-03-23 23:00:08 -04:00
super.c	Revert "ext4: don't clear SB_RDONLY when remounting r/w until quota is re-enabled"	2023-06-08 09:57:04 -04:00
symlink.c	fs: port ->getattr() to pass mnt_idmap	2023-01-19 09:24:25 +01:00
sysfs.c	ext4: Remove the logic to trim inode PAs	2023-04-06 01:13:13 -04:00
truncate.h	ext4: Convert to use mapping->invalidate_lock	2021-07-13 14:29:00 +02:00
verity.c	- Nick Piggin's "shoot lazy tlbs" series, to improve the peformance of	2023-04-27 19:42:02 -07:00
xattr_hurd.c	fs: port xattr to mnt_idmap	2023-01-19 09:24:28 +01:00
xattr_security.c	fs: port xattr to mnt_idmap	2023-01-19 09:24:28 +01:00
xattr_trusted.c	fs: port xattr to mnt_idmap	2023-01-19 09:24:28 +01:00
xattr_user.c	fs: port xattr to mnt_idmap	2023-01-19 09:24:28 +01:00
xattr.c	ext4: only check dquot_initialize_needed() when debugging	2023-06-08 10:06:40 -04:00
xattr.h	ext4: remove EA inode entry from mbcache on inode eviction	2022-08-02 23:56:25 -04:00