Chao Yu 54d7185642 f2fs: avoid accessing NULL pointer in f2fs_drop_largest_extent ... If extent cache is disable, we will encounter oops when triggering direct IO as below: BUG: unable to handle kernel NULL pointer dereference at 0000000c IP: [<f0b9c61e>] f2fs_drop_largest_extent+0xe/0x30 [f2fs] *pdpt = 000000002bb9a001 *pde = 0000000000000000 Oops: 0000 [#1] SMP Modules linked in: f2fs(O) fuse bnep rfcomm bluetooth nfsd dm_crypt nfs_acl auth_rpcgss oid_registry nfs binfmt_misc fscache lockd sunrpc grace snd_intel8x0 snd_ac97_codec ac97_bus snd_pcm snd_seq_midi snd_rawmidi snd_seq_midi_event snd_seq snd_timer snd_seq_device snd soundcore joydev psmouse hid_generic i2c_piix4 serio_raw ppdev mac_hid parport_pc lp parport ext4 jbd2 mbcache usbhid hid e1000 CPU: 3 PID: 3608 Comm: dd Tainted: G O 4.2.0-rc4 #12 Hardware name: innotek GmbH VirtualBox/VirtualBox, BIOS VirtualBox 12/01/2006 task: ef161600 ti: ebd5e000 task.ti: ebd5e000 EIP: 0060:[<f0b9c61e>] EFLAGS: 00010202 CPU: 3 EIP is at f2fs_drop_largest_extent+0xe/0x30 [f2fs] EAX: 00000000 EBX: ddebc000 ECX: 00000000 EDX: 00000000 ESI: ebd5fdf8 EDI: 00000000 EBP: ebd5fd58 ESP: ebd5fd58 DS: 007b ES: 007b FS: 00d8 GS: 0033 SS: 0068 CR0: 80050033 CR2: 0000000c CR3: 2c24ee40 CR4: 000006f0 Stack: ebd5fda4 f0b8c005 00000000 00000001 00000000 f0b8c430 c816cd68 ddebc000 ddebc088 00001000 00000555 00000555 ffffffff c160bb00 00055501 00000000 00000000 00000100 00000000 ebd5fe20 f0b8c430 00000046 ef161600 00001000 Call Trace: [<f0b8c005>] __allocate_data_block+0x1a5/0x260 [f2fs] [<f0b8c430>] ? f2fs_direct_IO+0x370/0x440 [f2fs] [<c160bb00>] ? down_read+0x30/0x50 [<f0b8c430>] f2fs_direct_IO+0x370/0x440 [f2fs] [<c113e115>] generic_file_direct_write+0xa5/0x260 [<c10b53f8>] ? current_fs_time+0x18/0x50 [<c113e38b>] __generic_file_write_iter+0xbb/0x210 [<c113e50f>] ? generic_file_write_iter+0x2f/0x320 [<c113e63c>] generic_file_write_iter+0x15c/0x320 [<f0b77f29>] f2fs_file_write_iter+0x39/0x80 [f2fs] [<c11984d9>] __vfs_write+0xa9/0xe0 [<c1199227>] vfs_write+0x97/0x180 [<c119955b>] SyS_write+0x5b/0xd0 [<c160dcd0>] sysenter_do_call+0x12/0x12 Code: 10 8b 50 1c 89 53 14 eb ca 8d 74 26 00 85 f6 74 86 eb a6 0f 0b 90 8d b4 26 00 00 00 00 55 89 e5 3e 8d 74 26 00 8b 80 d4 02 00 00 <8b> 48 0c 39 d1 77 0e 03 48 14 39 ca 73 07 c7 40 14 00 00 00 00 EIP: [<f0b9c61e>] f2fs_drop_largest_extent+0xe/0x30 [f2fs] SS:ESP 0068:ebd5fd58 CR2: 000000000000000c ---[ end trace a38c07026a1afffd ]--- This is because when extent cache is disable, extent_tree pointer in struct f2fs_inode_info should be NULL, but in f2fs_drop_largest_extent we access this NULL pointer directly without checking state of extent cache, then, the oops occurs. Let's fix it by checking state of extent cache before accessing. Signed-off-by: Chao Yu <chao2.yu@samsung.com> Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>		2015-08-28 10:14:26 -07:00
..
9p	9p: don't leave a half-initialized inode sitting around	2015-07-12 11:22:05 -04:00
adfs	fs/adfs: remove unneeded cast	2015-06-30 19:44:57 -07:00
affs	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2015-07-04 19:36:06 -07:00
afs	net: Add a struct net parameter to sock_create_kern	2015-05-11 10:50:17 -04:00
autofs4	make simple_positive() public	2015-06-23 18:02:01 -04:00
befs	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2015-07-04 19:36:06 -07:00
bfs	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2015-04-26 17:22:07 -07:00
btrfs	Merge branch 'for-linus-4.2' of git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs	2015-07-31 17:05:37 -07:00
cachefiles	Merge branch 'fscache-fixes' into for-next	2015-06-23 18:01:30 -04:00
ceph	ceph: always re-send cap flushes when MDS recovers	2015-07-31 11:38:53 +03:00
cifs	cifs: Unset CIFS_MOUNT_POSIX_PATHS flag when following dfs mounts	2015-06-29 14:50:22 -05:00
coda	fs: cleanup slight list_entry abuse	2015-06-23 18:01:59 -04:00
configfs	configfs: fix kernel infoleak through user-controlled format string	2015-07-17 16:39:53 -07:00
cramfs
debugfs	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2015-07-04 19:36:06 -07:00
devpts	devpts: if initialization failed, don't crash when opening /dev/ptmx	2015-06-30 19:44:58 -07:00
dlm	net: Add a struct net parameter to sock_create_kern	2015-05-11 10:50:17 -04:00
ecryptfs	ioctl_compat: handle FITRIM	2015-07-09 11:42:21 -07:00
efivarfs	Merge branch 'x86-urgent-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip	2015-05-06 10:57:37 -07:00
efs	fs/efs: femove unneeded cast	2015-06-25 17:00:42 -07:00
exofs	pagemap.h: move dir_pages() over there	2015-06-23 18:02:00 -04:00
exportfs	VFS: (Scripted) Convert S_ISLNK/DIR/REG(dentry->d_inode) to d_is_*(dentry)	2015-02-22 11:38:41 -05:00
ext2	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2015-07-04 19:36:06 -07:00
ext3	Merge branch 'for_linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jack/linux-fs	2015-06-24 20:07:10 -07:00
ext4	ioctl_compat: handle FITRIM	2015-07-09 11:42:21 -07:00
f2fs	f2fs: avoid accessing NULL pointer in f2fs_drop_largest_extent	2015-08-28 10:14:26 -07:00
fat	writeback: separate out include/linux/backing-dev-defs.h	2015-06-02 08:33:34 -06:00
freevxfs	pagemap.h: move dir_pages() over there	2015-06-23 18:02:00 -04:00
fscache	FS-Cache: Retain the netfs context in the retrieval op earlier	2015-04-02 14:28:53 +01:00
fuse	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2015-07-04 19:36:06 -07:00
gfs2	GFS2: merge window	2015-06-27 09:47:46 -07:00
hfs	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2015-07-04 19:36:06 -07:00
hfsplus	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2015-07-04 19:36:06 -07:00
hostfs	Merge branch 'for-linus-1' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2015-06-22 12:51:21 -07:00
hpfs	hpfs: hpfs_error: Remove static buffer, use vsprintf extension %pV instead	2015-07-09 13:35:31 -07:00
hugetlbfs	mm/hugetlb: reduce arch dependent code about hugetlb_prefault_arch_hook	2015-06-24 17:49:41 -07:00
isofs	VFS: normal filesystems (and lustre): d_inode() annotations	2015-04-15 15:06:57 -04:00
jbd
jbd2	Revert "jbd2: speedup jbd2_journal_dirty_metadata()"	2015-06-27 09:41:50 -07:00
jffs2	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2015-07-04 19:36:06 -07:00
jfs	A couple trivial fixes and an error path fix	2015-07-16 16:28:28 -07:00
kernfs	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/ebiederm/user-namespace	2015-07-03 15:20:57 -07:00
lockd	nfsd: eliminate NFSD_DEBUG	2015-04-21 16:16:02 -04:00
logfs	logfs: fix a pagecache leak for symlinks	2015-05-10 22:18:28 -04:00
minix	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2015-07-04 19:36:06 -07:00
ncpfs	ncpfs: successful rename() should invalidate caches for parents	2015-06-14 11:31:39 -04:00
nfs	NFS client bugfixes for Linux 4.2	2015-07-28 09:37:44 -07:00
nfs_common
nfsd	nfsd: wrap too long lines in nfsd4_encode_read	2015-06-22 14:15:05 -04:00
nilfs2	ioctl_compat: handle FITRIM	2015-07-09 11:42:21 -07:00
nls
notify	Revert "fsnotify: fix oops in fsnotify_clear_marks_by_group_flags()"	2015-07-21 16:06:53 -07:00
ntfs	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2015-07-04 19:36:06 -07:00
ocfs2	ioctl_compat: handle FITRIM	2015-07-09 11:42:21 -07:00
omfs	omfs: fix potential integer overflow in allocator	2015-05-28 18:25:19 -07:00
openpromfs
overlayfs	fix a braino in ovl_d_select_inode()	2015-07-12 11:22:05 -04:00
proc	Merge branch 'x86-urgent-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip	2015-07-18 10:49:57 -07:00
pstore	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/ebiederm/user-namespace	2015-07-03 15:20:57 -07:00
qnx4
qnx6	pagemap.h: move dir_pages() over there	2015-06-23 18:02:00 -04:00
quota	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2015-04-26 17:22:07 -07:00
ramfs	VFS: normal filesystems (and lustre): d_inode() annotations	2015-04-15 15:06:57 -04:00
reiserfs	Merge branch 'akpm' (patches from Andrew)	2015-06-26 09:52:05 -07:00
romfs	make new_sync_{read,write}() static	2015-04-11 22:29:40 -04:00
squashfs	fs: cleanup slight list_entry abuse	2015-06-23 18:01:59 -04:00
sysfs	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/ebiederm/user-namespace	2015-07-03 15:20:57 -07:00
sysv	pagemap.h: move dir_pages() over there	2015-06-23 18:02:00 -04:00
tracefs	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2015-07-04 19:36:06 -07:00
ubifs	This pull request includes the following UBI/UBIFS changes:	2015-06-25 14:11:34 -07:00
udf	udf: Don't corrupt unalloc spacetable when writing it	2015-07-09 16:38:57 +02:00
ufs	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2015-07-04 19:36:06 -07:00
xfs	xfs: remote attributes need to be considered data	2015-07-29 11:48:02 +10:00
aio.c	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2015-04-16 23:27:56 -04:00
anon_inodes.c
attr.c
bad_inode.c	don't bother with most of the bad_file_ops methods	2015-02-20 04:03:58 -05:00
binfmt_aout.c
binfmt_elf_fdpic.c
binfmt_elf.c	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2015-07-04 19:36:06 -07:00
binfmt_em86.c
binfmt_flat.c
binfmt_misc.c	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2015-04-26 17:22:07 -07:00
binfmt_script.c
block_dev.c	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2015-07-04 19:36:06 -07:00
buffer.c	buffer: remove unusued 'ret' variable	2015-06-02 09:22:34 -06:00
char_dev.c
compat_binfmt_elf.c
compat_ioctl.c	ioctl_compat: handle FITRIM	2015-07-09 11:42:21 -07:00
compat.c
coredump.c	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2015-07-04 19:36:06 -07:00
dax.c	xfs: call dax_fault on read page faults for DAX	2015-07-29 11:48:00 +10:00
dcache.c	freeing unlinked file indefinitely delayed	2015-07-12 11:27:04 -04:00
dcookies.c
direct-io.c	direct-io: only inc/dec inode->i_dio_count for file systems	2015-04-24 15:45:28 -04:00
drop_caches.c
eventfd.c	eventfd: don't take the spinlock in eventfd_poll	2015-02-17 14:34:52 -08:00
eventpoll.c
exec.c	parisc,metag: Fix crashes due to stack randomization on stack-grows-upwards architectures	2015-05-12 22:03:44 +02:00
fcntl.c
fhandle.c	vfs: read file_handle only once in handle_to_path	2015-06-02 10:29:07 -07:00
file_table.c	remove the pointless include of lglock.h	2015-06-23 18:02:00 -04:00
file.c	fs/file.c: __fget() and dup2() atomicity rules	2015-07-01 02:31:08 -04:00
filesystems.c
fs_pin.c	fs_pin: Allow for the possibility that m_list or s_list go unused.	2015-04-09 11:39:55 -05:00
fs_struct.c
fs-writeback.c	block: export bio_associate_*() and wbc_account_io()	2015-07-23 13:36:44 -06:00
inode.c	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2015-07-04 19:36:06 -07:00
internal.h	overlayfs: Make f_path always point to the overlay and f_inode to the underlay	2015-06-19 03:19:32 -04:00
ioctl.c
Kconfig	f2fs: relocate Kconfig from misc filesystems	2015-04-10 15:08:35 -07:00
Kconfig.binfmt	mm: split ET_DYN ASLR from mmap ASLR	2015-04-14 16:49:05 -07:00
libfs.c	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2015-07-04 19:36:06 -07:00
locks.c	locks: inline posix_lock_file_wait and flock_lock_file_wait	2015-07-13 06:29:11 -04:00
Makefile	um: Remove hppfs	2015-05-31 13:23:08 +02:00
mbcache.c
mount.h	fs: use seq_open_private() for proc_mounts	2015-06-30 19:44:56 -07:00
mpage.c	writeback: implement foreign cgroup inode detection	2015-06-02 08:40:20 -06:00
namei.c	link_path_walk(): be careful when failing with ENOTDIR	2015-08-01 20:18:38 -04:00
namespace.c	mnt: In detach_mounts detach the appropriate unmounted mount	2015-07-23 11:31:15 -05:00
no-block.c
nsfs.c	VFS: assorted weird filesystems: d_inode() annotations	2015-04-15 15:06:58 -04:00
open.c	fs: Call security_ops->inode_killpriv on truncate	2015-06-23 18:01:09 -04:00
pipe.c	VFS: assorted weird filesystems: d_inode() annotations	2015-04-15 15:06:58 -04:00
pnode.c	mnt: Don't propagate unmounts to locked mounts	2015-04-02 20:34:20 -05:00
pnode.h	mnt: Clarify and correct the disconnect logic in umount_tree	2015-07-22 20:33:27 -05:00
posix_acl.c	fs/posix_acl.c: make posix_acl_create() safer and cleaner	2015-06-23 18:01:07 -04:00
proc_namespace.c	fs: use seq_open_private() for proc_mounts	2015-06-30 19:44:56 -07:00
read_write.c	new_sync_write(): discard ->ki_pos unless the return value is positive	2015-04-11 22:29:46 -04:00
readdir.c
select.c	locking/arch: Rename set_mb() to smp_store_mb()	2015-05-19 08:32:00 +02:00
seq_file.c	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2015-07-04 19:36:06 -07:00
signalfd.c
splice.c	Merge branch 'akpm' (patches from Andrew)	2015-06-24 20:47:21 -07:00
stack.c
stat.c	VFS: assorted d_backing_inode() annotations	2015-04-15 15:06:59 -04:00
statfs.c
super.c	fs:super:get_anon_bdev: fix race condition could cause dev exceed its upper limitation	2015-07-01 01:50:06 -04:00
sync.c
timerfd.c
utimes.c
xattr.c	evm: fix potential race when removing xattrs	2015-05-21 13:28:47 -04:00