Donald Robson 51097ef14d drm/imagination: Fixed warning due to implicit cast to bool ... This line appears to confuse the compiler and had been noticed previously in clang-tidy output. There isn't anything fundamentally wrong that I can see. I suspect that it just looks like a mistake - hence the first note. By making the second operand an actual bool result, const correctness can be preserved while silencing the warning. >> drivers/gpu/drm/imagination/pvr_device_info.c:230:47: warning: use of logical '&&' with constant operand [-Wconstant-logical-operand] 230 | } else if (features_size == mapping_max_size && (mapping_max & 63)) { | ^ ~~~~~~~~~~~~~~~~~~ drivers/gpu/drm/imagination/pvr_device_info.c:230:47: note: use '&' for a bitwise operation 230 | } else if (features_size == mapping_max_size && (mapping_max & 63)) { | ^~ | & drivers/gpu/drm/imagination/pvr_device_info.c:230:47: note: remove constant to silence this warning 230 | } else if (features_size == mapping_max_size && (mapping_max & 63)) { | ~^~~~~~~~~~~~~~~~~~~~~ 1 warning generated. Reported-by: kernel test robot <lkp@intel.com> Closes: https://lore.kernel.org/oe-kbuild-all/202311241752.3iLyyFcA-lkp@intel.com/ Fixes: f99f5f3ea7 ("drm/imagination: Add GPU ID parsing and firmware loading") Signed-off-by: Donald Robson <donald.robson@imgtec.com> Signed-off-by: Maxime Ripard <mripard@kernel.org> Link: https://patchwork.freedesktop.org/patch/msgid/20231130160017.259902-1-donald.robson@imgtec.com		2023-12-04 09:41:34 +01:00
..
Kconfig	drm/imagination: Implement job submission and scheduling	2023-11-23 09:01:47 +01:00
Makefile	drm/imagination: Add firmware trace to debugfs	2023-11-23 09:01:47 +01:00
pvr_ccb.c	drm/imagination: Implement free list and HWRT create and destroy ioctls	2023-11-23 09:01:46 +01:00
pvr_ccb.h	drm/imagination: Implement firmware infrastructure and META FW support	2023-11-23 09:01:46 +01:00
pvr_cccb.c	drm/imagination: Implement context creation/destruction ioctls	2023-11-23 09:01:46 +01:00
pvr_cccb.h	drm/imagination: Numerous documentation fixes.	2023-11-28 18:56:03 +01:00
pvr_context.c	drm/imagination: Implement job submission and scheduling	2023-11-23 09:01:47 +01:00
pvr_context.h	drm/imagination: Implement job submission and scheduling	2023-11-23 09:01:47 +01:00
pvr_debugfs.c	drm/imagination: Add firmware trace to debugfs	2023-11-23 09:01:47 +01:00
pvr_debugfs.h	drm/imagination: Add firmware trace to debugfs	2023-11-23 09:01:47 +01:00
pvr_device_info.c	drm/imagination: Fixed warning due to implicit cast to bool	2023-12-04 09:41:34 +01:00
pvr_device_info.h	drm/imagination: Add GPU ID parsing and firmware loading	2023-11-23 09:01:46 +01:00
pvr_device.c	drm/imagination: Fix IS_ERR() vs NULL bug in pvr_request_firmware()	2023-11-30 09:16:59 +01:00
pvr_device.h	drm/imagination: Numerous documentation fixes.	2023-11-28 18:56:03 +01:00
pvr_drv.c	drm/imagination: Add firmware trace to debugfs	2023-11-23 09:01:47 +01:00
pvr_drv.h	drm/imagination: Add GPU ID parsing and firmware loading	2023-11-23 09:01:46 +01:00
pvr_free_list.c	drm/imagination: Remove unneeded semicolon	2023-11-28 13:55:44 +01:00
pvr_free_list.h	drm/imagination: Implement free list and HWRT create and destroy ioctls	2023-11-23 09:01:46 +01:00
pvr_fw_info.h	drm/imagination: Numerous documentation fixes.	2023-11-28 18:56:03 +01:00
pvr_fw_meta.c	drm/imagination: Implement firmware infrastructure and META FW support	2023-11-23 09:01:46 +01:00
pvr_fw_meta.h	drm/imagination: Implement firmware infrastructure and META FW support	2023-11-23 09:01:46 +01:00
pvr_fw_mips.c	drm/imagination: Implement MIPS firmware processor and MMU support	2023-11-23 09:01:46 +01:00
pvr_fw_mips.h	drm/imagination: Implement MIPS firmware processor and MMU support	2023-11-23 09:01:46 +01:00
pvr_fw_startstop.c	drm/imagination: Implement firmware infrastructure and META FW support	2023-11-23 09:01:46 +01:00
pvr_fw_startstop.h	drm/imagination: Implement firmware infrastructure and META FW support	2023-11-23 09:01:46 +01:00
pvr_fw_trace.c	drm/imagination: Add firmware trace to debugfs	2023-11-23 09:01:47 +01:00
pvr_fw_trace.h	drm/imagination: Implement firmware infrastructure and META FW support	2023-11-23 09:01:46 +01:00
pvr_fw.c	drm/imagination: Implement MIPS firmware processor and MMU support	2023-11-23 09:01:46 +01:00
pvr_fw.h	drm/imagination: Numerous documentation fixes.	2023-11-28 18:56:03 +01:00
pvr_gem.c	drm/imagination: Add GEM and VM related code	2023-11-23 09:01:46 +01:00
pvr_gem.h	drm/imagination: Add GEM and VM related code	2023-11-23 09:01:46 +01:00
pvr_hwrt.c	drm/imagination: Implement free list and HWRT create and destroy ioctls	2023-11-23 09:01:46 +01:00
pvr_hwrt.h	drm/imagination: Numerous documentation fixes.	2023-11-28 18:56:03 +01:00
pvr_job.c	drm/imagination: Numerous documentation fixes.	2023-11-28 18:56:03 +01:00
pvr_job.h	drm/imagination: Implement job submission and scheduling	2023-11-23 09:01:47 +01:00
pvr_mmu.c	drm/imagination: Numerous documentation fixes.	2023-11-28 18:56:03 +01:00
pvr_mmu.h	drm/imagination: Add GEM and VM related code	2023-11-23 09:01:46 +01:00
pvr_params.c	drm/imagination: Add firmware trace to debugfs	2023-11-23 09:01:47 +01:00
pvr_params.h	drm/imagination: Add firmware trace to debugfs	2023-11-23 09:01:47 +01:00
pvr_power.c	drm/imagination: Implement job submission and scheduling	2023-11-23 09:01:47 +01:00
pvr_power.h	drm/imagination: Implement firmware infrastructure and META FW support	2023-11-23 09:01:46 +01:00
pvr_queue.c	drm/sched: Fix compilation issues with DRM priority rename	2023-11-27 09:25:41 -05:00
pvr_queue.h	drm/imagination: Numerous documentation fixes.	2023-11-28 18:56:03 +01:00
pvr_rogue_cr_defs_client.h	drm/imagination: Add GPU register headers	2023-11-23 09:01:45 +01:00
pvr_rogue_cr_defs.h	drm/imagination: Add GPU register headers	2023-11-23 09:01:45 +01:00
pvr_rogue_defs.h	drm/imagination: Add GPU register headers	2023-11-23 09:01:45 +01:00
pvr_rogue_fwif_check.h	drm/imagination: Add FWIF headers	2023-11-23 09:01:46 +01:00
pvr_rogue_fwif_client_check.h	drm/imagination: Add FWIF headers	2023-11-23 09:01:46 +01:00
pvr_rogue_fwif_client.h	drm/imagination: Add FWIF headers	2023-11-23 09:01:46 +01:00
pvr_rogue_fwif_common.h	drm/imagination: Add FWIF headers	2023-11-23 09:01:46 +01:00
pvr_rogue_fwif_dev_info.h	drm/imagination: Add FWIF headers	2023-11-23 09:01:46 +01:00
pvr_rogue_fwif_resetframework.h	drm/imagination: Add FWIF headers	2023-11-23 09:01:46 +01:00
pvr_rogue_fwif_sf.h	drm/imagination: Fix a couple of spelling mistakes in literal strings	2023-11-28 13:55:37 +01:00
pvr_rogue_fwif_shared_check.h	drm/imagination: Add FWIF headers	2023-11-23 09:01:46 +01:00
pvr_rogue_fwif_shared.h	drm/imagination: Add FWIF headers	2023-11-23 09:01:46 +01:00
pvr_rogue_fwif_stream.h	drm/imagination: Add FWIF headers	2023-11-23 09:01:46 +01:00
pvr_rogue_fwif.h	drm/imagination: Add FWIF headers	2023-11-23 09:01:46 +01:00
pvr_rogue_heap_config.h	drm/imagination: Add firmware and MMU related headers	2023-11-23 09:01:45 +01:00
pvr_rogue_meta.h	drm/imagination: Add firmware and MMU related headers	2023-11-23 09:01:45 +01:00
pvr_rogue_mips_check.h	drm/imagination: Add firmware and MMU related headers	2023-11-23 09:01:45 +01:00
pvr_rogue_mips.h	drm/imagination: Add firmware and MMU related headers	2023-11-23 09:01:45 +01:00
pvr_rogue_mmu_defs.h	drm/imagination: Add firmware and MMU related headers	2023-11-23 09:01:45 +01:00
pvr_stream_defs.c	drm/imagination: Implement job submission and scheduling	2023-11-23 09:01:47 +01:00
pvr_stream_defs.h	drm/imagination: Implement context creation/destruction ioctls	2023-11-23 09:01:46 +01:00
pvr_stream.c	drm/imagination: Implement context creation/destruction ioctls	2023-11-23 09:01:46 +01:00
pvr_stream.h	drm/imagination: Implement context creation/destruction ioctls	2023-11-23 09:01:46 +01:00
pvr_sync.c	drm/imagination: Implement job submission and scheduling	2023-11-23 09:01:47 +01:00
pvr_sync.h	drm/imagination: Implement job submission and scheduling	2023-11-23 09:01:47 +01:00
pvr_vm_mips.c	drm/imagination: fix off by one in pvr_vm_mips_init() error handling	2023-11-30 10:26:11 +01:00
pvr_vm_mips.h	drm/imagination: Implement MIPS firmware processor and MMU support	2023-11-23 09:01:46 +01:00
pvr_vm.c	drm/imagination: Numerous documentation fixes.	2023-11-28 18:56:03 +01:00
pvr_vm.h	drm/imagination: vm: check for drm_gpuvm_range_valid()	2023-11-28 13:57:43 +01:00