linux/fs/f2fs
Chao Yu 5079e1c0c8 f2fs: avoid dead loop in f2fs_issue_checkpoint()
generic/082 reports a bug as below:

__schedule+0x332/0xf60
schedule+0x6f/0xf0
schedule_timeout+0x23b/0x2a0
wait_for_completion+0x8f/0x140
f2fs_issue_checkpoint+0xfe/0x1b0
f2fs_sync_fs+0x9d/0xb0
sync_filesystem+0x87/0xb0
dquot_load_quota_sb+0x41b/0x460
dquot_load_quota_inode+0xa5/0x130
dquot_quota_on+0x4b/0x60
f2fs_quota_on+0xe3/0x1b0
do_quotactl+0x483/0x700
__x64_sys_quotactl+0x15c/0x310
do_syscall_64+0x3f/0x90
entry_SYSCALL_64_after_hwframe+0x72/0xdc

The root casue is race case as below:

Thread A			Kworker			IRQ
- write()
: write data to quota.user file

				- writepages
				 - f2fs_submit_page_write
				  - __is_cp_guaranteed return false
				  - inc_page_count(F2FS_WB_DATA)
				 - submit_bio
- quotactl(Q_QUOTAON)
 - f2fs_quota_on
  - dquot_quota_on
   - dquot_load_quota_inode
    - vfs_setup_quota_inode
    : inode->i_flags |= S_NOQUOTA
							- f2fs_write_end_io
							 - __is_cp_guaranteed return true
							 - dec_page_count(F2FS_WB_CP_DATA)
    - dquot_load_quota_sb
     - f2fs_sync_fs
      - f2fs_issue_checkpoint
       - do_checkpoint
        - f2fs_wait_on_all_pages(F2FS_WB_CP_DATA)
        : loop due to F2FS_WB_CP_DATA count is negative

Calling filemap_fdatawrite() and filemap_fdatawait() to keep all data
clean before quota file setup.

Signed-off-by: Chao Yu <chao@kernel.org>
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
2023-06-12 13:37:36 -07:00
..
acl.c fs: port i_{g,u}id_into_vfs{g,u}id() to mnt_idmap 2023-01-19 09:24:29 +01:00
acl.h fs: port ->set_acl() to pass mnt_idmap 2023-01-19 09:24:27 +01:00
checkpoint.c f2fs: support errors=remount-ro|continue|panic mountoption 2023-05-08 11:18:04 -07:00
compress.c f2fs: flush error flags in workqueue 2023-06-12 13:04:08 -07:00
data.c f2fs: fix potential deadlock due to unpaired node_write lock use 2023-06-12 13:04:07 -07:00
debug.c f2fs: fix to recover quota data correctly 2023-04-12 20:00:36 -07:00
dir.c f2fs: remove folio_detach_private() in .invalidate_folio and .release_folio 2023-04-17 14:49:40 -07:00
extent_cache.c f2fs: remove unnessary comment in __may_age_extent_tree 2023-04-24 11:03:10 -07:00
f2fs.h f2fs: add async reset zone command support 2023-06-12 13:04:09 -07:00
file.c f2fs: flag as supporting buffered async reads 2023-06-12 13:04:09 -07:00
gc.c f2fs: fix to avoid NULL pointer dereference f2fs_write_end_io() 2023-06-12 13:04:08 -07:00
gc.h f2fs: Fix system crash due to lack of free space in LFS 2023-04-10 10:58:45 -07:00
hash.c f2fs: don't use casefolded comparison for "." and ".." 2022-05-17 11:19:23 -07:00
inline.c f2fs: use common implementation of file type 2023-04-10 10:58:45 -07:00
inode.c f2fs: remove unneeded in-memory i_crtime copy 2023-04-10 11:00:58 -07:00
iostat.c f2fs: add async reset zone command support 2023-06-12 13:04:09 -07:00
iostat.h f2fs: use iostat_lat_type directly as a parameter in the iostat_update_and_unbind_ctx() 2023-02-07 10:39:28 -08:00
Kconfig f2fs: introduce F2FS_UNFAIR_RWSEM to support unfair rwsem 2022-03-04 09:15:53 -08:00
Makefile f2fs: separate out iostat feature 2021-08-23 10:25:51 -07:00
namei.c f2fs: fix args passed to trace_f2fs_lookup_end 2023-06-12 13:04:09 -07:00
node.c f2fs: remove some dead code 2023-05-08 11:18:04 -07:00
node.h f2fs: convert to use bitmap API 2023-03-29 15:17:37 -07:00
recovery.c f2fs: Detect looped node chain efficiently 2023-06-12 13:04:09 -07:00
segment.c f2fs: add async reset zone command support 2023-06-12 13:04:09 -07:00
segment.h f2fs: add has_enough_free_secs() 2023-04-18 09:05:54 -07:00
shrinker.c f2fs: add block_age-based extent cache 2022-12-12 14:53:56 -08:00
super.c f2fs: avoid dead loop in f2fs_issue_checkpoint() 2023-06-12 13:37:36 -07:00
sysfs.c f2fs: add sanity check for proc_mkdir 2023-05-08 11:18:04 -07:00
verity.c f2fs-for-6.3-rc1 2023-02-27 16:18:51 -08:00
xattr.c fs: rename generic posix acl handlers 2023-03-06 09:57:13 +01:00
xattr.h f2fs: code cleanup by removing ifdef macro surrounding 2020-05-26 18:56:10 -07:00