Michael Grzeschik 4fefe9f6de usb composite: fix locking in usb_function_activate ... The lockdep hunter mentions a non consistent usage of spin_lock and spin_lock_irqsafe in the composite_disconnect and usb_function_activate function: [ 15.700897] ================================= [ 15.705255] [ INFO: inconsistent lock state ] [ 15.709617] 3.5.0-rc5+ #413 Not tainted [ 15.713453] --------------------------------- [ 15.717812] inconsistent {HARDIRQ-ON-W} -> {IN-HARDIRQ-W} usage. [ 15.723822] uvc-gadget/116 [HC1[1]:SC0[0]:HE0:SE1] takes: [ 15.729222] (&(&cdev->lock)->rlock){?.+...}, at: [<7f0049e8>] composite_disconnect+0x2c/0x74 [g_webcam] [ 15.738797] {HARDIRQ-ON-W} state was registered at: [ 15.743677] [<8006de3c>] mark_lock+0x148/0x688 [ 15.748325] [<8006ecb0>] __lock_acquire+0x934/0x1b74 [ 15.753481] [<8007047c>] lock_acquire+0x98/0x138 [ 15.758288] [<804c776c>] _raw_spin_lock+0x4c/0x84 [ 15.763188] [<7f006ae4>] usb_function_activate+0x28/0x94 [g_webcam] [ 15.769652] [<7f00820c>] usb_ep_autoconfig_reset+0x78/0x98 [g_webcam] [ 15.776287] [<7f0082a4>] uvc_v4l2_open+0x78/0x94 [g_webcam] [ 15.782054] [<80366a38>] v4l2_open+0x104/0x130 [ 15.786697] [<800efd30>] chrdev_open+0xa0/0x170 [ 15.791423] [<800e9718>] do_dentry_open.isra.13+0x1e8/0x264 [ 15.797186] [<800ea5d4>] nameidata_to_filp+0x58/0x94 [ 15.802340] [<800fa29c>] do_last.isra.31+0x2a0/0x808 [ 15.807497] [<800faa40>] path_openat+0xc8/0x3e8 [ 15.812216] [<800fae90>] do_filp_open+0x3c/0x90 [ 15.816936] [<800ea6fc>] do_sys_open+0xec/0x184 [ 15.821655] [<800ea7c4>] sys_open+0x30/0x34 [ 15.826027] [<8000e5c0>] ret_fast_syscall+0x0/0x48 [ 15.831015] irq event stamp: 6048 [ 15.834330] hardirqs last enabled at (6047): [<804c81b8>] _raw_spin_unlock_irqrestore+0x40/0x54 [ 15.843132] hardirqs last disabled at (6048): [<8000e174>] __irq_svc+0x34/0x60 [ 15.850370] softirqs last enabled at (5940): [<80028380>] __do_softirq+0x188/0x270 [ 15.858043] softirqs last disabled at (5935): [<80028944>] irq_exit+0xa0/0xa8 [ 15.865195] [ 15.865195] other info that might help us debug this: [ 15.871724] Possible unsafe locking scenario: [ 15.871724] [ 15.877645] CPU0 [ 15.880091] ---- [ 15.882537] lock(&(&cdev->lock)->rlock); [ 15.886659] <Interrupt> [ 15.889278] lock(&(&cdev->lock)->rlock); [ 15.893573] [ 15.893573] *** DEADLOCK *** [ 15.893573] [ 15.899496] no locks held by uvc-gadget/116. [ 15.903765] [ 15.903765] stack backtrace: [ 15.908125] Backtrace: [ 15.910604] [<80012038>] (dump_backtrace+0x0/0x114) from [<804bf8a4>] (dump_stack+0x20/0x24) [ 15.919043] r6:dfb8e6f0 r5:dfb8e400 r4:809717ec r3:60000193 [ 15.924766] [<804bf884>] (dump_stack+0x0/0x24) from [<804c0c0c>] (print_usage_bug+0x258/0x2c0) [ 15.933388] [<804c09b4>] (print_usage_bug+0x0/0x2c0) from [<8006e240>] (mark_lock+0x54c/0x688) [ 15.942006] [<8006dcf4>] (mark_lock+0x0/0x688) from [<8006edb8>] (__lock_acquire+0xa3c/0x1b74) [ 15.950625] [<8006e37c>] (__lock_acquire+0x0/0x1b74) from [<8007047c>] (lock_acquire+0x98/0x138) [ 15.959418] [<800703e4>] (lock_acquire+0x0/0x138) from [<804c78fc>] (_raw_spin_lock_irqsave+0x58/0x94) [ 15.968736] [<804c78a4>] (_raw_spin_lock_irqsave+0x0/0x94) from [<7f0049e8>] (composite_disconnect+0x2c/0x74 [g_webcam]) [ 15.979605] r7:00000012 r6:df82b0c4 r5:ded755bc r4:ded75580 [ 15.985331] [<7f0049bc>] (composite_disconnect+0x0/0x74 [g_webcam]) from [<8033c170>] (_gadget_stop_activity+0xc4/0x120) [ 15.996200] r6:df82b0c4 r5:df82b0c8 r4:df82b0d0 r3:7f0049bc [ 16.001919] [<8033c0ac>] (_gadget_stop_activity+0x0/0x120) from [<8033e390>] (udc_irq+0x724/0xcb8) [ 16.010877] r6:df82b010 r5:00000000 r4:df82b010 r3:00000000 [ 16.016595] [<8033dc6c>] (udc_irq+0x0/0xcb8) from [<8033baec>] (ci_irq+0x64/0xdc) [ 16.024086] [<8033ba88>] (ci_irq+0x0/0xdc) from [<80086538>] (handle_irq_event_percpu+0x74/0x298) [ 16.032958] r5:807fd414 r4:df38fdc0 [ 16.036566] [<800864c4>] (handle_irq_event_percpu+0x0/0x298) from [<800867a8>] (handle_irq_event+0x4c/0x6c) [ 16.046315] [<8008675c>] (handle_irq_event+0x0/0x6c) from [<80089318>] (handle_level_irq+0xbc/0x11c) [ 16.055447] r6:def04000 r5:807fd414 r4:807fd3c0 r3:00020000 [ 16.061166] [<8008925c>] (handle_level_irq+0x0/0x11c) from [<80085cc8>] (generic_handle_irq+0x38/0x4c) [ 16.070472] r5:807f7f64 r4:8081e9f8 [ 16.074082] [<80085c90>] (generic_handle_irq+0x0/0x4c) from [<8000ef98>] (handle_IRQ+0x5c/0xbc) [ 16.082788] [<8000ef3c>] (handle_IRQ+0x0/0xbc) from [<800085cc>] (tzic_handle_irq+0x6c/0x9c) [ 16.091225] r8:00000000 r7:def059b0 r6:00000001 r5:00000000 r4:00000000 r3:00000012 [ 16.099141] [<80008560>] (tzic_handle_irq+0x0/0x9c) from [<8000e184>] (__irq_svc+0x44/0x60) [ 16.107494] Exception stack(0xdef059b0 to 0xdef059f8) [ 16.112550] 59a0: 00000001 00000001 00000000 dfb8e400 [ 16.120732] 59c0: 40000013 81a2e500 00000000 81a2e500 00000000 00000000 80862418 def05a0c [ 16.128912] 59e0: def059c8 def059f8 80070e24 804c81bc 20000013 ffffffff [ 16.135542] [<804c8178>] (_raw_spin_unlock_irqrestore+0x0/0x54) from [<8003d0ec>] (__queue_work+0x108/0x470) [ 16.145369] r5:dfb1a30c r4:81b93c00 [ 16.148978] [<8003cfe4>] (__queue_work+0x0/0x470) from [<8003d4e0>] (queue_work_on+0x4c/0x54) [ 16.157511] [<8003d494>] (queue_work_on+0x0/0x54) from [<8003d544>] (queue_work+0x30/0x34) [ 16.165774] r6:df2e6900 r5:80e0c2f8 r4:dfb1a2c8 r3:def04000 [ 16.171495] [<8003d514>] (queue_work+0x0/0x34) from [<80493284>] (rpc_make_runnable+0x9c/0xac) [ 16.180113] [<804931e8>] (rpc_make_runnable+0x0/0xac) from [<80493c88>] (rpc_execute+0x40/0xa8) [ 16.188811] r5:def05ad4 r4:dfb1a2c8 [ 16.192426] [<80493c48>] (rpc_execute+0x0/0xa8) from [<8048c734>] (rpc_run_task+0xa8/0xb4) [ 16.200690] r8:00000001 r7:df74f520 r6:ded75700 r5:def05ad4 r4:dfb1a2c8 r3:00000002 [ 16.208618] [<8048c68c>] (rpc_run_task+0x0/0xb4) from [<801f1608>] (nfs_initiate_read+0xb4/0xd4) [ 16.217403] r5:df3e86c0 r4:00000000 [ 16.221015] [<801f1554>] (nfs_initiate_read+0x0/0xd4) from [<801f1c64>] (nfs_generic_pg_readpages+0x9c/0x114) [ 16.230937] [<801f1bc8>] (nfs_generic_pg_readpages+0x0/0x114) from [<801f0744>] (__nfs_pageio_add_request+0xe8/0x214) [ 16.241545] r8:000bf000 r7:00000000 r6:00000000 r5:deef4640 r4:def05c1c r3:801f1bc8 [ 16.249463] [<801f065c>] (__nfs_pageio_add_request+0x0/0x214) from [<801f0e3c>] (nfs_pageio_add_request+0x28/0x54) [ 16.259818] [<801f0e14>] (nfs_pageio_add_request+0x0/0x54) from [<801f1394>] (readpage_async_filler+0x114/0x170) [ 16.269992] r5:def05c58 r4:80fd7300 [ 16.273607] [<801f1280>] (readpage_async_filler+0x0/0x170) from [<800bb418>] (read_cache_pages+0xa0/0x108) [ 16.283259] r8:00200200 r7:00100100 r6:df74f654 r5:def05cd0 r4:80fd7300 [ 16.290034] [<800bb378>] (read_cache_pages+0x0/0x108) from [<801f218c>] (nfs_readpages+0xc4/0x168) [ 16.298999] [<801f20c8>] (nfs_readpages+0x0/0x168) from [<800bb1d0>] (__do_page_cache_readahead+0x254/0x354) [ 16.308833] [<800baf7c>] (__do_page_cache_readahead+0x0/0x354) from [<800bb5d0>] (ra_submit+0x38/0x40) [ 16.318145] [<800bb598>] (ra_submit+0x0/0x40) from [<800bb6b0>] (ondemand_readahead+0xd8/0x3b0) [ 16.326851] [<800bb5d8>] (ondemand_readahead+0x0/0x3b0) from [<800bba20>] (page_cache_async_readahead+0x98/0xa8) [ 16.337043] [<800bb988>] (page_cache_async_readahead+0x0/0xa8) from [<800b2118>] (generic_file_aio_read+0x5b4/0x7c4) [ 16.347565] r6:00000000 r5:df74f654 r4:80fd70a0 [ 16.352231] [<800b1b64>] (generic_file_aio_read+0x0/0x7c4) from [<801e82c0>] (nfs_file_read+0x7c/0xcc) [ 16.361544] [<801e8244>] (nfs_file_read+0x0/0xcc) from [<800eab80>] (do_sync_read+0xb4/0xf4) [ 16.369981] r9:00000000 r8:def05f70 r7:00000000 r6:00000000 r5:dec34900 r4:fffffdee [ 16.377896] [<800eaacc>] (do_sync_read+0x0/0xf4) from [<800eb548>] (vfs_read+0xb4/0x144) [ 16.385987] r8:00000000 r7:def05f70 r6:76a95008 r5:003e3dd6 r4:dec34900 [ 16.392761] [<800eb494>] (vfs_read+0x0/0x144) from [<800eb624>] (sys_read+0x4c/0x78) [ 16.400504] r8:00000000 r7:00000003 r6:003e3dd6 r5:76a95008 r4:dec34900 [ 16.407279] [<800eb5d8>] (sys_read+0x0/0x78) from [<8000e5c0>] (ret_fast_syscall+0x0/0x48) [ 16.415543] r9:def04000 r8:8000e864 r6:000086b4 r5:00000000 r4:00000000 [ 20.872729] gadget: high-speed config #1: Video [ 20.877368] gadget: uvc_function_set_alt(0, 0) [ 20.881908] gadget: uvc_function_set_alt(1, 0) [ 20.891464] gadget: uvc_function_set_alt(1, 0) Signed-off-by: Michael Grzeschik <m.grzeschik@pengutronix.de> Signed-off-by: Felipe Balbi <balbi@ti.com>		2012-08-23 11:04:17 +03:00
..
acm_ms.c	usb: gadget: acm_ms: need to set max_speed	2012-06-22 13:10:10 +03:00
amd5536udc.c	usb: gadget: Update amd5536udc to use usb_endpoint_descriptor inside the struct usb_ep	2012-05-04 15:52:52 +03:00
amd5536udc.h	usb: gadget: Update amd5536udc to use usb_endpoint_descriptor inside the struct usb_ep	2012-05-04 15:52:52 +03:00
at91_udc.c	usb: gadget: at91_udc: Propagate devicetree to gadget drivers	2012-07-02 10:38:07 +03:00
at91_udc.h	usb: gadget: Update at91_udc to use usb_endpoint_descriptor inside the struct usb_ep	2012-05-04 15:52:53 +03:00
atmel_usba_udc.c	usb: gadget: atmel_usba_udc: Remove unneeded condition	2012-06-04 18:15:44 +03:00
atmel_usba_udc.h	usb: gadget: Update atmel_usba_udc to use usb_endpoint_descriptor inside the struct usb_ep	2012-05-04 15:52:53 +03:00
audio.c	usb: gadget: Add Audio Class 2.0 Driver	2012-02-15 10:10:31 +02:00
cdc2.c	usb: Add module.h to drivers/usb consumers who really use it.	2011-10-31 19:31:25 -04:00
composite.c	usb composite: fix locking in usb_function_activate	2012-08-23 11:04:17 +03:00
config.c
dbgp.c	usb: gadget: rename usb_gadget_driver::speed to max_speed	2011-12-12 11:45:12 +02:00
dummy_hcd.c	usb: gadget: dummy_hcd: fix build when BUG is not set	2012-05-11 15:17:31 -07:00
epautoconf.c	This merge is rather big. Here's what it contains:	2012-03-01 09:20:28 -08:00
ether.c	module_param: make bool parameters really bool (drivers & misc)	2012-01-13 09:32:20 +10:30
f_acm.c	usb: gadget: add usb3.0 descriptors to serial gadgets	2012-02-09 10:11:36 +02:00
f_ecm.c	usb: gadget: Add Interface Association Descriptor to ECM	2012-01-30 11:17:26 +02:00
f_eem.c
f_fs.c	usb: gadget: ffs: add HID descriptor support.	2012-06-04 18:11:59 +03:00
f_hid.c	usb: gadget: hidg: register OUT INT endpoint for SET_REPORT	2012-06-15 14:34:53 +03:00
f_loopback.c	usb: gadget: add isochronous support to gadget zero	2012-05-04 15:53:08 +03:00
f_mass_storage.c	usb: gadget: mass_storage: make "file" and "ro" read only in some cases	2012-07-02 10:36:55 +03:00
f_midi.c	Allocate correct size (portably) in drivers/usb/gadget/f_midi.c::f_midi_bind()	2012-03-02 16:22:11 -08:00
f_ncm.c
f_obex.c	usb: Add module.h to drivers/usb consumers who really use it.	2011-10-31 19:31:25 -04:00
f_phonet.c	netvm: propagate page->pfmemalloc from skb_alloc_page to skb	2012-07-31 18:42:46 -07:00
f_rndis.c	USB 3.5-rc1 pull request	2012-05-22 15:50:46 -07:00
f_serial.c	usb: gadget: add usb3.0 descriptors to serial gadgets	2012-02-09 10:11:36 +02:00
f_sourcesink.c	usb: gadget: add isochronous support to gadget zero	2012-05-04 15:53:08 +03:00
f_subset.c	usb gadget: fix a section mismatch when compiling g_ffs with CONFIG_USB_FUNCTIONFS_ETH	2012-03-13 14:29:33 -07:00
f_uac1.c	usb: gadget: audio: Move string IDs to audio.c	2012-02-15 10:10:25 +02:00
f_uac2.c	usb: gadget: Add Audio Class 2.0 Driver	2012-02-15 10:10:31 +02:00
f_uvc.c	usb: gadget: uvc: Add super-speed support to UVC webcam gadget	2012-06-04 18:12:36 +03:00
f_uvc.h	usb: gadget: uvc: Add super-speed support to UVC webcam gadget	2012-06-04 18:12:36 +03:00
file_storage.c	USB: gadget: storage gadgets send wrong error code for unknown commands	2012-04-12 16:20:10 +03:00
fsl_mxc_udc.c	usb: gadget: fsl_mxc_udc: do not depend on grouped clocks	2012-06-22 13:09:52 +03:00
fsl_qe_udc.c	usb: gadget: fsl_qe_udc: Remove unneeded condition	2012-06-04 18:15:45 +03:00
fsl_qe_udc.h	usb: gadget: Complete fsl qe/udc driver conversion	2012-06-12 13:32:29 +03:00
fsl_udc_core.c	usb: phy: patches for v3.6 merge window	2012-07-05 15:35:41 -07:00
fsl_usb2_udc.h	usb: gadget: regression fix - usage of usb_ep	2012-06-04 18:24:49 +03:00
fusb300_udc.c	usb: gadget: Update fusb300_udc to use usb_endpoint_descriptor inside the struct usb_ep	2012-05-04 15:52:55 +03:00
fusb300_udc.h	usb: gadget: Update fusb300_udc to use usb_endpoint_descriptor inside the struct usb_ep	2012-05-04 15:52:55 +03:00
g_ffs.c	FunctionFS: enable multiple functions	2012-05-14 09:25:44 -07:00
g_zero.h	usb: gadget: add isochronous support to gadget zero	2012-05-04 15:53:08 +03:00
gadget_chips.h	USB: gadget driver for LPC32xx	2012-05-01 13:34:55 -04:00
gmidi.c	usb: Add module.h to drivers/usb consumers who really use it.	2011-10-31 19:31:25 -04:00
goku_udc.c	goku_udc: remove IRQF_SAMPLE_RANDOM which was commented out	2012-07-19 10:39:54 -04:00
goku_udc.h	usb: gadget: Update goku_udc to use usb_endpoint_descriptor inside the struct usb_ep	2012-05-04 15:52:55 +03:00
hid.c	USB: gadget: Make g_hid device class conform to spec.	2012-03-08 13:11:34 -08:00
imx_udc.c	usb: imx_udc.c: Use clk_prepare_enable/clk_disable_unprepare	2012-06-12 13:30:59 +03:00
imx_udc.h
inode.c	USB: remove compile warning on gadget/inode.c	2012-04-06 13:54:01 -07:00
Kconfig	USB patches for 3.6-rc1	2012-07-26 10:23:47 -07:00
lpc32xx_udc.c	usb: gadget: patches for v3.6 merge window	2012-07-05 15:10:09 -07:00
m66592-udc.c	gadget/m66592: remove conditional compilation of clk code	2012-07-30 17:25:12 -07:00
m66592-udc.h	gadget/m66592: remove conditional compilation of clk code	2012-07-30 17:25:12 -07:00
Makefile	usb: gadget: mv: Add USB 3.0 device driver for Marvell PXA2128 chip.	2012-06-22 13:08:21 +03:00
mass_storage.c	usb: gadget: update Michal Nazarewicz's email address	2012-01-24 11:45:11 +02:00
multi.c	usb: gadget: update Michal Nazarewicz's email address	2012-01-24 11:45:11 +02:00
mv_u3d_core.c	usb: gadget: mv: Add USB 3.0 device driver for Marvell PXA2128 chip.	2012-06-22 13:08:21 +03:00
mv_u3d.h	usb: gadget: mv: Add USB 3.0 device driver for Marvell PXA2128 chip.	2012-06-22 13:08:21 +03:00
mv_udc_core.c	usb: gadget: mv_udc: fix boot up hang	2012-08-23 11:04:17 +03:00
mv_udc.h	usb: gadget: Update mv_udc to use usb_endpoint_descriptor inside the struct usb_ep	2012-05-04 15:52:57 +03:00
ncm.c
ndis.h	usb/net: rndis: break out <linux/rndis.h> defines	2012-05-12 15:02:22 -04:00
net2272.c	Remove all #inclusions of asm/system.h	2012-03-28 18:30:03 +01:00
net2272.h
net2280.c	Remove all #inclusions of asm/system.h	2012-03-28 18:30:03 +01:00
net2280.h
nokia.c
omap_udc.c	USB patches for 3.6-rc1	2012-07-26 10:23:47 -07:00
omap_udc.h	usb: gadget: Update omap_udc to use usb_endpoint_descriptor inside the struct usb_ep	2012-05-04 15:52:57 +03:00
pch_udc.c	usb: gadget: pch_udc: Fix likely misuse of | for &	2012-06-04 18:12:06 +03:00
printer.c	usb: gadget: make g_printer use composite	2012-05-04 15:53:04 +03:00
pxa25x_udc.c	This patch series contains a major revamp of how we collect entropy	2012-07-31 19:07:42 -07:00
pxa25x_udc.h	usb: gadget: Update pxa25x_udc to use usb_endpoint_descriptor inside the struct usb_ep	2012-05-04 15:52:58 +03:00
pxa27x_udc.c	usb: phy: fix return value check of usb_get_phy	2012-07-02 10:40:49 +03:00
pxa27x_udc.h	usb: otg: Rename otg_transceiver to usb_phy	2012-02-13 13:34:36 +02:00
r8a66597-udc.c	gadget/r8a66597: remove conditional compilation of clk code	2012-07-30 17:25:12 -07:00
r8a66597-udc.h	gadget/r8a66597: remove conditional compilation of clk code	2012-07-30 17:25:12 -07:00
rndis.c	usb/net: rndis: fixup a few name prefixes	2012-05-12 15:13:39 -04:00
rndis.h	usb/net: rndis: break out <linux/rndis.h> defines	2012-05-12 15:02:22 -04:00
s3c2410_udc.c	usb: gadget: s3c2410_udc: Remove unneeded condition	2012-06-04 18:15:48 +03:00
s3c2410_udc.h	usb: gadget: Update s3c2410_udc to use usb_endpoint_descriptor inside the struct usb_ep	2012-05-04 15:52:59 +03:00
s3c-hsotg.c	usb: gadget: s3c-hsotg: Propagate devicetree to gadget drivers	2012-07-02 10:38:01 +03:00
s3c-hsotg.h	usb:hsotg:samsung: Remove the S3C_ prefix from registers definition.	2012-05-04 15:53:17 +03:00
s3c-hsudc.c	usb: phy: patches for v3.6 merge window	2012-07-05 15:35:41 -07:00
serial.c	usb: gadget: add usb3.0 descriptors to serial gadgets	2012-02-09 10:11:36 +02:00
storage_common.c	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2012-08-01 10:26:23 -07:00
tcm_usb_gadget.c	target: Allow for target_submit_cmd() returning errors	2012-07-17 17:05:05 -07:00
tcm_usb_gadget.h	usb-gadget: Initial merge of target module for UASP + BOT	2012-05-09 15:25:59 -07:00
u_ether.c	USB patches for 3.6-rc1	2012-07-26 10:23:47 -07:00
u_ether.h	usb: gadget: f_rndis: Set rndis vendor parameters	2012-05-10 12:27:58 -07:00
u_phonet.h
u_serial.c	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jikos/trivial	2012-05-22 19:22:50 -07:00
u_serial.h
u_uac1.c	gadgetfs: clean up	2012-07-29 21:24:21 +04:00
u_uac1.h	usb: gadget: Rename audio function to uac1	2012-02-15 10:09:48 +02:00
udc-core.c	usb: gadget: udc-core: fix incompatibility with dummy-hcd	2012-04-27 11:06:15 +03:00
usbstring.c	USB: remove homegrown UTF conversion routine for gadgets	2011-11-18 10:51:01 -08:00
uvc_queue.c	[media] usb: gadget/uvc: Remove non-required locking from 'uvc_queue_next_buffer' routine	2012-04-10 15:46:02 -03:00
uvc_queue.h
uvc_v4l2.c	Merge remote-tracking branch 'linus/master' into staging/for_v3.5	2012-05-15 08:39:25 -03:00
uvc_video.c
uvc.h	usb: gadget: uvc: Add super-speed support to UVC webcam gadget	2012-06-04 18:12:36 +03:00
webcam.c	usb: gadget: uvc: Add super-speed support to UVC webcam gadget	2012-06-04 18:12:36 +03:00
zero.c	usb: gadget: add isochronous support to gadget zero	2012-05-04 15:53:08 +03:00