linux/drivers/net/ethernet/intel
Andi Kleen 58e4e1f6ca igb: Avoid uninitialized advertised variable in eee_set_cur
eee_get_cur assumes that the output data is already zeroed. It can
read-modify-write the advertised field:

              if (ipcnfg & E1000_IPCNFG_EEE_100M_AN)
2594			edata->advertised |= ADVERTISED_100baseT_Full;

This is ok for the normal ethtool eee_get call, which always
zeroes the input data before.

But eee_set_cur also calls eee_get_cur and it did not zero the input
field. Later on it then compares agsinst the field, which can contain partial
stack garbage.

Zero the input field in eee_set_cur() too.

Cc: jeffrey.t.kirsher@intel.com
Cc: netdev@vger.kernel.org
Signed-off-by: Andi Kleen <ak@linux.intel.com>
Acked-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2013-10-02 16:31:48 -04:00
..
e1000 drivers:net: Convert dma_alloc_coherent(...__GFP_ZERO) to dma_zalloc_coherent 2013-08-29 21:55:23 -04:00
e1000e e1000e: fix overrun of PHY RAR array 2013-09-13 10:19:56 -07:00
i40e i40e: clean up coccicheck reported errors 2013-09-27 05:24:05 -07:00
igb igb: Avoid uninitialized advertised variable in eee_set_cur 2013-10-02 16:31:48 -04:00
igbvf net: vlan: add protocol argument to packet tagging functions 2013-04-19 14:46:06 -04:00
ixgb drivers:net: Convert dma_alloc_coherent(...__GFP_ZERO) to dma_zalloc_coherent 2013-08-29 21:55:23 -04:00
ixgbe ixgbe: fix ethtool reporting of supported links for SFP modules 2013-09-13 09:58:12 -07:00
ixgbevf drivers/net: Convert uses of compare_ether_addr to ether_addr_equal 2013-09-03 22:28:04 -04:00
e100.c e100: dump small buffers via %*ph 2013-07-28 02:06:38 -07:00
Kconfig i40e: include i40e in kernel proper 2013-09-11 02:28:40 -07:00
Makefile i40e: include i40e in kernel proper 2013-09-11 02:28:40 -07:00