Tyler Hicks 465aee77aa ima: Free the entire rule when deleting a list of rules ... Create a function, ima_free_rule(), to free all memory associated with an ima_rule_entry. Use the new function to fix memory leaks of allocated ima_rule_entry members, such as .fsname and .keyrings, when deleting a list of rules. Make the existing ima_lsm_free_rule() function specific to the LSM audit rule array of an ima_rule_entry and require that callers make an additional call to kfree to free the ima_rule_entry itself. This fixes a memory leak seen when loading by a valid rule that contains an additional piece of allocated memory, such as an fsname, followed by an invalid rule that triggers a policy load failure: # echo -e "dont_measure fsname=securityfs\nbad syntax" > \ /sys/kernel/security/ima/policy -bash: echo: write error: Invalid argument # echo scan > /sys/kernel/debug/kmemleak # cat /sys/kernel/debug/kmemleak unreferenced object 0xffff9bab67ca12c0 (size 16): comm "bash", pid 684, jiffies 4295212803 (age 252.344s) hex dump (first 16 bytes): 73 65 63 75 72 69 74 79 66 73 00 6b 6b 6b 6b a5 securityfs.kkkk. backtrace: [<00000000adc80b1b>] kstrdup+0x2e/0x60 [<00000000d504cb0d>] ima_parse_add_rule+0x7d4/0x1020 [<00000000444825ac>] ima_write_policy+0xab/0x1d0 [<000000002b7f0d6c>] vfs_write+0xde/0x1d0 [<0000000096feedcf>] ksys_write+0x68/0xe0 [<0000000052b544a2>] do_syscall_64+0x56/0xa0 [<000000007ead1ba7>] entry_SYSCALL_64_after_hwframe+0x44/0xa9 Fixes: f1b08bbcbd ("ima: define a new policy condition based on the filesystem name") Fixes: 2b60c0eced ("IMA: Read keyrings= option from the IMA policy") Signed-off-by: Tyler Hicks <tyhicks@linux.microsoft.com> Signed-off-by: Mimi Zohar <zohar@linux.ibm.com>		2020-07-16 21:53:55 -04:00
..
apparmor	linux-kselftest-kunit-5.8-rc1	2020-06-09 10:04:47 -07:00
bpf	bpf: lsm: Initialize the BPF LSM hooks	2020-03-30 01:34:00 +02:00
integrity	ima: Free the entire rule when deleting a list of rules	2020-07-16 21:53:55 -04:00
keys	Notifications over pipes + Keyring notifications	2020-06-13 09:56:21 -07:00
loadpin	proc/sysctl: add shared variables for range check	2019-07-18 17:08:07 -07:00
lockdown	Merge branch 'next-general' of git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/linux-security	2020-06-02 17:36:24 -07:00
safesetid	security/safesetid: Replace rcu_swap_protected() with rcu_replace_pointer()	2019-10-30 08:45:57 -07:00
selinux	selinux/stable-5.8 PR 20200621	2020-06-21 15:41:24 -07:00
smack	Notifications over pipes + Keyring notifications	2020-06-13 09:56:21 -07:00
tomoyo	treewide: replace '---help---' in Kconfig files with 'help'	2020-06-14 01:57:21 +09:00
yama	sysctl: pass kernel pointers to ->proc_handler	2020-04-27 02:07:40 -04:00
commoncap.c	exec: Compute file based creds only once	2020-05-29 22:00:54 -05:00
device_cgroup.c	device_cgroup: Cleanup cgroup eBPF device filter code	2020-04-13 14:41:54 -04:00
inode.c	Merge branch 'work.mount0' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2019-07-19 10:42:02 -07:00
Kconfig	bpf: lsm: Initialize the BPF LSM hooks	2020-03-30 01:34:00 +02:00
Kconfig.hardening	meminit fix	2019-07-28 12:33:15 -07:00
lsm_audit.c	security,lockdown,selinux: implement SELinux lockdown	2019-12-09 17:53:58 -05:00
Makefile	device_cgroup: Cleanup cgroup eBPF device filter code	2020-04-13 14:41:54 -04:00
min_addr.c	sysctl: pass kernel pointers to ->proc_handler	2020-04-27 02:07:40 -04:00
security.c	Add additional LSM hooks for SafeSetID	2020-06-14 11:39:31 -07:00