Gao Feng c1a4872ebf net: sched: Fix one possible panic when no destroy callback ... When qdisc fail to init, qdisc_create would invoke the destroy callback to cleanup. But there is no check if the callback exists really. So it would cause the panic if there is no real destroy callback like the qdisc codel, fq, and so on. Take codel as an example following: When a malicious user constructs one invalid netlink msg, it would cause codel_init->codel_change->nla_parse_nested failed. Then kernel would invoke the destroy callback directly but qdisc codel doesn't define one. It causes one panic as a result. Now add one the check for destroy to avoid the possible panic. Fixes: 87b60cfacf ("net_sched: fix error recovery at qdisc creation") Signed-off-by: Gao Feng <gfree.wind@vip.163.com> Acked-by: Eric Dumazet <edumazet@google.com> Signed-off-by: David S. Miller <davem@davemloft.net>		2017-06-29 12:55:12 -04:00
..
act_api.c	net: sched: add helpers to handle extended actions	2017-05-02 15:33:54 -04:00
act_bpf.c	netlink: pass extended ACK struct to parsing functions	2017-04-13 13:58:22 -04:00
act_connmark.c	netlink: pass extended ACK struct to parsing functions	2017-04-13 13:58:22 -04:00
act_csum.c	netlink: pass extended ACK struct to parsing functions	2017-04-13 13:58:22 -04:00
act_gact.c	netlink: pass extended ACK struct to parsing functions	2017-04-13 13:58:22 -04:00
act_ife.c	netlink: pass extended ACK struct to parsing functions	2017-04-13 13:58:22 -04:00
act_ipt.c	netlink: pass extended ACK struct to parsing functions	2017-04-13 13:58:22 -04:00
act_meta_mark.c	Support to encoding decoding skb mark on IFE action	2016-03-01 17:15:23 -05:00
act_meta_skbprio.c	Support to encoding decoding skb prio on IFE action	2016-03-01 17:15:23 -05:00
act_meta_skbtcindex.c	net sched ife action: Introduce skb tcindex metadata encap decap	2016-09-19 21:55:28 -04:00
act_mirred.c	netlink: pass extended ACK struct to parsing functions	2017-04-13 13:58:22 -04:00
act_nat.c	netlink: pass extended ACK struct to parsing functions	2017-04-13 13:58:22 -04:00
act_pedit.c	net/act_pedit: fix an error code	2017-06-14 15:24:18 -04:00
act_police.c	net_sched: move tcf_lock down after gen_replace_estimator()	2017-06-14 14:39:19 -04:00
act_sample.c	netlink: pass extended ACK struct to parsing functions	2017-04-13 13:58:22 -04:00
act_simple.c	netlink: pass extended ACK struct to parsing functions	2017-04-13 13:58:22 -04:00
act_skbedit.c	netlink: pass extended ACK struct to parsing functions	2017-04-13 13:58:22 -04:00
act_skbmod.c	netlink: pass extended ACK struct to parsing functions	2017-04-13 13:58:22 -04:00
act_tunnel_key.c	netlink: pass extended ACK struct to parsing functions	2017-04-13 13:58:22 -04:00
act_vlan.c	netlink: pass extended ACK struct to parsing functions	2017-04-13 13:58:22 -04:00
cls_api.c	net_sched: move the empty tp check from ->destroy() to ->delete()	2017-04-21 13:58:15 -04:00
cls_basic.c	net_sched: move the empty tp check from ->destroy() to ->delete()	2017-04-21 13:58:15 -04:00
cls_bpf.c	net_sched: move the empty tp check from ->destroy() to ->delete()	2017-04-21 13:58:15 -04:00
cls_cgroup.c	net_sched: move the empty tp check from ->destroy() to ->delete()	2017-04-21 13:58:15 -04:00
cls_flow.c	net_sched: move the empty tp check from ->destroy() to ->delete()	2017-04-21 13:58:15 -04:00
cls_flower.c	flower: check unused bits in MPLS fields	2017-05-01 11:12:21 -04:00
cls_fw.c	net_sched: remove useless NULL to tp->root	2017-04-21 13:58:15 -04:00
cls_matchall.c	net: sched: cls_matchall: fix null pointer dereference	2017-05-22 14:54:16 -04:00
cls_route.c	net_sched: remove useless NULL to tp->root	2017-04-21 13:58:15 -04:00
cls_rsvp6.c
cls_rsvp.c
cls_rsvp.h	net_sched: remove useless NULL to tp->root	2017-04-21 13:58:15 -04:00
cls_tcindex.c	net_sched: move the empty tp check from ->destroy() to ->delete()	2017-04-21 13:58:15 -04:00
cls_u32.c	net_sched: move the empty tp check from ->destroy() to ->delete()	2017-04-21 13:58:15 -04:00
em_canid.c	net: sched: remove tcf_proto from ematch calls	2014-10-06 18:02:32 -04:00
em_cmp.c
em_ipset.c	netfilter: x_tables: move hook state into xt_action_param structure	2016-11-03 10:56:21 +01:00
em_meta.c	netlink: pass extended ACK struct to parsing functions	2017-04-13 13:58:22 -04:00
em_nbyte.c	net: sched: remove tcf_proto from ematch calls	2014-10-06 18:02:32 -04:00
em_text.c	net: Remove state argument from skb_find_text()	2015-02-22 15:59:54 -05:00
em_u32.c
ematch.c	netlink: pass extended ACK struct to parsing functions	2017-04-13 13:58:22 -04:00
Kconfig	Subject: net: allow configuring default qdisc	2017-04-17 13:23:06 -04:00
Makefile	net/sched: Introduce sample tc action	2017-01-24 13:44:28 -05:00
sch_api.c	net: sched: Fix one possible panic when no destroy callback	2017-06-29 12:55:12 -04:00
sch_atm.c	netlink: pass extended ACK struct to parsing functions	2017-04-13 13:58:22 -04:00
sch_blackhole.c	net_sched: drop packets after root qdisc lock is released	2016-06-25 12:19:35 -04:00
sch_cbq.c	netlink: pass extended ACK struct to parsing functions	2017-04-13 13:58:22 -04:00
sch_choke.c	treewide: use kv[mz]alloc* rather than opencoded variants	2017-05-08 17:15:13 -07:00
sch_codel.c	netlink: pass extended ACK struct to parsing functions	2017-04-13 13:58:22 -04:00
sch_drr.c	netlink: pass extended ACK struct to parsing functions	2017-04-13 13:58:22 -04:00
sch_dsmark.c	netlink: pass extended ACK struct to parsing functions	2017-04-13 13:58:22 -04:00
sch_fifo.c	sched: don't use skb queue helpers	2016-09-19 01:47:18 -04:00
sch_fq_codel.c	treewide: use kv[mz]alloc* rather than opencoded variants	2017-05-08 17:15:13 -07:00
sch_fq.c	net: use kvmalloc with __GFP_REPEAT rather than open coded variant	2017-05-08 17:15:13 -07:00
sch_generic.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net	2017-04-15 21:16:30 -04:00
sch_gred.c	netlink: pass extended ACK struct to parsing functions	2017-04-13 13:58:22 -04:00
sch_hfsc.c	netlink: pass extended ACK struct to parsing functions	2017-04-13 13:58:22 -04:00
sch_hhf.c	treewide: use kv[mz]alloc* rather than opencoded variants	2017-05-08 17:15:13 -07:00
sch_htb.c	netlink: pass extended ACK struct to parsing functions	2017-04-13 13:58:22 -04:00
sch_ingress.c	sched: move tcf_proto_destroy and tcf_destroy_chain helpers into cls_api	2017-02-10 11:38:08 -05:00
sch_mq.c	net: sched: make default fifo qdiscs appear in the dump	2017-03-12 22:53:02 -07:00
sch_mqprio.c	mqprio: Modify mqprio to pass user parameters via ndo_setup_tc.	2017-03-15 15:20:27 -07:00
sch_multiq.c	net: sched: make default fifo qdiscs appear in the dump	2017-03-12 22:53:02 -07:00
sch_netem.c	treewide: use kv[mz]alloc* rather than opencoded variants	2017-05-08 17:15:13 -07:00
sch_pie.c	netlink: pass extended ACK struct to parsing functions	2017-04-13 13:58:22 -04:00
sch_plug.c	net_sched: drop packets after root qdisc lock is released	2016-06-25 12:19:35 -04:00
sch_prio.c	net: sched: make default fifo qdiscs appear in the dump	2017-03-12 22:53:02 -07:00
sch_qfq.c	netlink: pass extended ACK struct to parsing functions	2017-04-13 13:58:22 -04:00
sch_red.c	netlink: pass extended ACK struct to parsing functions	2017-04-13 13:58:22 -04:00
sch_sfb.c	netlink: pass extended ACK struct to parsing functions	2017-04-13 13:58:22 -04:00
sch_sfq.c	treewide: use kv[mz]alloc* rather than opencoded variants	2017-05-08 17:15:13 -07:00
sch_tbf.c	netlink: pass extended ACK struct to parsing functions	2017-04-13 13:58:22 -04:00
sch_teql.c	net: make ndo_get_stats64 a void function	2017-01-08 17:51:44 -05:00