Nico Boehr 6e46d9ff3e KVM: s390: disable migration mode when dirty tracking is disabled ... commit f2d3155e2a upstream. Migration mode is a VM attribute which enables tracking of changes in storage attributes (PGSTE). It assumes dirty tracking is enabled on all memslots to keep a dirty bitmap of pages with changed storage attributes. When enabling migration mode, we currently check that dirty tracking is enabled for all memslots. However, userspace can disable dirty tracking without disabling migration mode. Since migration mode is pointless with dirty tracking disabled, disable migration mode whenever userspace disables dirty tracking on any slot. Also update the documentation to clarify that dirty tracking must be enabled when enabling migration mode, which is already enforced by the code in kvm_s390_vm_start_migration(). Also highlight in the documentation for KVM_S390_GET_CMMA_BITS that it can now fail with -EINVAL when dirty tracking is disabled while migration mode is on. Move all the error codes to a table so this stays readable. To disable migration mode, slots_lock should be held, which is taken in kvm_set_memory_region() and thus held in kvm_arch_prepare_memory_region(). Restructure the prepare code a bit so all the sanity checking is done before disabling migration mode. This ensures migration mode isn't disabled when some sanity check fails. Cc: stable@vger.kernel.org Fixes: 190df4a212 ("KVM: s390: CMMA tracking, ESSA emulation, migration mode") Signed-off-by: Nico Boehr <nrb@linux.ibm.com> Reviewed-by: Janosch Frank <frankja@linux.ibm.com> Reviewed-by: Claudio Imbrenda <imbrenda@linux.ibm.com> Link: https://lore.kernel.org/r/20230127140532.230651-2-nrb@linux.ibm.com Message-Id: <20230127140532.230651-2-nrb@linux.ibm.com> [frankja@linux.ibm.com: fixed commit message typo, moved api.rst error table upwards] Signed-off-by: Janosch Frank <frankja@linux.ibm.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2023-03-10 09:40:01 +01:00
..
diag.c	KVM: s390: restore old debugfs names	2021-07-27 16:59:00 -04:00
gaccess.c	KVM: s390: Function documentation fixes	2021-09-28 17:56:54 +02:00
gaccess.h	KVM: s390: split kvm_s390_real_to_abs	2021-03-24 10:30:30 +01:00
guestdbg.c	KVM: s390: Add memcg accounting to KVM allocations	2020-12-10 13:36:05 +01:00
intercept.c	KVM: s390: pv: don't present the ecall interrupt twice	2022-08-17 14:22:48 +02:00
interrupt.c	KVM: s390: interrupt: use READ_ONCE() before cmpxchg()	2023-02-01 08:27:18 +01:00
irq.h	KVM: s390: Remove redundant license text	2017-12-06 09:18:42 +01:00
Kconfig	treewide: replace '---help---' in Kconfig files with 'help'	2020-06-14 01:57:21 +09:00
kvm-s390.c	KVM: s390: disable migration mode when dirty tracking is disabled	2023-03-10 09:40:01 +01:00
kvm-s390.h	KVM: s390: pv: don't allow userspace to set the clock under PV	2022-11-16 09:58:17 +01:00
Makefile	KVM: stats: Add fd-based API to read binary stats data	2021-06-24 11:47:57 -04:00
priv.c	KVM: s390x: fix SCK locking	2022-07-12 16:35:02 +02:00
pv.c	KVM: s390: pv: leak the topmost page table when destroy fails	2022-08-17 14:23:51 +02:00
sigp.c	KVM: s390: pv: don't present the ecall interrupt twice	2022-08-17 14:22:48 +02:00
trace-s390.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
trace.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
vsie.c	KVM: s390: vsie: Fix the initialization of the epoch extension (epdx) field	2022-12-14 11:37:20 +01:00