Paulo Alcantara 41f10081a9 cifs: fix NULL ptr dereference in refresh_mounts() ... Either mount(2) or automount might not have server->origin_fullpath set yet while refresh_cache_worker() is attempting to refresh DFS referrals. Add missing NULL check and locking around it. This fixes bellow crash: [ 1070.276835] general protection fault, probably for non-canonical address 0xdffffc0000000000: 0000 [#1] PREEMPT SMP KASAN NOPTI [ 1070.277676] KASAN: null-ptr-deref in range [0x0000000000000000-0x0000000000000007] [ 1070.278219] CPU: 1 PID: 8506 Comm: kworker/u8:1 Not tainted 5.18.0-rc3 #10 [ 1070.278701] Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS rel-1.15.0-0-g2dd4b9b-rebuilt.opensuse.org 04/01/2014 [ 1070.279495] Workqueue: cifs-dfscache refresh_cache_worker [cifs] [ 1070.280044] RIP: 0010:strcasecmp+0x34/0x150 [ 1070.280359] Code: 00 00 00 fc ff df 41 54 55 48 89 fd 53 48 83 ec 10 eb 03 4c 89 fe 48 89 ef 48 83 c5 01 48 89 f8 48 89 fa 48 c1 e8 03 83 e2 07 <42> 0f b6 04 28 38 d0 7f 08 84 c0 0f 85 bc 00 00 00 0f b6 45 ff 44 [ 1070.281729] RSP: 0018:ffffc90008367958 EFLAGS: 00010246 [ 1070.282114] RAX: 0000000000000000 RBX: dffffc0000000000 RCX: 0000000000000000 [ 1070.282691] RDX: 0000000000000000 RSI: 0000000000000000 RDI: 0000000000000000 [ 1070.283273] RBP: 0000000000000001 R08: 0000000000000000 R09: ffffffff873eda27 [ 1070.283857] R10: ffffc900083679a0 R11: 0000000000000001 R12: ffff88812624c000 [ 1070.284436] R13: dffffc0000000000 R14: ffff88810e6e9a88 R15: ffff888119bb9000 [ 1070.284990] FS: 0000000000000000(0000) GS:ffff888151200000(0000) knlGS:0000000000000000 [ 1070.285625] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 1070.286100] CR2: 0000561a4d922418 CR3: 000000010aecc000 CR4: 0000000000350ee0 [ 1070.286683] Call Trace: [ 1070.286890] <TASK> [ 1070.287070] refresh_cache_worker+0x895/0xd20 [cifs] [ 1070.287475] ? __refresh_tcon.isra.0+0xfb0/0xfb0 [cifs] [ 1070.287905] ? __lock_acquire+0xcd1/0x6960 [ 1070.288247] ? is_dynamic_key+0x1a0/0x1a0 [ 1070.288591] ? lockdep_hardirqs_on_prepare+0x410/0x410 [ 1070.289012] ? lock_downgrade+0x6f0/0x6f0 [ 1070.289318] process_one_work+0x7bd/0x12d0 [ 1070.289637] ? worker_thread+0x160/0xec0 [ 1070.289970] ? pwq_dec_nr_in_flight+0x230/0x230 [ 1070.290318] ? _raw_spin_lock_irq+0x5e/0x90 [ 1070.290619] worker_thread+0x5ac/0xec0 [ 1070.290891] ? process_one_work+0x12d0/0x12d0 [ 1070.291199] kthread+0x2a5/0x350 [ 1070.291430] ? kthread_complete_and_exit+0x20/0x20 [ 1070.291770] ret_from_fork+0x22/0x30 [ 1070.292050] </TASK> [ 1070.292223] Modules linked in: bpfilter cifs cifs_arc4 cifs_md4 [ 1070.292765] ---[ end trace 0000000000000000 ]--- [ 1070.293108] RIP: 0010:strcasecmp+0x34/0x150 [ 1070.293471] Code: 00 00 00 fc ff df 41 54 55 48 89 fd 53 48 83 ec 10 eb 03 4c 89 fe 48 89 ef 48 83 c5 01 48 89 f8 48 89 fa 48 c1 e8 03 83 e2 07 <42> 0f b6 04 28 38 d0 7f 08 84 c0 0f 85 bc 00 00 00 0f b6 45 ff 44 [ 1070.297718] RSP: 0018:ffffc90008367958 EFLAGS: 00010246 [ 1070.298622] RAX: 0000000000000000 RBX: dffffc0000000000 RCX: 0000000000000000 [ 1070.299428] RDX: 0000000000000000 RSI: 0000000000000000 RDI: 0000000000000000 [ 1070.300296] RBP: 0000000000000001 R08: 0000000000000000 R09: ffffffff873eda27 [ 1070.301204] R10: ffffc900083679a0 R11: 0000000000000001 R12: ffff88812624c000 [ 1070.301932] R13: dffffc0000000000 R14: ffff88810e6e9a88 R15: ffff888119bb9000 [ 1070.302645] FS: 0000000000000000(0000) GS:ffff888151200000(0000) knlGS:0000000000000000 [ 1070.303462] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 1070.304131] CR2: 0000561a4d922418 CR3: 000000010aecc000 CR4: 0000000000350ee0 [ 1070.305004] Kernel panic - not syncing: Fatal exception [ 1070.305711] Kernel Offset: disabled [ 1070.305971] ---[ end Kernel panic - not syncing: Fatal exception ]--- Signed-off-by: Paulo Alcantara (SUSE) <pc@cjr.nz> Cc: stable@vger.kernel.org Reviewed-by: Ronnie Sahlberg <lsahlber@redhat.com> Signed-off-by: Steve French <stfrench@microsoft.com>		2022-04-20 22:54:17 -05:00
..
asn1.c	cifs: decoding negTokenInit with generic ASN1 decoder	2021-06-20 21:28:17 -05:00
cifs_debug.c	smb3: cleanup and clarify status of tree connections	2022-03-28 17:07:30 -05:00
cifs_debug.h	cifs: use SPDX-Licence-Identifier	2021-06-20 21:28:17 -05:00
cifs_dfs_ref.c	cifs: support nested dfs links over reconnect	2021-11-10 16:30:13 -06:00
cifs_fs_sb.h	cifs: support nested dfs links over reconnect	2021-11-10 16:30:13 -06:00
cifs_ioctl.h	cifs: remove pathname for file from SPDX header	2021-09-13 14:51:10 -05:00
cifs_spnego_negtokeninit.asn1	cifs: decoding negTokenInit with generic ASN1 decoder	2021-06-20 21:28:17 -05:00
cifs_spnego.c	cifs: use the chans_need_reconnect bitmap for reconnect status	2022-01-02 20:38:46 -06:00
cifs_spnego.h	cifs: use the chans_need_reconnect bitmap for reconnect status	2022-01-02 20:38:46 -06:00
cifs_swn.c	cifs: use a different reconnect helper for non-cifsd threads	2022-03-18 23:12:03 -05:00
cifs_swn.h	cifs: simplify SWN code with dummy funcs instead of ifdefs	2021-04-25 16:28:22 -05:00
cifs_unicode.c	cifs: remove pathname for file from SPDX header	2021-09-13 14:51:10 -05:00
cifs_unicode.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 156	2019-05-30 11:26:35 -07:00
cifs_uniupr.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 156	2019-05-30 11:26:35 -07:00
cifsacl.c	cifs: modefromsids must add an ACE for authenticated users	2022-02-14 09:55:51 -06:00
cifsacl.h	cifs: remove pathname for file from SPDX header	2021-09-13 14:51:10 -05:00
cifsencrypt.c	cifs: take cifs_tcp_ses_lock for status checks	2022-01-07 20:07:07 -06:00
cifsfs.c	cifs: verify that tcon is valid before dereference in cifs_kill_sb	2022-04-14 00:07:36 -05:00
cifsfs.h	cifs: update internal module number	2022-04-04 22:40:14 -05:00
cifsglob.h	14 fixes to cifs client and to smbfs_common code	2022-04-01 14:31:57 -07:00
cifspdu.h	smb3: move defines for query info and query fsinfo to smbfs_common	2022-03-26 23:09:51 -05:00
cifsproto.h	cifs: use a different reconnect helper for non-cifsd threads	2022-03-18 23:12:03 -05:00
cifsroot.c	cifs: Standardize logging output	2020-06-01 00:10:18 -05:00
cifssmb.c	14 fixes to cifs client and to smbfs_common code	2022-04-01 14:31:57 -07:00
connect.c	cifs: fix NULL ptr dereference in refresh_mounts()	2022-04-20 22:54:17 -05:00
dfs_cache.c	cifs: fix NULL ptr dereference in refresh_mounts()	2022-04-20 22:54:17 -05:00
dfs_cache.h	cifs: support share failover when remounting	2021-07-22 11:43:23 -05:00
dir.c	cifs: Support fscache indexing rewrite	2022-01-19 11:21:08 -06:00
dns_resolve.c	cifs: remove pathname for file from SPDX header	2021-09-13 14:51:10 -05:00
dns_resolve.h	cifs: remove pathname for file from SPDX header	2021-09-13 14:51:10 -05:00
export.c	cifs: remove pathname for file from SPDX header	2021-09-13 14:51:10 -05:00
file.c	14 fixes to cifs client and to smbfs_common code	2022-04-01 14:31:57 -07:00
fs_context.c	smb3: fix snapshot mount option	2022-02-13 14:56:16 -06:00
fs_context.h	cifs: send workstation name during ntlmssp session setup	2021-11-08 13:07:56 -06:00
fscache.c	netfs: Add a netfs inode context	2022-03-18 09:29:05 +00:00
fscache.h	netfs: Add a netfs inode context	2022-03-18 09:29:05 +00:00
inode.c	fs: Remove ->readpages address space operation	2022-04-01 13:45:33 -04:00
ioctl.c	cifs: fix incorrect kernel doc comments	2021-09-13 18:29:46 -05:00
Kconfig	cifs: Support fscache indexing rewrite	2022-01-19 11:21:08 -06:00
link.c	cifs: potential buffer overflow in handling symlinks	2022-04-13 12:00:49 -05:00
Makefile	cifs: Support fscache indexing rewrite	2022-01-19 11:21:08 -06:00
misc.c	smb3: cleanup and clarify status of tree connections	2022-03-28 17:07:30 -05:00
netlink.c	cifs: Constify static struct genl_ops	2021-06-20 21:28:16 -05:00
netlink.h	cifs: Register generic netlink family	2020-12-14 09:16:22 -06:00
netmisc.c	cifs: fix potential race with cifsd thread	2022-04-04 12:01:22 -05:00
nterr.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 61	2019-05-24 17:36:45 +02:00
nterr.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 61	2019-05-24 17:36:45 +02:00
ntlmssp.h	treewide: Replace zero-length arrays with flexible-array members	2022-02-17 07:00:39 -06:00
readdir.c	cifs: remove pathname for file from SPDX header	2021-09-13 14:51:10 -05:00
rfc1002pdu.h	cifs: remove pathname for file from SPDX header	2021-09-13 14:51:10 -05:00
sess.c	cifs: fix confusing unneeded warning message on smb2.1 and earlier	2022-02-16 17:16:49 -06:00
smb1ops.c	cifs: use a different reconnect helper for non-cifsd threads	2022-03-18 23:12:03 -05:00
smb2file.c	cifs: remove pathname for file from SPDX header	2021-09-13 14:51:10 -05:00
smb2glob.h	smb3: move defines for ioctl protocol header and SMB2 sizes to smbfs_common	2022-03-26 23:09:20 -05:00
smb2inode.c	cifs: for compound requests, use open handle if possible	2021-11-10 11:05:20 -06:00
smb2maperror.c	cifs: Create a new shared file holding smb2 pdu definitions	2021-11-05 09:50:57 -05:00
smb2misc.c	cifs: remove check of list iterator against head past the loop body	2022-04-04 12:01:22 -05:00
smb2ops.c	cifs: Split the smb3_add_credits tracepoint	2022-04-08 21:25:38 -05:00
smb2pdu.c	smb3: cleanup and clarify status of tree connections	2022-03-28 17:07:30 -05:00
smb2pdu.h	smb3: fix ksmbd bigendian bug in oplock break, and move its struct to smbfs_common	2022-03-31 09:38:53 -05:00
smb2proto.h	cifs: convert the path to utf16 in smb2_query_info_compound	2022-03-23 15:17:22 -05:00
smb2status.h	cifs: remove pathname for file from SPDX header	2021-09-13 14:51:10 -05:00
smb2transport.c	cifs: protect all accesses to chan_* with chan_lock	2022-01-19 11:10:54 -06:00
smbdirect.c	smbdirect: missing rc checks while waiting for rdma events	2021-06-22 12:08:32 -05:00
smbdirect.h	cifs: smbd: Do not schedule work to send immediate packet on every receive	2020-04-07 12:41:16 -05:00
smbencrypt.c	cifs: rename cifs_common to smbfs_common	2021-09-08 23:59:26 -05:00
smberr.h	cifs: remove pathname for file from SPDX header	2021-09-13 14:51:10 -05:00
trace.c	smb3: Cleanup license mess	2019-01-24 09:37:33 -06:00
trace.h	cifs: Split the smb3_add_credits tracepoint	2022-04-08 21:25:38 -05:00
transport.c	cifs: Use kzalloc instead of kmalloc/memset	2022-04-18 10:22:57 -05:00
unc.c	cifs: don't cargo-cult strndup()	2021-04-25 16:28:23 -05:00
winucase.c	cifs: remove pathname for file from SPDX header	2021-09-13 14:51:10 -05:00
xattr.c	cifs: fix set of group SID via NTSD xattrs	2022-02-13 14:56:34 -06:00