mirror of
https://mirrors.bfsu.edu.cn/git/linux.git
synced 2024-12-11 13:04:03 +08:00
e28fd56ad5
In rmmod path, usbip_vudc does platform_device_put() twice once from platform_device_unregister() and then from put_vudc_device(). The second put results in: BUG kmalloc-2048 (Not tainted): Poison overwritten error or BUG: KASAN: use-after-free in kobject_put+0x1e/0x230 if KASAN is enabled. [ 169.042156] calling init+0x0/0x1000 [usbip_vudc] @ 1697 [ 169.042396] ============================================================================= [ 169.043678] probe of usbip-vudc.0 returned 1 after 350 usecs [ 169.044508] BUG kmalloc-2048 (Not tainted): Poison overwritten [ 169.044509] ----------------------------------------------------------------------------- ... [ 169.057849] INFO: Freed in device_release+0x2b/0x80 age=4223 cpu=3 pid=1693 [ 169.057852] kobject_put+0x86/0x1b0 [ 169.057853] 0xffffffffc0c30a96 [ 169.057855] __x64_sys_delete_module+0x157/0x240 Fix it to call platform_device_del() instead and let put_vudc_device() do the platform_device_put(). Reported-by: Randy Dunlap <rdunlap@infradead.org> Signed-off-by: Shuah Khan (Samsung OSG) <shuah@kernel.org> Cc: <stable@vger.kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
110 lines
2.5 KiB
C
110 lines
2.5 KiB
C
// SPDX-License-Identifier: GPL-2.0+
|
|
/*
|
|
* Copyright (C) 2015 Karol Kosik <karo9@interia.eu>
|
|
* Copyright (C) 2015-2016 Samsung Electronics
|
|
* Igor Kotrasinski <i.kotrasinsk@samsung.com>
|
|
* Krzysztof Opasiak <k.opasiak@samsung.com>
|
|
*/
|
|
|
|
#include <linux/device.h>
|
|
#include <linux/list.h>
|
|
#include <linux/module.h>
|
|
|
|
#include "vudc.h"
|
|
|
|
static unsigned int vudc_number = 1;
|
|
|
|
module_param_named(num, vudc_number, uint, S_IRUGO);
|
|
MODULE_PARM_DESC(num, "number of emulated controllers");
|
|
|
|
static struct platform_driver vudc_driver = {
|
|
.probe = vudc_probe,
|
|
.remove = vudc_remove,
|
|
.driver = {
|
|
.name = GADGET_NAME,
|
|
},
|
|
};
|
|
|
|
static struct list_head vudc_devices = LIST_HEAD_INIT(vudc_devices);
|
|
|
|
static int __init init(void)
|
|
{
|
|
int retval = -ENOMEM;
|
|
int i;
|
|
struct vudc_device *udc_dev = NULL, *udc_dev2 = NULL;
|
|
|
|
if (usb_disabled())
|
|
return -ENODEV;
|
|
|
|
if (vudc_number < 1) {
|
|
pr_err("Number of emulated UDC must be no less than 1");
|
|
return -EINVAL;
|
|
}
|
|
|
|
retval = platform_driver_register(&vudc_driver);
|
|
if (retval < 0)
|
|
goto out;
|
|
|
|
for (i = 0; i < vudc_number; i++) {
|
|
udc_dev = alloc_vudc_device(i);
|
|
if (!udc_dev) {
|
|
retval = -ENOMEM;
|
|
goto cleanup;
|
|
}
|
|
|
|
retval = platform_device_add(udc_dev->pdev);
|
|
if (retval < 0) {
|
|
put_vudc_device(udc_dev);
|
|
goto cleanup;
|
|
}
|
|
|
|
list_add_tail(&udc_dev->dev_entry, &vudc_devices);
|
|
if (!platform_get_drvdata(udc_dev->pdev)) {
|
|
/*
|
|
* The udc was added successfully but its probe
|
|
* function failed for some reason.
|
|
*/
|
|
retval = -EINVAL;
|
|
goto cleanup;
|
|
}
|
|
}
|
|
goto out;
|
|
|
|
cleanup:
|
|
list_for_each_entry_safe(udc_dev, udc_dev2, &vudc_devices, dev_entry) {
|
|
list_del(&udc_dev->dev_entry);
|
|
/*
|
|
* Just do platform_device_del() here, put_vudc_device()
|
|
* calls the platform_device_put()
|
|
*/
|
|
platform_device_del(udc_dev->pdev);
|
|
put_vudc_device(udc_dev);
|
|
}
|
|
|
|
platform_driver_unregister(&vudc_driver);
|
|
out:
|
|
return retval;
|
|
}
|
|
module_init(init);
|
|
|
|
static void __exit cleanup(void)
|
|
{
|
|
struct vudc_device *udc_dev = NULL, *udc_dev2 = NULL;
|
|
|
|
list_for_each_entry_safe(udc_dev, udc_dev2, &vudc_devices, dev_entry) {
|
|
list_del(&udc_dev->dev_entry);
|
|
/*
|
|
* Just do platform_device_del() here, put_vudc_device()
|
|
* calls the platform_device_put()
|
|
*/
|
|
platform_device_del(udc_dev->pdev);
|
|
put_vudc_device(udc_dev);
|
|
}
|
|
platform_driver_unregister(&vudc_driver);
|
|
}
|
|
module_exit(cleanup);
|
|
|
|
MODULE_DESCRIPTION("USB over IP Device Controller");
|
|
MODULE_AUTHOR("Krzysztof Opasiak, Karol Kosik, Igor Kotrasinski");
|
|
MODULE_LICENSE("GPL");
|