linux/sound/drivers/opl3
Colin Ian King 3fd58303b0 ALSA: drivers: opl3: Fix incorrect use of vp->state
commit 2dee54b289 upstream.

Static analysis with scan-build has found an assignment to vp2 that is
never used. It seems that the check on vp->state > 0 should be actually
on vp2->state instead. Fix this.

This dates back to 2002, I found the offending commit from the git
history git://git.kernel.org/pub/scm/linux/kernel/git/tglx/history.git,
commit 91e39521bbf6 ("[PATCH] ALSA patch for 2.5.4")

Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
Cc: <stable@vger.kernel.org>
Link: https://lore.kernel.org/r/20211212172025.470367-1-colin.i.king@gmail.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-12-29 12:28:50 +01:00
..
Makefile License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00
opl3_drums.c ALSA: opl3: More constifications 2020-01-05 16:14:59 +01:00
opl3_lib.c ALSA: opl3: Fix assignment in if condition 2021-06-09 17:30:33 +02:00
opl3_midi.c ALSA: drivers: opl3: Fix incorrect use of vp->state 2021-12-29 12:28:50 +01:00
opl3_oss.c ALSA: opl3: Fix assignment in if condition 2021-06-09 17:30:33 +02:00
opl3_seq.c ALSA: opl3: Fix assignment in if condition 2021-06-09 17:30:33 +02:00
opl3_synth.c ALSA: Convert strlcpy to strscpy when return value is unused 2021-01-08 09:30:05 +01:00
opl3_voice.h ALSA: seq: Constify struct snd_midi_op 2020-01-03 09:24:19 +01:00