Jae Hyun Yoo 3536169f85 media: aspeed: fix clock handling logic ... Video engine uses eclk and vclk for its clock sources and its reset control is coupled with eclk so the current clock enabling sequence works like below. Enable eclk De-assert Video Engine reset 10ms delay Enable vclk It introduces improper reset on the Video Engine hardware and eventually the hardware generates unexpected DMA memory transfers that can corrupt memory region in random and sporadic patterns. This issue is observed very rarely on some specific AST2500 SoCs but it causes a critical kernel panic with making a various shape of signature so it's extremely hard to debug. Moreover, the issue is observed even when the video engine is not actively used because udevd turns on the video engine hardware for a short time to make a query in every boot. To fix this issue, this commit changes the clock handling logic to make the reset de-assertion triggered after enabling both eclk and vclk. Also, it adds clk_unprepare call for a case when probe fails. clk: ast2600: fix reset settings for eclk and vclk Video engine reset setting should be coupled with eclk to match it with the setting for previous Aspeed SoCs which is defined in clk-aspeed.c since all Aspeed SoCs are sharing a single video engine driver. Also, reset bit 6 is defined as 'Video Engine' reset in datasheet so it should be de-asserted when eclk is enabled. This commit fixes the setting. Fixes: d2b4387f3b ("media: platform: Add Aspeed Video Engine driver") Signed-off-by: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com> Reviewed-by: Joel Stanley <joel@jms.id.au> Reviewed-by: Eddie James <eajames@linux.ibm.com> Fixes: d3d04f6c33 ("clk: Add support for AST2600 SoC") Reviewed-by: Joel Stanley <joel@jms.id.au> Acked-by: Stephen Boyd <sboyd@kernel.org> Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>		2021-03-11 11:59:45 +01:00
..
actions	clk: actions: Add Actions S500 SoC Reset Management Unit support	2020-07-21 01:50:47 -07:00
analogbits
at91	clk: at91: Fix the declaration of the clocks	2021-02-09 16:54:44 -08:00
axis
axs10x	clk: axs10x: use devm_platform_ioremap_resource() to simplify code	2019-10-16 16:17:50 -07:00
baikal-t1	clk: baikal-t1: Mark Ethernet PLL as critical	2020-10-13 19:48:34 -07:00
bcm	clk: bcm: clk-iproc-pll: Demote kernel-doc abuse	2021-02-11 11:56:06 -08:00
berlin
davinci	This pull request contains zero diff to the core framework. It is a collection	2020-10-22 12:53:28 -07:00
h8300
hisilicon	Merge branches 'clk-hisi', 'clk-amlogic', 'clk-samsung', 'clk-renesas' and 'clk-imx' into clk-next	2019-11-27 08:14:17 -08:00
imgtec	treewide: replace '---help---' in Kconfig files with 'help'	2020-06-14 01:57:21 +09:00
imx	This is all driver updates, the majority of which is a bunch of new Qualcomm	2021-02-22 09:45:23 -08:00
ingenic	clk: ingenic: Fix divider calculation with div tables	2020-12-19 16:04:58 -08:00
keystone	clk: keystone: sci-clk: add 10% slack to set_rate	2020-09-22 12:58:52 -07:00
loongson1
mediatek	clk: mediatek: mux: Update parent at enable time	2021-02-09 00:01:28 -08:00
meson	clk: meson: axg: Remove MIPI enable clock gate	2021-02-09 13:32:59 +01:00
microchip	clk: let init callback return an error code	2019-12-23 18:53:13 -08:00
mmp	clk: mmp2: fix build without CONFIG_PM	2021-01-12 12:10:55 -08:00
mstar	clk: mstar: msc313-mpll: Fix format specifier	2021-02-16 12:52:28 -08:00
mvebu	clk: mvebu: ap-cpu-clk: Demote non-conformant kernel-doc header	2021-02-11 11:56:06 -08:00
mxs
nxp
pistachio
pxa	clk: pxa: Constify static struct clk_ops	2020-10-13 19:49:11 -07:00
qcom	This is all driver updates, the majority of which is a bunch of new Qualcomm	2021-02-22 09:45:23 -08:00
renesas	clk: renesas: cpg-mssr: Fix formatting issues for 'smstpcr_saved's documentation	2021-01-28 09:45:56 +01:00
rockchip	clk: rockchip: fix DPHY gate locations on rk3368	2021-02-06 01:05:04 +01:00
samsung	The core framework got some nice improvements this time around. We gained the	2020-12-21 10:39:37 -08:00
sifive	clk: sifive: fu540-prci: Declare static const variable 'prci_clk_fu540' where it's used	2021-02-11 11:56:06 -08:00
socfpga	Merge branches 'clk-socfpga', 'clk-mstar', 'clk-qcom' and 'clk-warnings' into clk-next	2021-02-16 14:09:24 -08:00
spear	clk: spear: Move prototype to accessible header	2021-02-11 11:56:06 -08:00
sprd	This time around we have 4 lines of diff in the core framework, removing a	2020-06-10 11:42:19 -07:00
st	clk: st: clkgen-fsyn: Fix worthy struct documentation demote partially filled one	2021-02-11 11:56:06 -08:00
sunxi	clk: sunxi: clk-mod0: Demote non-conformant kernel-doc header	2021-01-20 10:58:29 +01:00
sunxi-ng	This is all driver updates, the majority of which is a bunch of new Qualcomm	2021-02-22 09:45:23 -08:00
tegra	This is all driver updates, the majority of which is a bunch of new Qualcomm	2021-02-22 09:45:23 -08:00
ti	clk: ti: gate: Fix possible doc-rot in 'omap36xx_gate_clk_enable_with_hsdiv_restore'	2021-02-11 11:56:07 -08:00
uniphier	clk: uniphier: use semicolons rather than commas to separate statements	2020-10-13 17:43:03 -07:00
ux500	clk: ux500: Fix up the SGA clock for some variants	2020-01-04 23:27:15 -08:00
versatile	clk: versatile: clk-icst: Fix worthy struct documentation block	2021-02-11 11:56:07 -08:00
x86	More ACPI updates for 5.9-rc1	2020-08-15 08:18:22 -07:00
xilinx	clk: xilinx: move xlnx_vcu clock driver from soc	2021-02-08 18:31:25 -08:00
zynq	clk: zynq: clkc: Remove various instances of an unused variable 'clk'	2021-02-11 11:56:07 -08:00
zynqmp	clk: zynqmp: divider: Add missing description for 'max_div'	2021-02-11 11:56:06 -08:00
clk-asm9260.c	clk: asm9260: fix __clk_hw_register_fixed_rate_with_accuracy typo	2020-04-13 12:20:06 -07:00
clk-aspeed.c	clk: aspeed: Add RMII RCLK gates for both AST2500 MACs	2019-11-26 10:02:48 -08:00
clk-aspeed.h	clk: aspeed: Move structures to header	2019-09-06 15:17:02 -07:00
clk-ast2600.c	media: aspeed: fix clock handling logic	2021-03-11 11:59:45 +01:00
clk-axi-clkgen.c	clk: axi-clkgen: use devm_platform_ioremap_resource() short-hand	2021-02-08 18:13:13 -08:00
clk-axm5516.c
clk-bd718x7.c	clk: BD718x7: Do not depend on parent driver data	2021-02-11 19:21:47 -08:00
clk-bm1880.c	clk: bm1800: Remove set but not used variable 'fref'	2019-12-24 00:10:33 -08:00
clk-bulk.c	clk: Make clk_bulk_get_all() return a valid "id"	2019-09-17 13:26:31 -07:00
clk-cdce706.c	Replace HTTP links with HTTPS ones: Common CLK framework	2020-07-10 17:15:34 -07:00
clk-cdce925.c	clk: clk-cdce925: Add regulator support	2019-09-06 10:31:16 -07:00
clk-clps711x.c
clk-composite.c	clk: composite: add devm_clk_hw_register_composite_pdata()	2020-12-07 14:06:16 -08:00
clk-conf.c
clk-cs2000-cp.c
clk-devres.c	clk: Add devm_clk_bulk_get_optional() function	2019-06-25 14:28:01 -07:00
clk-divider.c	clk: divider: fix initialization with parent_hw	2021-02-08 18:31:24 -08:00
clk-fixed-factor.c	clk: fixed: add devm helper for clk_hw_register_fixed_factor()	2021-02-14 12:37:48 -08:00
clk-fixed-mmio.c	clk: clk-fixed-mmio: Demote obvious kernel-doc abuse	2021-02-11 11:56:05 -08:00
clk-fixed-rate.c	clk: fixed: add missing kerneldoc	2020-09-22 12:44:14 -07:00
clk-fractional-divider.c
clk-fsl-flexspi.c	clk: fsl-flexspi: new driver	2020-12-07 16:56:41 -08:00
clk-fsl-sai.c	clk: fsl-sai: use devm_clk_hw_register_composite_pdata()	2020-12-07 14:06:16 -08:00
clk-gate.c	treewide: Remove uninitialized_var() usage	2020-07-16 12:35:15 -07:00
clk-gemini.c
clk-gpio.c	Replace HTTP links with HTTPS ones: Common CLK framework	2020-07-10 17:15:34 -07:00
clk-hi655x.c
clk-highbank.c
clk-hsdk-pll.c	CLK: HSDK: CGU: add support for 148.5MHz clock	2020-05-28 21:06:39 -07:00
clk-k210.c	clk: Add RISC-V Canaan Kendryte K210 clock driver	2021-02-22 17:51:04 -08:00
clk-lochnagar.c	clk: lochnagar: Don't reference clk_init_data after registration	2019-08-16 10:20:07 -07:00
clk-max9485.c
clk-max77686.c
clk-milbeaut.c	clk: milbeaut: Don't reference clk_init_data after registration	2019-08-16 10:20:15 -07:00
clk-moxart.c
clk-multiplier.c
clk-mux.c	clk: mux: Add support for specifying parents via DT/pointers	2020-01-06 23:10:05 -08:00
clk-nomadik.c
clk-npcm7xx.c	clk: clk-npcm7xx: Remove unused static const tables 'npcm7xx_gates' and 'npcm7xx_divs_fx'	2021-02-11 11:56:05 -08:00
clk-nspire.c
clk-oxnas.c
clk-palmas.c
clk-plldig.c	clk: ls1028a: fix a dereference of pointer 'parent' before a null check	2020-02-03 23:03:49 -08:00
clk-pwm.c	clk: pwm: drop of_match_ptr from of_device_id table	2020-12-10 12:24:18 -08:00
clk-qoriq.c	clk: qoriq: use macros to generate pll_mask	2021-02-14 13:02:01 -08:00
clk-rk808.c	- Core Frameworks	2019-07-15 20:18:40 -07:00
clk-s2mps11.c	clk: s2mps11: Fix a resource leak in error handling paths in the probe function	2020-12-19 15:53:31 -08:00
clk-scmi.c	clk: scmi: Fix min and max rate when registering clocks with discrete rates	2020-07-13 09:40:21 +01:00
clk-scpi.c	clk: scpi: mark scpi_clk_match as maybe unused	2020-12-10 12:24:40 -08:00
clk-si514.c
clk-si544.c	clk: clk-si544: Implement small frequency change support	2019-06-27 13:45:38 -07:00
clk-si570.c	clk: si570: Skip NVM to RAM recall operation if an optional property is set	2021-02-11 12:13:50 -08:00
clk-si5341.c	clk: si5341: drop unused 'err' variable	2020-09-22 12:44:41 -07:00
clk-si5351.c	clk: si5351: Wait for bit clear after PLL reset	2020-12-19 15:49:54 -08:00
clk-si5351.h
clk-sparx5.c	clk: sparx5: Add Sparx5 SoC DPLL clock driver	2020-07-28 18:17:56 -07:00
clk-stm32f4.c
clk-stm32h7.c
clk-stm32mp1.c
clk-twl6040.c
clk-versaclock5.c	clk: vc5: Add support for optional load capacitance	2021-02-11 12:09:34 -08:00
clk-vt8500.c
clk-wm831x.c
clk-xgene.c	clk: clk-xgene: Add description for 'mask' and fix formatting for 'flags'	2021-02-11 11:56:06 -08:00
clk.c	Driver core / debugfs update for 5.12-rc1	2021-02-24 10:13:55 -08:00
clk.h	clk: consoldiate the __clk_get_hw() declarations	2019-07-12 11:00:14 -07:00
clkdev.c
Kconfig	RISC-V Patches for the 5.12 Merge Window	2021-02-26 10:28:35 -08:00
Makefile	RISC-V Patches for the 5.12 Merge Window	2021-02-26 10:28:35 -08:00