Sabrina Dubroca b7c4f5730a tls: don't reset prot->aad_size and prot->tail_size for TLS_HW ... Prior to commit 1a074f7618 ("tls: also use init_prot_info in tls_set_device_offload"), setting TLS_HW on TX didn't touch prot->aad_size and prot->tail_size. They are set to 0 during context allocation (tls_prot_info is embedded in tls_context, kzalloc'd by tls_ctx_create). When the RX key is configured, tls_set_sw_offload is called (for both TLS_SW and TLS_HW). If the TX key is configured in TLS_HW mode after the RX key has been installed, init_prot_info will now overwrite the correct values of aad_size and tail_size, breaking SW decryption and causing -EBADMSG errors to be returned to userspace. Since TLS_HW doesn't use aad_size and tail_size at all (for TLS1.2, tail_size is always 0, and aad_size is equal to TLS_HEADER_SIZE + rec_seq_size), we can simply drop this hunk. Fixes: 1a074f7618 ("tls: also use init_prot_info in tls_set_device_offload") Signed-off-by: Sabrina Dubroca <sd@queasysnail.net> Acked-by: Jakub Kicinski <kuba@kernel.org> Tested-by: Ran Rozenstein <ranro@nvidia.com> Link: https://lore.kernel.org/r/979d2f89a6a994d5bb49cae49a80be54150d094d.1697653889.git.sd@queasysnail.net Signed-off-by: Jakub Kicinski <kuba@kernel.org>		2023-10-23 10:15:09 -07:00
..
Kconfig	net/tls: Select SOCK_RX_QUEUE_MAPPING from TLS_DEVICE	2021-02-11 19:08:06 -08:00
Makefile	tls: rx: async: hold onto the input skb	2022-07-18 11:24:11 +01:00
tls_device_fallback.c	tls: rename MAX_IV_SIZE to TLS_MAX_IV_SIZE	2023-10-13 11:26:09 +01:00
tls_device.c	tls: don't reset prot->aad_size and prot->tail_size for TLS_HW	2023-10-23 10:15:09 -07:00
tls_main.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2023-10-19 13:29:01 -07:00
tls_proc.c	tls: rx: add counter for NoPad violations	2022-07-11 19:48:33 -07:00
tls_strp.c	net/tls: Use tcp_read_sock() instead of ops->read_sock()	2023-07-27 19:49:35 -07:00
tls_sw.c	tls: don't reset prot->aad_size and prot->tail_size for TLS_HW	2023-10-23 10:15:09 -07:00
tls_toe.c	tls: create an internal header	2022-07-08 18:38:45 -07:00
tls.h	tls: don't reset prot->aad_size and prot->tail_size for TLS_HW	2023-10-23 10:15:09 -07:00
trace.c	net/tls: add tracing for device/offload events	2019-10-05 16:29:00 -07:00
trace.h	net/tls: add device decrypted trace point	2019-10-05 16:29:00 -07:00