Peter Xu 349d167000 mm/hugetlb: fix pgtable lock on pmd sharing ... Huge pmd sharing operates on PUD not PMD, huge_pte_lock() is not suitable in this case because it should only work for last level pte changes, while pmd sharing is always one level higher. Meanwhile, here we're locking over the spte pgtable lock which is even not a lock for current mm but someone else's. It seems even racy on operating on the lock, as after put_page() of the spte pgtable page logically the page can be released, so at least the spin_unlock() needs to be done after the put_page(). No report I am aware, I'm not even sure whether it'll just work on taking the spte pmd lock, because while we're holding i_mmap read lock it probably means the vma interval tree is frozen, all pte allocators over this pud entry could always find the specific svma and spte page, so maybe they'll serialize on this spte page lock? Even so, doesn't seem to be expected. It just seems to be an accident of cb900f4121. Fix it with the proper pud lock (which is the mm's page_table_lock). Link: https://lkml.kernel.org/r/20230612160420.809818-1-peterx@redhat.com Fixes: cb900f4121 ("mm, hugetlb: convert hugetlbfs to use split pmd lock") Signed-off-by: Peter Xu <peterx@redhat.com> Reviewed-by: Mike Kravetz <mike.kravetz@oracle.com> Cc: Naoya Horiguchi <naoya.horiguchi@nec.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>		2023-06-19 16:19:19 -07:00
..
damon	mm/pagewalkers: ACTION_AGAIN if pte_offset_map_lock() fails	2023-06-19 16:19:13 -07:00
kasan	kasan: use internal prototypes matching gcc-13 builtins	2023-06-09 16:25:19 -07:00
kfence	mm: kfence: fix false positives on big endian	2023-05-17 15:24:33 -07:00
kmsan	printk: export console trace point for kcsan/kasan/kfence/kmsan	2023-04-18 16:30:11 -07:00
backing-dev.c	- Nick Piggin's "shoot lazy tlbs" series, to improve the peformance of	2023-04-27 19:42:02 -07:00
balloon_compaction.c
bootmem_info.c
cma_debug.c	mm/cma_debug: show complete cma name in debugfs directories	2022-09-11 20:25:50 -07:00
cma_sysfs.c	mm: cma: make kobj_type structure constant	2023-03-28 16:20:06 -07:00
cma.c	mm: move most of core MM initialization to mm/mm_init.c	2023-04-05 19:42:52 -07:00
cma.h
compaction.c	mm: compaction: skip fast freepages isolation if enough freepages are isolated	2023-06-09 16:25:43 -07:00
debug_page_alloc.c	mm: page_alloc: split out DEBUG_PAGEALLOC	2023-06-09 16:25:23 -07:00
debug_page_ref.c
debug_vm_pgtable.c	mm/debug_vm_pgtable,page_table_check: warn pte map fails	2023-06-19 16:19:15 -07:00
debug.c	mm: update validate_mm() to use vma iterator	2023-06-09 16:25:31 -07:00
dmapool_test.c	dmapool: add alloc/free performance test	2023-04-05 19:42:38 -07:00
dmapool.c	dmapool: create/destroy cleanup	2023-06-09 16:25:17 -07:00
early_ioremap.c	mm/early_ioremap.c: improve the execution efficiency of early_ioremap_setup()	2023-06-09 16:25:56 -07:00
fadvise.c	mm: support POSIX_FADV_NOREUSE	2023-01-18 17:12:57 -08:00
fail_page_alloc.c	mm: page_alloc: split out FAIL_PAGE_ALLOC	2023-06-09 16:25:23 -07:00
failslab.c	mm: fix unexpected changes to {failslab|fail_page_alloc}.attr	2022-11-22 18:50:44 -08:00
filemap.c	mm/filemap: allow pte_offset_map_lock() to fail	2023-06-19 16:19:13 -07:00
folio-compat.c	- Nick Piggin's "shoot lazy tlbs" series, to improve the peformance of	2023-04-27 19:42:02 -07:00
frontswap.c	mm: zswap: support exclusive loads	2023-06-19 16:19:05 -07:00
gup_test.c	mm/gup: remove vmas parameter from pin_user_pages()	2023-06-09 16:25:26 -07:00
gup_test.h	mm/gup_test: start/stop/read functionality for PIN LONGTERM test	2022-11-08 17:37:15 -08:00
gup.c	mm/gup: remove FOLL_SPLIT_PMD use of pmd_trans_unstable()	2023-06-19 16:19:17 -07:00
highmem.c	highmem: fix kmap_to_page() for kmap_local_page() addresses	2022-10-12 18:51:51 -07:00
hmm.c	mm/hmm: retry if pte_offset_map() fails	2023-06-19 16:19:14 -07:00
huge_memory.c	mm: remove set_compound_page_dtor()	2023-06-19 16:19:19 -07:00
hugetlb_cgroup.c	mm/hugetlb: increase use of folios in alloc_huge_page()	2023-02-13 15:54:27 -08:00
hugetlb_vmemmap.c	mm: hugetlb_vmemmap: provide stronger vmemmap allocation guarantees	2023-06-09 16:25:19 -07:00
hugetlb_vmemmap.h
hugetlb.c	mm/hugetlb: fix pgtable lock on pmd sharing	2023-06-19 16:19:19 -07:00
hwpoison-inject.c	mm/hwpoison: add __init/__exit annotations to module init/exit funcs	2022-10-03 14:03:05 -07:00
init-mm.c	IOMMU Updates for Linux 6.4	2023-04-30 13:00:38 -07:00
internal.h	mm: remove set_compound_page_dtor()	2023-06-19 16:19:19 -07:00
interval_tree.c
io-mapping.c
ioremap.c
Kconfig	mm: zswap: support exclusive loads	2023-06-19 16:19:05 -07:00
Kconfig.debug	mm: change per-VMA lock statistics to be disabled by default	2023-05-02 17:23:28 -07:00
khugepaged.c	mm/pgtable: delete pmd_trans_unstable() and friends	2023-06-19 16:19:18 -07:00
kmemleak.c	lib/stackdepot, mm: rename stack_depot_want_early_init	2023-02-16 20:43:49 -08:00
ksm.c	mm/various: give up if pte_offset_map[_lock]() fails	2023-06-19 16:19:15 -07:00
list_lru.c
maccess.c	mm: Fix copy_from_user_nofault().	2023-04-12 17:36:23 -07:00
madvise.c	mm/madvise: clean up force_shm_swapin_readahead()	2023-06-19 16:19:16 -07:00
Makefile	mm: page_alloc: split out DEBUG_PAGEALLOC	2023-06-09 16:25:23 -07:00
mapping_dirty_helpers.c	mm/vmwgfx: simplify pmd & pud mapping dirty helpers	2023-06-19 16:19:14 -07:00
memblock.c	mm/memory_hotplug: remove reset_node_managed_pages() in hotadd_init_pgdat()	2023-06-19 16:19:05 -07:00
memcontrol.c	mm/various: give up if pte_offset_map[_lock]() fails	2023-06-19 16:19:15 -07:00
memfd.c	memfd: pass argument of memfd_fcntl as int	2023-04-18 16:30:11 -07:00
memory_hotplug.c	mm/mm_init.c: remove reset_node_present_pages()	2023-06-19 16:19:05 -07:00
memory-failure.c	mm/various: give up if pte_offset_map[_lock]() fails	2023-06-19 16:19:15 -07:00
memory-tiers.c	memory tier: remove unneeded disable_all_demotion_targets() when !CONFIG_MIGRATION	2023-06-19 16:19:00 -07:00
memory.c	perf/core: allow pte_offset_map() to fail	2023-06-19 16:19:19 -07:00
mempolicy.c	mm/pagewalkers: ACTION_AGAIN if pte_offset_map_lock() fails	2023-06-19 16:19:13 -07:00
mempool.c	mempool: do not use ksize() for poisoning	2022-11-30 15:58:41 -08:00
memremap.c	mm/memremap.c: fix outdated comment in devm_memremap_pages	2023-02-09 16:51:46 -08:00
memtest.c	mm/memtest: add results of early memtest to /proc/meminfo	2023-04-05 19:42:55 -07:00
migrate_device.c	mm/migrate_device: allow pte_offset_map_lock() to fail	2023-06-19 16:19:17 -07:00
migrate.c	mm/various: give up if pte_offset_map[_lock]() fails	2023-06-19 16:19:15 -07:00
mincore.c	mm/pagewalkers: ACTION_AGAIN if pte_offset_map_lock() fails	2023-06-19 16:19:13 -07:00
mlock.c	mm/pagewalkers: ACTION_AGAIN if pte_offset_map_lock() fails	2023-06-19 16:19:13 -07:00
mm_init.c	mm/mm_init.c: remove reset_node_present_pages()	2023-06-19 16:19:05 -07:00
mm_slot.h	mm: introduce common struct mm_slot	2022-10-03 14:02:43 -07:00
mmap_lock.c
mmap.c	mm/mmap: separate writenotify and dirty tracking logic	2023-06-09 16:25:56 -07:00
mmu_gather.c	mm: prefer xxx_page() alloc/free functions for order-0 pages	2023-03-28 16:20:16 -07:00
mmu_notifier.c	mm/mmu_notifier: remove unused mmu_notifier_range_update_to_read_only export	2023-02-02 22:32:54 -08:00
mmzone.c	mm: multi-gen LRU: groundwork	2022-09-26 19:46:09 -07:00
mprotect.c	mm/mprotect: delete pmd_none_or_clear_bad_unless_trans_huge()	2023-06-19 16:19:16 -07:00
mremap.c	mm/mremap: retry if either pte_offset_map_*lock() fails	2023-06-19 16:19:16 -07:00
msync.c	mm/msync: use vma_find() instead of vma linked list	2022-09-26 19:46:25 -07:00
nommu.c	mm: vmalloc: convert vread() to vread_iter()	2023-04-05 19:42:57 -07:00
oom_kill.c	mm, oom: do not check 0 mask in out_of_memory()	2023-06-09 16:25:20 -07:00
page_alloc.c	mm: page_alloc: remove unneeded header files	2023-06-09 16:25:55 -07:00
page_counter.c	mm: page_counter: remove unneeded atomic ops for low/min	2022-09-11 20:26:01 -07:00
page_ext.c	mm/page_ext: init page_ext early if there are no deferred struct pages	2023-02-02 22:33:22 -08:00
page_idle.c	mm: page_idle: convert page idle to use a folio	2023-01-18 17:12:52 -08:00
page_io.c	- Daniel Verkamp has contributed a memfd series ("mm/memfd: add	2023-02-23 17:09:35 -08:00
page_isolation.c	mm: page_isolation: write proper kerneldoc	2023-06-19 16:18:59 -07:00
page_owner.c	mm, treewide: redefine MAX_ORDER sanely	2023-04-05 19:42:46 -07:00
page_poison.c
page_reporting.c	mm, treewide: redefine MAX_ORDER sanely	2023-04-05 19:42:46 -07:00
page_reporting.h
page_table_check.c	mm/debug_vm_pgtable,page_table_check: warn pte map fails	2023-06-19 16:19:15 -07:00
page_vma_mapped.c	mm/page_vma_mapped: pte_offset_map_nolock() not pte_lockptr()	2023-06-19 16:19:13 -07:00
page-writeback.c	mm,jfs: move write_one_page/folio_write_one to jfs	2023-03-28 16:20:14 -07:00
pagewalk.c	mm/pagewalk: walk_pte_range() allow for pte_offset_map()	2023-06-19 16:19:14 -07:00
percpu-internal.h	mm: percpu: fix incorrect size in pcpu_obj_full_size()	2023-02-16 20:43:55 -08:00
percpu-km.c
percpu-stats.c
percpu-vm.c
percpu.c	mm: memcontrol: rename memcg_kmem_enabled()	2023-02-16 20:43:56 -08:00
pgalloc-track.h
pgtable-generic.c	mm/pgtable: allow pte_offset_map[_lock]() to fail	2023-06-19 16:19:12 -07:00
process_vm_access.c	mm/gup: remove unused vmas parameter from pin_user_pages_remote()	2023-06-09 16:25:25 -07:00
ptdump.c
readahead.c	readahead: convert readahead_expand() to use a folio	2023-02-02 22:33:21 -08:00
rmap.c	mm/gup: remove vmas parameter from get_user_pages_remote()	2023-06-09 16:25:26 -07:00
rodata_test.c	mm/rodata_test: use PAGE_ALIGNED() helper	2022-10-03 14:03:05 -07:00
secretmem.c	mm/mlock: rename mlock_future_check() to mlock_future_ok()	2023-06-09 16:25:38 -07:00
shmem.c	shmem: use ramfs_kill_sb() for kill_sb method of ramfs-based tmpfs	2023-06-19 16:19:04 -07:00
show_mem.c	mm: page_alloc: collect mem statistic into show_mem.c	2023-06-09 16:25:22 -07:00
shrinker_debug.c	mm: shrinkers: fix race condition on debugfs cleanup	2023-05-17 15:24:33 -07:00
shuffle.c	mm/shuffle: convert module_param_call to module_param_cb	2022-10-03 14:03:07 -07:00
shuffle.h	mm, treewide: redefine MAX_ORDER sanely	2023-04-05 19:42:46 -07:00
slab_common.c	mm/slab: document kfree() as allowed for kmem_cache_alloc() objects	2023-03-29 10:35:41 +02:00
slab.c	mm: vmscan: refactor updating current->reclaim_state	2023-04-18 16:30:10 -07:00
slab.h	- Nick Piggin's "shoot lazy tlbs" series, to improve the peformance of	2023-04-27 19:42:02 -07:00
slub.c	- Nick Piggin's "shoot lazy tlbs" series, to improve the peformance of	2023-04-27 19:42:02 -07:00
sparse-vmemmap.c	mm/vmemmap/devdax: fix kernel crash when probing devdax devices	2023-04-18 16:30:09 -07:00
sparse.c	mm/sparse: remove unused parameters in sparse_remove_section()	2023-06-19 16:19:04 -07:00
swap_cgroup.c	mm: memcontrol: don't allocate cgroup swap arrays when memcg is disabled	2022-10-03 14:03:36 -07:00
swap_slots.c	mm/swap: convert put_swap_page() to put_swap_folio()	2022-10-03 14:02:46 -07:00
swap_state.c	mm/swap: swap_vma_readahead() do the pte_offset_map()	2023-06-19 16:19:19 -07:00
swap.c	mm: swap: fix performance regression on sparsetruncate-tiny	2023-04-16 10:41:24 -07:00
swap.h	mm: remove the __swap_writepage return value	2023-02-02 22:33:33 -08:00
swapfile.c	mm/swapoff: allow pte_offset_map[_lock]() to fail	2023-06-19 16:19:16 -07:00
truncate.c	mm: return an ERR_PTR from __filemap_get_folio	2023-04-05 19:42:42 -07:00
usercopy.c	mm: Fix copy_from_user_nofault().	2023-04-12 17:36:23 -07:00
userfaultfd.c	mm/userfaultfd: allow pte_offset_map_lock() to fail	2023-06-19 16:19:15 -07:00
util.c	mm: uninline kstrdup()	2023-04-08 13:45:37 -07:00
vmalloc.c	mm/vmalloc: vmalloc_to_page() use pte_offset_kernel()	2023-06-19 16:19:14 -07:00
vmpressure.c
vmscan.c	mm/mglru: allow pte_offset_map_nolock() to fail	2023-06-19 16:19:17 -07:00
vmstat.c	vmstat: skip periodic vmstat update for isolated CPUs	2023-06-19 16:19:11 -07:00
workingset.c	Multi-gen LRU: fix workingset accounting	2023-06-09 16:25:46 -07:00
z3fold.c	mm: remove PageMovable export	2023-01-18 17:12:57 -08:00
zbud.c	zpool: clean out dead code	2022-12-11 18:12:10 -08:00
zpool.c	zpool: remove MODULE_LICENSE in non-modules	2023-04-13 13:13:54 -07:00
zsmalloc.c	mm/zsmalloc: get rid of PAGE_MASK	2023-06-09 16:25:21 -07:00
zswap.c	mm: zswap: support exclusive loads	2023-06-19 16:19:05 -07:00