korg/linux
0
0
Fork 0
mirror of https://mirrors.bfsu.edu.cn/git/linux.git synced 2024-12-14 06:24:53 +08:00
Code Issues Packages Projects Releases Wiki Activity
329101244f
linux/drivers/staging
History
Dan Carpenter 329101244f staging: greybus: light: fix a couple double frees 
The problem is in gb_lights_request_handler().  If we get a request to
change the config then we release the light with gb_lights_light_release()
and re-allocated it.  However, if the allocation fails part way through
then we call gb_lights_light_release() again.  This can lead to a couple
different double frees where we haven't cleared out the original values:

	gb_lights_light_v4l2_unregister(light);
	...
	kfree(light->channels);
	kfree(light->name);

I also made a small change to how we set "light->channels_count = 0;".
The original code handled this part fine and did not cause a use after
free but it was sort of complicated to read.

Fixes: 2870b52bae ("greybus: lights: add lights implementation")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Rui Miguel Silva <rmfrfs@gmail.com>
Link: https://lore.kernel.org/r/20190829122839.GA20116@mwanda
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2019-09-03 09:39:10 +02:00
..
android staging: android: Remove ion device tree bindings from the TODO 2019-08-21 05:48:06 -07:00
axis-fifo staging: remove redundant 'default n' from Kconfig 2019-04-16 13:39:01 +02:00
board staging: add missing SPDX lines to Makefile files 2019-04-03 11:10:15 +02:00
clocking-wizard staging: add missing SPDX lines to Makefile files 2019-04-03 11:10:15 +02:00
comedi staging: comedi: ni_mio_common: Fix a typo in ni_mio_common.c 2019-08-21 05:44:07 -07:00
emxx_udc staging: Remove dev_err() usage after platform_get_irq() 2019-07-30 20:50:04 +02:00
exfat staging: exfat: remove return and error return via a goto 2019-09-03 09:36:07 +02:00
fbtft Merge 5.3-rc4 into staging-next 2019-08-12 07:41:14 +02:00
fieldbus Staging / IIO driver update for 5.3-rc1 2019-07-11 15:36:02 -07:00
fsl-dpaa2 staging: fsl-dpaa2/ethsw: do not force user to bring interface down 2019-08-14 16:46:25 +02:00
fwserial staging: add missing SPDX lines to Makefile files 2019-04-03 11:10:15 +02:00
gasket staging: gasket: Remove unnecessary line-breaks in function signatures 2019-08-18 08:51:11 +02:00
gdm724x staging: add missing SPDX lines to Kconfig files 2019-04-03 11:10:15 +02:00
goldfish staging: Remove dev_err() usage after platform_get_irq() 2019-07-30 20:50:04 +02:00
greybus staging: greybus: light: fix a couple double frees 2019-09-03 09:39:10 +02:00
gs_fpgaboot staging: remove redundant 'default n' from Kconfig 2019-04-16 13:39:01 +02:00
iio staging: iio: ad2s1210: Use device-managed API 2019-07-27 22:52:06 +01:00
isdn staging: isdn: hysdn_procconf_init() remove parantheses from return value 2019-08-08 18:59:19 +02:00
kpc2000 staging: kpc2000: kpc2000_i2c: Fix different address spaces warnings 2019-08-21 05:48:06 -07:00
ks7010 Revert "staging: ks7010: Fix build error" 2019-06-24 16:45:34 +08:00
media staging: Remove dev_err() usage after platform_get_irq() 2019-07-30 20:50:04 +02:00
most staging: most: sound: Fix error path of audio_init 2019-08-28 22:22:13 +02:00
mt7621-dma staging: Remove dev_err() usage after platform_get_irq() 2019-07-30 20:50:04 +02:00
mt7621-dts staging: mt7621-dts: add support for second network interface 2019-07-03 18:28:29 +02:00
mt7621-pci staging: mt7621-pci: avoid use 'err' local variable 2019-07-25 09:58:26 +02:00
mt7621-pci-phy staging: mt7621-pci-phy: remove disable clock from the phy exit function 2019-06-21 16:50:10 +02:00
mt7621-pinctrl staging: mt7621-pinctrl: Add of_node_put() before return 2019-07-22 07:34:15 +02:00
netlogic staging: netlogic: Change GFP_ATOMIC to GFP_KERNEL 2019-07-01 09:07:03 +02:00
nvec staging: Remove dev_err() usage after platform_get_irq() 2019-07-30 20:50:04 +02:00
octeon Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next 2019-05-07 22:03:58 -07:00
octeon-usb staging: octeon-usb: Remove return variable 2019-05-30 14:13:45 -07:00
olpc_dcon staging: olpc_dcon: Remove TODO item 2019-07-30 09:52:04 +02:00
pi433 staging: pi433: Remove unnecessary variable 2019-05-24 09:00:44 +02:00
ralink-gdma staging: Remove dev_err() usage after platform_get_irq() 2019-07-30 20:50:04 +02:00
rtl8188eu Staging: rtl8188eu: core: rtw_security: tidy up crc32_init() 2019-08-08 18:59:18 +02:00
rtl8192e staging: rtl8192e: remove set but not used variable 'data_len' 2019-08-21 09:15:43 -07:00
rtl8192u staging: rtl8192u: Fix indentation 2019-08-28 22:22:13 +02:00
rtl8712 staging: rtl8712: wifi: checkpatch style fix 2019-08-27 19:01:26 +02:00
rtl8723bs staging: rtl8723bs: os_dep: Drop condition with no effect 2019-08-25 10:24:46 +02:00
rts5208 staging: rts5208: Fix checkpath warning 2019-09-03 09:36:29 +02:00
sm750fb staging: sm750fb: fix odd license text 2019-08-15 14:43:57 +02:00
speakup staging: speakup: serialio: fix warning linux/serial.h is included more than once 2019-05-30 13:59:16 -07:00
unisys staging: unisys: visornic: Update the description of 'poll_for_irq()' 2019-07-25 09:42:39 +02:00
vc04_services staging: bcm2835-camera: Spelling s/conencted/connected/ 2019-08-02 13:55:38 +02:00
vme staging: add missing SPDX lines to Makefile files 2019-04-03 11:10:15 +02:00
vt6655 staging: Add missing newline at end of file 2019-06-18 08:59:40 +02:00
vt6656 staging: vt6656: change alignment to match parenthesis 2019-07-22 07:34:15 +02:00
wilc1000 staging: wilc1000: return kernel error codes from wilc_wlan_stop 2019-08-12 16:35:39 +02:00
wlan-ng staging: wlan-ng: Remove function prism2mib_excludeunencrypted() 2019-08-02 13:55:38 +02:00
Kconfig staging: exfat: add exfat filesystem code to staging 2019-08-30 08:55:08 +02:00
Makefile staging: exfat: add exfat filesystem code to staging 2019-08-30 08:55:08 +02:00