Wengang Wang 58f880711f xfs: make sure sb_fdblocks is non-negative ... A user with a completely full filesystem experienced an unexpected shutdown when the filesystem tried to write the superblock during runtime. kernel shows the following dmesg: [ 8.176281] XFS (dm-4): Metadata corruption detected at xfs_sb_write_verify+0x60/0x120 [xfs], xfs_sb block 0x0 [ 8.177417] XFS (dm-4): Unmount and run xfs_repair [ 8.178016] XFS (dm-4): First 128 bytes of corrupted metadata buffer: [ 8.178703] 00000000: 58 46 53 42 00 00 10 00 00 00 00 00 01 90 00 00 XFSB............ [ 8.179487] 00000010: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................ [ 8.180312] 00000020: cf 12 dc 89 ca 26 45 29 92 e6 e3 8d 3b b8 a2 c3 .....&E)....;... [ 8.181150] 00000030: 00 00 00 00 01 00 00 06 00 00 00 00 00 00 00 80 ................ [ 8.182003] 00000040: 00 00 00 00 00 00 00 81 00 00 00 00 00 00 00 82 ................ [ 8.182004] 00000050: 00 00 00 01 00 64 00 00 00 00 00 04 00 00 00 00 .....d.......... [ 8.182004] 00000060: 00 00 64 00 b4 a5 02 00 02 00 00 08 00 00 00 00 ..d............. [ 8.182005] 00000070: 00 00 00 00 00 00 00 00 0c 09 09 03 17 00 00 19 ................ [ 8.182008] XFS (dm-4): Corruption of in-memory data detected. Shutting down filesystem [ 8.182010] XFS (dm-4): Please unmount the filesystem and rectify the problem(s) When xfs_log_sb writes super block to disk, b_fdblocks is fetched from m_fdblocks without any lock. As m_fdblocks can experience a positive -> negative -> positive changing when the FS reaches fullness (see xfs_mod_fdblocks). So there is a chance that sb_fdblocks is negative, and because sb_fdblocks is type of unsigned long long, it reads super big. And sb_fdblocks being bigger than sb_dblocks is a problem during log recovery, xfs_validate_sb_write() complains. Fix: As sb_fdblocks will be re-calculated during mount when lazysbcount is enabled, We just need to make xfs_validate_sb_write() happy -- make sure sb_fdblocks is not nenative. This patch also takes care of other percpu counters in xfs_log_sb. Signed-off-by: Wengang Wang <wen.gang.wang@oracle.com> Reviewed-by: Darrick J. Wong <djwong@kernel.org> Signed-off-by: Chandan Babu R <chandanbabu@kernel.org>		2024-06-10 11:38:12 +05:30
..
libxfs	xfs: make sure sb_fdblocks is non-negative	2024-06-10 11:38:12 +05:30
scrub	xfs: don't open-code u64_to_user_ptr	2024-05-27 15:55:52 +05:30
Kconfig	xfs: support in-memory btrees	2024-02-22 12:43:35 -08:00
Makefile	New code for 6.10:	2024-05-20 12:55:12 -07:00
xfs_acl.c	xfs: make attr removal an explicit operation	2024-04-23 07:46:51 -07:00
xfs_acl.h
xfs_aops.c	xfs: xfs_quota_unreserve_blkres can't fail	2024-05-03 11:15:03 +05:30
xfs_aops.h
xfs_attr_inactive.c	xfs: report dir/attr block corruption errors to the health system	2024-02-22 12:32:18 -08:00
xfs_attr_item.c	xfs: fix xfs_init_attr_trans not handling explicit operation codes	2024-05-27 15:55:52 +05:30
xfs_attr_item.h	xfs: create attr log item opcodes and formats for parent pointers	2024-04-23 07:46:57 -07:00
xfs_attr_list.c	xfs: pass the attr value to put_listent when possible	2024-04-23 07:47:00 -07:00
xfs_bio_io.c
xfs_bmap_item.c	xfs: simplify iext overflow checking and upgrade	2024-05-03 11:20:06 +05:30
xfs_bmap_item.h	xfs: move xfs_bmap_defer_add to xfs_bmap_item.c	2024-02-22 12:44:21 -08:00
xfs_bmap_util.c	xfs: simplify iext overflow checking and upgrade	2024-05-03 11:20:06 +05:30
xfs_bmap_util.h	xfs: xfs_quota_unreserve_blkres can't fail	2024-05-03 11:15:03 +05:30
xfs_buf_item_recover.c	xfs: convert remaining kmem_free() to kfree()	2024-02-13 18:07:34 +05:30
xfs_buf_item.c	xfs: convert remaining kmem_free() to kfree()	2024-02-13 18:07:34 +05:30
xfs_buf_item.h
xfs_buf_mem.c	xfs: fix dev_t usage in xmbuf tracepoints	2024-03-15 10:30:23 +05:30
xfs_buf_mem.h	xfs: launder in-memory btree buffers before transaction commit	2024-02-22 12:43:36 -08:00
xfs_buf.c	getting rid of bogus set_blocksize() uses, switching it	2024-05-21 08:34:51 -07:00
xfs_buf.h	New code for 6.9:	2024-03-13 13:52:24 -07:00
xfs_dahash_test.c	xfs: test the ascii case-insensitive hash	2023-04-11 19:05:05 -07:00
xfs_dahash_test.h	xfs: test dir/attr hash when loading module	2023-03-19 09:55:49 -07:00
xfs_dir2_readdir.c	xfs: refactor dir format helpers	2024-04-26 11:21:46 +05:30
xfs_discard.c	xfs: fix performance problems when fstrimming a subset of a fragmented AG	2024-04-15 14:59:00 -07:00
xfs_discard.h	xfs: move log discard work to xfs_discard.c	2023-10-04 09:24:02 +11:00
xfs_dquot_item_recover.c	xfs: dquot recovery does not validate the recovered dquot	2023-11-22 23:39:36 +05:30
xfs_dquot_item.c
xfs_dquot_item.h
xfs_dquot.c	xfs: simplify iext overflow checking and upgrade	2024-05-03 11:20:06 +05:30
xfs_dquot.h	xfs: Increase XFS_QM_TRANS_MAXDQS to 5	2024-04-15 14:59:01 -07:00
xfs_drain.c	xfs: minimize overhead of drain wakeups by using jump labels	2023-04-11 18:59:59 -07:00
xfs_drain.h	xfs: minimize overhead of drain wakeups by using jump labels	2023-04-11 18:59:59 -07:00
xfs_error.c	xfs: add error injection to test file mapping exchange recovery	2024-04-15 14:54:19 -07:00
xfs_error.h
xfs_exchmaps_item.c	xfs: capture inode generation numbers in the ondisk exchmaps log item	2024-04-15 14:54:24 -07:00
xfs_exchmaps_item.h	xfs: create deferred log items for file mapping exchanges	2024-04-15 14:54:17 -07:00
xfs_exchrange.c	xfs: support non-power-of-two rtextsize with exchange-range	2024-04-15 14:54:23 -07:00
xfs_exchrange.h	xfs: create deferred log items for file mapping exchanges	2024-04-15 14:54:17 -07:00
xfs_export.c	xfs: add parent pointer ioctls	2024-04-23 07:47:00 -07:00
xfs_export.h	xfs: add parent pointer ioctls	2024-04-23 07:47:00 -07:00
xfs_extent_busy.c	xfs: unwind xfs_extent_busy_clear	2024-04-22 12:53:34 +05:30
xfs_extent_busy.h	xfs: repair free space btrees	2023-12-15 10:03:32 -08:00
xfs_extfree_item.c	xfs: convert remaining kmem_free() to kfree()	2024-02-13 18:07:34 +05:30
xfs_extfree_item.h
xfs_file.c	New code for 6.10:	2024-05-20 12:55:12 -07:00
xfs_file.h	xfs: create a new helper to return a file's allocation unit	2024-04-15 14:54:10 -07:00
xfs_filestream.c	xfs: convert remaining kmem_free() to kfree()	2024-02-13 18:07:34 +05:30
xfs_filestream.h	xfs: pass perag to filestreams tracing	2023-02-13 09:14:56 +11:00
xfs_fsmap.c	xfs: refactor realtime inode locking	2024-04-22 18:00:47 +05:30
xfs_fsmap.h
xfs_fsops.c	xfs: split xfs_mod_freecounter	2024-04-22 18:00:47 +05:30
xfs_fsops.h	xfs: split xfs_mod_freecounter	2024-04-22 18:00:47 +05:30
xfs_globals.c	xfs: add debug knobs to control btree bulk load slack factors	2023-12-15 10:03:28 -08:00
xfs_handle.c	xfs: don't open-code u64_to_user_ptr	2024-05-27 15:55:52 +05:30
xfs_handle.h	xfs: add parent pointer ioctls	2024-04-23 07:47:00 -07:00
xfs_health.c	xfs: report directory tree corruption in the health information	2024-04-23 16:55:17 -07:00
xfs_hooks.c	xfs: allow scrub to hook metadata updates in other writers	2024-02-22 12:30:45 -08:00
xfs_hooks.h	xfs: allow scrub to hook metadata updates in other writers	2024-02-22 12:30:45 -08:00
xfs_icache.c	xfs: widen flags argument to the xfs_iflags_* helpers	2024-05-02 07:48:37 -07:00
xfs_icache.h	xfs: use per-mount cpumask to track nonempty percpu inodegc lists	2023-09-11 08:39:03 -07:00
xfs_icreate_item.c	xfs: convert kmem_free() for kvmalloc users to kvfree()	2024-02-13 18:07:34 +05:30
xfs_icreate_item.h
xfs_inode_item_recover.c	xfs: convert remaining kmem_free() to kfree()	2024-02-13 18:07:34 +05:30
xfs_inode_item.c	xfs: Replace xfs_isilocked with xfs_assert_ilocked	2024-02-19 21:19:33 +05:30
xfs_inode_item.h	xfs: fix AGF vs inode cluster buffer deadlock	2023-06-05 04:08:27 +10:00
xfs_inode.c	xfs: fix corruptions in the directory tree	2024-04-23 16:55:17 -07:00
xfs_inode.h	xfs: widen flags argument to the xfs_iflags_* helpers	2024-05-02 07:48:37 -07:00
xfs_ioctl32.c	xfs: move handle ioctl code to xfs_handle.c	2024-04-23 07:47:00 -07:00
xfs_ioctl32.h	arch: Remove Itanium (IA-64) architecture	2023-09-11 08:13:17 +00:00
xfs_ioctl.c	xfs: introduce vectored scrub mode	2024-04-23 16:55:18 -07:00
xfs_ioctl.h	xfs: move handle ioctl code to xfs_handle.c	2024-04-23 07:47:00 -07:00
xfs_iomap.c	xfs: simplify iext overflow checking and upgrade	2024-05-03 11:20:06 +05:30
xfs_iomap.h
xfs_iops.c	xfs: parent pointer attribute creation	2024-04-23 07:46:58 -07:00
xfs_iops.h	xfs: declare xfs_file.c symbols in xfs_file.h	2024-04-15 14:54:09 -07:00
xfs_itable.c	xfs: hide private inodes from bulkstat and handle functions	2024-04-15 14:58:48 -07:00
xfs_itable.h
xfs_iunlink_item.c	xfs: create traced helper to get extra perag references	2023-04-11 18:59:55 -07:00
xfs_iunlink_item.h
xfs_iwalk.c	xfs: Clear W=1 warning in xfs_iwalk_run_callbacks()	2024-05-27 15:54:24 +05:30
xfs_iwalk.h
xfs_linux.h	xfs: refactor non-power-of-two alignment checks	2024-04-15 14:54:12 -07:00
xfs_log_cil.c	xfs: fix CIL sparse lock context warnings	2024-04-20 20:23:59 +05:30
xfs_log_priv.h	xfs: Fix typo in comment	2024-04-22 12:51:43 +05:30
xfs_log_recover.c	xfs: clean up buffer allocation in xlog_do_recovery_pass	2024-05-03 11:10:17 +05:30
xfs_log.c	xfs: only clear log incompat flags at clean unmount	2024-04-15 14:54:06 -07:00
xfs_log.h	xfs: only clear log incompat flags at clean unmount	2024-04-15 14:54:06 -07:00
xfs_message.c
xfs_message.h
xfs_mount.c	xfs: use an XFS_OPSTATE_ flag for detecting if logged xattrs are available	2024-04-23 07:46:51 -07:00
xfs_mount.h	xfs: use an XFS_OPSTATE_ flag for detecting if logged xattrs are available	2024-04-23 07:46:51 -07:00
xfs_mru_cache.c	xfs: use GFP_KERNEL in pure transaction contexts	2024-02-13 18:07:35 +05:30
xfs_mru_cache.h
xfs_notify_failure.c	mm, pmem, xfs: Introduce MF_MEM_PRE_REMOVE for unbind	2023-12-07 14:34:26 +05:30
xfs_pnfs.c
xfs_pnfs.h
xfs_pwork.c
xfs_pwork.h
xfs_qm_bhv.c	xfs: track quota updates during live quotacheck	2024-02-22 12:30:55 -08:00
xfs_qm_syscalls.c
xfs_qm.c	xfs: Hold inode locks in xfs_ialloc	2024-04-15 14:59:02 -07:00
xfs_qm.h	xfs: Increase XFS_QM_TRANS_MAXDQS to 5	2024-04-15 14:59:01 -07:00
xfs_quota.h	xfs: xfs_quota_unreserve_blkres can't fail	2024-05-03 11:15:03 +05:30
xfs_quotaops.c
xfs_refcount_item.c	xfs: place intent recovery under NOFS allocation context	2024-02-13 18:07:35 +05:30
xfs_refcount_item.h
xfs_reflink.c	xfs: Add cond_resched to block unmap range and reflink remap path	2024-05-27 20:50:35 +05:30
xfs_reflink.h
xfs_rmap_item.c	xfs: place intent recovery under NOFS allocation context	2024-02-13 18:07:35 +05:30
xfs_rmap_item.h
xfs_rtalloc.c	xfs: simplify iext overflow checking and upgrade	2024-05-03 11:20:06 +05:30
xfs_rtalloc.h	xfs: move xfs_bmap_rtalloc to xfs_rtalloc.c	2023-12-22 11:18:11 +05:30
xfs_stats.c	xfs: define an in-memory btree for storing refcount bag info during repairs	2024-02-22 12:43:40 -08:00
xfs_stats.h	xfs: define an in-memory btree for storing refcount bag info during repairs	2024-02-22 12:43:40 -08:00
xfs_super.c	xfs: add a incompat feature bit for parent pointers	2024-04-23 07:47:01 -07:00
xfs_super.h	xfs: create scaffolding for creating debugfs entries	2023-08-10 07:48:07 -07:00
xfs_symlink.c	xfs: add parent attributes to symlink	2024-04-23 07:46:58 -07:00
xfs_symlink.h	xfs: move remote symlink target read function to libxfs	2024-02-22 12:45:17 -08:00
xfs_sysctl.c	fs: Remove the now superfluous sentinel elements from ctl_table array	2023-12-28 04:57:57 -08:00
xfs_sysctl.h	xfs: add debug knobs to control btree bulk load slack factors	2023-12-15 10:03:28 -08:00
xfs_sysfs.c	xfs: remove duplicate ifdefs	2024-02-17 09:32:32 +05:30
xfs_sysfs.h
xfs_trace.c	xfs: add parent pointer ioctls	2024-04-23 07:47:00 -07:00
xfs_trace.h	tracing/treewide: Remove second parameter of __assign_str()	2024-05-22 20:14:47 -04:00
xfs_trans_ail.c	xfs: convert remaining kmem_free() to kfree()	2024-02-13 18:07:34 +05:30
xfs_trans_buf.c	xfs: launder in-memory btree buffers before transaction commit	2024-02-22 12:43:36 -08:00
xfs_trans_dquot.c	xfs: Increase XFS_QM_TRANS_MAXDQS to 5	2024-04-15 14:59:01 -07:00
xfs_trans_priv.h
xfs_trans.c	xfs: split xfs_mod_freecounter	2024-04-22 18:00:47 +05:30
xfs_trans.h	xfs: don't use current->journal_info	2024-03-25 10:21:01 +05:30
xfs_xattr.c	xfs: make the reserved block permission flag explicit in xfs_attr_set	2024-04-23 07:47:03 -07:00
xfs_xattr.h	xfs: remove xfs_da_args.attr_flags	2024-04-23 07:46:50 -07:00
xfs.h