linux/sound/pci/echoaudio
Mark Hills c914f55f7c ALSA: echoaudio: Remove incorrect part of assertion
This assertion seems to imply that chip->dsp_code_to_load is a pointer.
It's actually an integer handle on the actual firmware, and 0 has no
special meaning.

The assertion prevents initialisation of a Darla20 card, but would also
affect other models. It seems it was introduced in commit dd7b254d.

ALSA sound/pci/echoaudio/echoaudio.c:2061 Echoaudio driver starting...
ALSA sound/pci/echoaudio/echoaudio.c:1969 chip=ebe4e000
ALSA sound/pci/echoaudio/echoaudio.c:2007 pci=ed568000 irq=19 subdev=0010 Init hardware...
ALSA sound/pci/echoaudio/darla20_dsp.c:36 init_hw() - Darla20
------------[ cut here ]------------
WARNING: at sound/pci/echoaudio/echoaudio_dsp.c:478 init_hw+0x1d1/0x86c [snd_darla20]()
Hardware name: Dell DM051
BUG? (!chip->dsp_code_to_load || !chip->comm_page)

Signed-off-by: Mark Hills <mark@pogo.org.uk>
Cc: <stable@kernel.org>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
2012-05-06 12:54:20 +02:00
..
darla20_dsp.c ALSA: Echoaudio - Add suspend support #1 2010-02-15 10:39:22 +01:00
darla20.c sound: fix drivers needing module.h not moduleparam.h 2011-10-31 19:31:19 -04:00
darla24_dsp.c ALSA: Echoaudio - Add suspend support #1 2010-02-15 10:39:22 +01:00
darla24.c sound: fix drivers needing module.h not moduleparam.h 2011-10-31 19:31:19 -04:00
echo3g_dsp.c ALSA: Echoaudio - Add suspend support #1 2010-02-15 10:39:22 +01:00
echo3g.c sound: fix drivers needing module.h not moduleparam.h 2011-10-31 19:31:19 -04:00
echoaudio_3g.c ALSA: Echoaudio - Add firmware cache #1 2010-02-15 10:36:51 +01:00
echoaudio_dsp.c ALSA: echoaudio: Remove incorrect part of assertion 2012-05-06 12:54:20 +02:00
echoaudio_dsp.h ALSA: Echoaudio: add support for Indigo express cards 2009-03-19 08:17:57 +01:00
echoaudio_gml.c ALSA: Kill snd_assert() in sound/pci/* 2008-08-13 11:46:38 +02:00
echoaudio.c ALSA: module_param: make bool parameters really bool 2011-12-19 10:34:41 +01:00
echoaudio.h ALSA: Echoaudio - Add suspend support #2 2010-02-15 10:40:15 +01:00
gina20_dsp.c ALSA: Echoaudio - Add suspend support #1 2010-02-15 10:39:22 +01:00
gina20.c sound: fix drivers needing module.h not moduleparam.h 2011-10-31 19:31:19 -04:00
gina24_dsp.c ALSA: Echoaudio - Add suspend support #1 2010-02-15 10:39:22 +01:00
gina24.c sound: fix drivers needing module.h not moduleparam.h 2011-10-31 19:31:19 -04:00
indigo_dsp.c ALSA: Echoaudio - Add suspend support #1 2010-02-15 10:39:22 +01:00
indigo_express_dsp.c ALSA: Echoaudio - Add suspend support #1 2010-02-15 10:39:22 +01:00
indigo.c sound: fix drivers needing module.h not moduleparam.h 2011-10-31 19:31:19 -04:00
indigodj_dsp.c ALSA: Echoaudio - Add suspend support #1 2010-02-15 10:39:22 +01:00
indigodj.c sound: fix drivers needing module.h not moduleparam.h 2011-10-31 19:31:19 -04:00
indigodjx_dsp.c ALSA: Echoaudio - Add suspend support #1 2010-02-15 10:39:22 +01:00
indigodjx.c sound: fix drivers needing module.h not moduleparam.h 2011-10-31 19:31:19 -04:00
indigoio_dsp.c ALSA: Echoaudio - Add suspend support #1 2010-02-15 10:39:22 +01:00
indigoio.c sound: fix drivers needing module.h not moduleparam.h 2011-10-31 19:31:19 -04:00
indigoiox_dsp.c ALSA: Echoaudio - Add suspend support #1 2010-02-15 10:39:22 +01:00
indigoiox.c sound: fix drivers needing module.h not moduleparam.h 2011-10-31 19:31:19 -04:00
layla20_dsp.c ALSA: Echoaudio - Add suspend support #1 2010-02-15 10:39:22 +01:00
layla20.c sound: fix drivers needing module.h not moduleparam.h 2011-10-31 19:31:19 -04:00
layla24_dsp.c ALSA: Echoaudio - Add suspend support #1 2010-02-15 10:39:22 +01:00
layla24.c sound: fix drivers needing module.h not moduleparam.h 2011-10-31 19:31:19 -04:00
Makefile ALSA: Echoaudio: add support for Indigo express cards 2009-03-19 08:17:57 +01:00
mia_dsp.c ALSA: Echoaudio - Add suspend support #1 2010-02-15 10:39:22 +01:00
mia.c sound: fix drivers needing module.h not moduleparam.h 2011-10-31 19:31:19 -04:00
midi.c ALSA: echoaudio - replace uses of __constant_{endian} 2009-02-12 00:24:11 +01:00
mona_dsp.c ALSA: Echoaudio - Add suspend support #1 2010-02-15 10:39:22 +01:00
mona.c sound: fix drivers needing module.h not moduleparam.h 2011-10-31 19:31:19 -04:00