Zhengchao Shao 2a3fc78210 net: sched: sfb: fix null pointer access issue when sfb_init() fails ... When the default qdisc is sfb, if the qdisc of dev_queue fails to be inited during mqprio_init(), sfb_reset() is invoked to clear resources. In this case, the q->qdisc is NULL, and it will cause gpf issue. The process is as follows: qdisc_create_dflt() sfb_init() tcf_block_get() --->failed, q->qdisc is NULL ... qdisc_put() ... sfb_reset() qdisc_reset(q->qdisc) --->q->qdisc is NULL ops = qdisc->ops The following is the Call Trace information: general protection fault, probably for non-canonical address 0xdffffc0000000003: 0000 [#1] PREEMPT SMP KASAN KASAN: null-ptr-deref in range [0x0000000000000018-0x000000000000001f] RIP: 0010:qdisc_reset+0x2b/0x6f0 Call Trace: <TASK> sfb_reset+0x37/0xd0 qdisc_reset+0xed/0x6f0 qdisc_destroy+0x82/0x4c0 qdisc_put+0x9e/0xb0 qdisc_create_dflt+0x2c3/0x4a0 mqprio_init+0xa71/0x1760 qdisc_create+0x3eb/0x1000 tc_modify_qdisc+0x408/0x1720 rtnetlink_rcv_msg+0x38e/0xac0 netlink_rcv_skb+0x12d/0x3a0 netlink_unicast+0x4a2/0x740 netlink_sendmsg+0x826/0xcc0 sock_sendmsg+0xc5/0x100 ____sys_sendmsg+0x583/0x690 ___sys_sendmsg+0xe8/0x160 __sys_sendmsg+0xbf/0x160 do_syscall_64+0x35/0x80 entry_SYSCALL_64_after_hwframe+0x46/0xb0 RIP: 0033:0x7f2164122d04 </TASK> Fixes: e13e02a3c6 ("net_sched: SFB flow scheduler") Signed-off-by: Zhengchao Shao <shaozhengchao@huawei.com> Signed-off-by: David S. Miller <davem@davemloft.net>		2022-10-19 13:47:09 +01:00
..
act_api.c	net: sched: act_api: implement generic walker and search for tc action	2022-09-09 08:24:41 +01:00
act_bpf.c	net: sched: act_bpf: simplify code logic in tcf_bpf_init()	2022-09-28 09:38:56 +01:00
act_connmark.c	net: sched: act_connmark: get rid of tcf_connmark_walker and tcf_connmark_search	2022-09-09 08:24:41 +01:00
act_csum.c	net: sched: act_csum: get rid of tcf_csum_walker and tcf_csum_search	2022-09-09 08:24:41 +01:00
act_ct.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2022-09-29 14:30:51 -07:00
act_ctinfo.c	net: sched: act_ctinfo: get rid of tcf_ctinfo_walker and tcf_ctinfo_search	2022-09-09 08:24:41 +01:00
act_gact.c	net: sched: act_gact: get rid of tcf_gact_walker and tcf_gact_search	2022-09-09 08:24:41 +01:00
act_gate.c	net: sched: act_gate: get rid of tcf_gate_walker and tcf_gate_search	2022-09-09 08:24:42 +01:00
act_ife.c	net: sched: act_ife: get rid of tcf_ife_walker and tcf_ife_search	2022-09-09 08:24:42 +01:00
act_ipt.c	net: sched: act_ipt: get rid of tcf_ipt_walker/tcf_xt_walker and tcf_ipt_search/tcf_xt_search	2022-09-09 08:24:42 +01:00
act_meta_mark.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
act_meta_skbprio.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
act_meta_skbtcindex.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
act_mirred.c	net: sched: remove unused tcf_result extension	2022-09-21 18:32:33 -07:00
act_mpls.c	net: sched: act_mpls: get rid of tcf_mpls_walker and tcf_mpls_search	2022-09-09 08:24:42 +01:00
act_nat.c	net: sched: act_nat: get rid of tcf_nat_walker and tcf_nat_search	2022-09-09 08:24:42 +01:00
act_pedit.c	net: sched: act_pedit: get rid of tcf_pedit_walker and tcf_pedit_search	2022-09-09 08:24:42 +01:00
act_police.c	net: sched: act_police: get rid of tcf_police_walker and tcf_police_search	2022-09-09 08:24:42 +01:00
act_sample.c	net: sched: act_sample: get rid of tcf_sample_walker and tcf_sample_search	2022-09-09 08:24:42 +01:00
act_simple.c	net: sched: act_simple: get rid of tcf_simp_walker and tcf_simp_search	2022-09-09 08:24:42 +01:00
act_skbedit.c	net: sched: act_skbedit: get rid of tcf_skbedit_walker and tcf_skbedit_search	2022-09-09 08:24:42 +01:00
act_skbmod.c	net: sched: act_skbmod: get rid of tcf_skbmod_walker and tcf_skbmod_search	2022-09-09 08:24:42 +01:00
act_tunnel_key.c	net: sched: act_tunnel_key: get rid of tunnel_key_walker and tunnel_key_search	2022-09-09 08:24:42 +01:00
act_vlan.c	net: sched: act_vlan: get rid of tcf_vlan_walker and tcf_vlan_search	2022-09-09 08:24:43 +01:00
cls_api.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2022-09-22 13:02:10 -07:00
cls_basic.c	net: sched: use tc_cls_bind_class() in filter	2022-10-02 16:07:17 +01:00
cls_bpf.c	net: sched: use tc_cls_bind_class() in filter	2022-10-02 16:07:17 +01:00
cls_cgroup.c	net_sched: refactor TC action init API	2021-08-02 10:24:38 +01:00
cls_flow.c	net/sched: use tc_cls_stats_dump() in filter	2022-09-20 15:54:13 -07:00
cls_flower.c	net: sched: use tc_cls_bind_class() in filter	2022-10-02 16:07:17 +01:00
cls_fw.c	net: sched: use tc_cls_bind_class() in filter	2022-10-02 16:07:17 +01:00
cls_matchall.c	net: sched: use tc_cls_bind_class() in filter	2022-10-02 16:07:17 +01:00
cls_route.c	net: sched: use tc_cls_bind_class() in filter	2022-10-02 16:07:17 +01:00
cls_rsvp6.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
cls_rsvp.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
cls_rsvp.h	net: sched: use tc_cls_bind_class() in filter	2022-10-02 16:07:17 +01:00
cls_tcindex.c	net: sched: use tc_cls_bind_class() in filter	2022-10-02 16:07:17 +01:00
cls_u32.c	net: sched: use tc_cls_bind_class() in filter	2022-10-02 16:07:17 +01:00
em_canid.c	net: sched: kerneldoc fixes	2020-07-13 17:20:40 -07:00
em_cmp.c	net: sched: fix misspellings using misspell-fixer tool	2020-11-10 17:00:28 -08:00
em_ipset.c	sched: consistently handle layer3 header accesses in the presence of VLANs	2020-07-03 14:34:53 -07:00
em_ipt.c	sched: consistently handle layer3 header accesses in the presence of VLANs	2020-07-03 14:34:53 -07:00
em_meta.c	net_sched: em_meta: add READ_ONCE() in var_sk_bound_if()	2022-05-16 10:31:06 +01:00
em_nbyte.c	net: sched: Return the correct errno code	2021-02-06 11:15:28 -08:00
em_text.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
em_u32.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
ematch.c	net: sched: Fix spelling mistakes	2021-05-31 22:44:56 -07:00
Kconfig	net: sched: incorrect Kconfig dependencies on Netfilter modules	2020-12-09 15:49:29 -08:00
Makefile	net/sched: sch_frag: add generic packet fragment support.	2020-11-27 14:36:02 -08:00
sch_api.c	net: sched: ensure n arg not empty before call bind_class	2022-10-02 16:07:17 +01:00
sch_atm.c	net/sched: use tc_qdisc_stats_dump() in qdisc	2022-09-22 17:34:10 -07:00
sch_blackhole.c	Revert "net: sched: Pass root lock to Qdisc_ops.enqueue"	2020-07-16 16:48:34 -07:00
sch_cake.c	net: sched: cake: fix null pointer access issue when cake_init() fails	2022-10-19 13:47:09 +01:00
sch_cbq.c	net/sched: use tc_qdisc_stats_dump() in qdisc	2022-09-22 17:34:10 -07:00
sch_cbs.c	net/sched: use tc_qdisc_stats_dump() in qdisc	2022-09-22 17:34:10 -07:00
sch_choke.c	net: sched: choke: remove unused variables in struct choke_sched_data	2022-08-31 19:39:53 -07:00
sch_codel.c	net: sched: remove redundant NULL check in change hook function	2022-09-01 08:06:45 +02:00
sch_drr.c	net/sched: use tc_qdisc_stats_dump() in qdisc	2022-09-22 17:34:10 -07:00
sch_dsmark.c	net/sched: use tc_qdisc_stats_dump() in qdisc	2022-09-22 17:34:10 -07:00
sch_etf.c	net: sched: etf: remove true check in etf_enable_offload()	2022-09-01 20:08:32 -07:00
sch_ets.c	net/sched: use tc_qdisc_stats_dump() in qdisc	2022-09-22 17:34:10 -07:00
sch_fifo.c	net_sched: fix NULL deref in fifo_set_limit()	2021-10-01 14:59:10 -07:00
sch_fq_codel.c	Revert "net: sched: fq_codel: remove redundant resource cleanup in fq_codel_init()"	2022-10-19 13:47:09 +01:00
sch_fq_pie.c	net: sched: remove redundant NULL check in change hook function	2022-09-01 08:06:45 +02:00
sch_fq.c	net: sched: remove redundant NULL check in change hook function	2022-09-01 08:06:45 +02:00
sch_frag.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next	2021-12-31 14:35:40 +00:00
sch_generic.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2022-09-01 12:58:02 -07:00
sch_gred.c	net: sched: gred: remove NULL check before free table->tab in gred_destroy()	2022-09-01 13:32:26 +02:00
sch_hfsc.c	net/sched: use tc_qdisc_stats_dump() in qdisc	2022-09-22 17:34:10 -07:00
sch_hhf.c	net: sched: remove redundant NULL check in change hook function	2022-09-01 08:06:45 +02:00
sch_htb.c	net/sched: use tc_qdisc_stats_dump() in qdisc	2022-09-22 17:34:10 -07:00
sch_ingress.c	net: sched: Pass ingress block to tcf_classify_ingress	2020-02-19 17:49:48 -08:00
sch_mq.c	net/sched: use tc_qdisc_stats_dump() in qdisc	2022-09-22 17:34:10 -07:00
sch_mqprio.c	net/sched: use tc_qdisc_stats_dump() in qdisc	2022-09-22 17:34:10 -07:00
sch_multiq.c	net/sched: use tc_qdisc_stats_dump() in qdisc	2022-09-22 17:34:10 -07:00
sch_netem.c	net/sched: use tc_qdisc_stats_dump() in qdisc	2022-09-22 17:34:10 -07:00
sch_pie.c	net: sched: remove redundant NULL check in change hook function	2022-09-01 08:06:45 +02:00
sch_plug.c	net: sched: remove redundant NULL check in change hook function	2022-09-01 08:06:45 +02:00
sch_prio.c	net/sched: use tc_qdisc_stats_dump() in qdisc	2022-09-22 17:34:10 -07:00
sch_qfq.c	net/sched: use tc_qdisc_stats_dump() in qdisc	2022-09-22 17:34:10 -07:00
sch_red.c	net/sched: use tc_qdisc_stats_dump() in qdisc	2022-09-22 17:34:10 -07:00
sch_sfb.c	net: sched: sfb: fix null pointer access issue when sfb_init() fails	2022-10-19 13:47:09 +01:00
sch_sfq.c	net/sched: use tc_qdisc_stats_dump() in qdisc	2022-09-22 17:34:10 -07:00
sch_skbprio.c	net/sched: use tc_qdisc_stats_dump() in qdisc	2022-09-22 17:34:10 -07:00
sch_taprio.c	Revert "net/sched: taprio: make qdisc_leaf() see the per-netdev-queue pfifo child qdiscs"	2022-10-05 20:32:15 -07:00
sch_tbf.c	net/sched: use tc_qdisc_stats_dump() in qdisc	2022-09-22 17:34:10 -07:00
sch_teql.c	net: sched: delete duplicate cleanup of backlog and qlen	2022-08-25 15:10:17 +02:00