Lachlan McIlroy 2a32963130 [XFS] Fix race condition in xfs_write(). ... This change addresses a race in xfs_write() where, for direct I/O, the flags need_i_mutex and need_flush are setup before the iolock is acquired. The logic used to setup the flags may change between setting the flags and acquiring the iolock resulting in these flags having incorrect values. For example, if a file is not currently cached then need_i_mutex is set to zero and then if the file is cached before the iolock is acquired we will fail to do the flushinval before the direct write. The flush (and also the call to xfs_zero_eof()) need to be done with the iolock held exclusive so we need to acquire the iolock before checking for cached data (or if the write begins after eof) to prevent this state from changing. For direct I/O I've chosen to always acquire the iolock in shared mode initially and if there is a need to promote it then drop it and reacquire it. There's also some other tidy-ups including removing the O_APPEND offset adjustment since that work is done in generic_write_checks() (and we don't use offset as an input parameter anywhere). SGI-PV: 962170 SGI-Modid: xfs-linux-melb:xfs-kern:28319a Signed-off-by: Lachlan McIlroy <lachlan@sgi.com> Signed-off-by: David Chinner <dgc@sgi.com> Signed-off-by: Tim Shimmin <tes@sgi.com>		2007-05-08 13:49:39 +10:00
..
linux-2.6	[XFS] Fix race condition in xfs_write().	2007-05-08 13:49:39 +10:00
quota	[XFS] Fix uquota and oquota enforcement problems.	2007-05-08 13:49:33 +10:00
support	[XFS] reducing the number of random number functions.	2007-05-08 13:49:03 +10:00
Kbuild
Kconfig	[PATCH] BLOCK: Make it possible to disable the block layer [try #6]	2006-09-30 20:52:31 +02:00
Makefile
Makefile-linux-2.6	[XFS] 956618: Linux crashes on boot with XFS-DMAPI filesystem when	2006-11-11 18:03:49 +11:00
xfs_acl.c	[XFS] Remove unused header files for MAC and CAP checking functionality.	2007-02-10 18:37:28 +11:00
xfs_acl.h	[XFS] Resolve a namespace collision on remaining vtypes for FreeBSD	2006-06-09 17:07:12 +10:00
xfs_ag.h	[XFS] endianess annotation for xfs_agfl_t. Trivial, xfs_agfl_t is always	2006-09-28 10:56:51 +10:00
xfs_alloc_btree.c	[XFS] Reduce endian flipping in alloc_btree, same as was done for	2006-09-28 11:05:40 +10:00
xfs_alloc_btree.h	[XFS] Remove unused arguments from the XFS_BTREE_*_ADDR macros.	2007-02-10 18:37:33 +11:00
xfs_alloc.c	[XFS] reducing the number of random number functions.	2007-05-08 13:49:03 +10:00
xfs_alloc.h	[XFS] Prevent free space oversubscription and xfssyncd looping.	2006-09-07 14:26:50 +10:00
xfs_arch.h
xfs_attr_leaf.c	[XFS] The last argument "lsn" of xfs_trans_commit() is always called with	2007-05-08 13:48:42 +10:00
xfs_attr_leaf.h	[XFS] Add EA list callbacks for xfs kernel use. Cleanup some namespace	2006-09-28 11:01:37 +10:00
xfs_attr_sf.h	[XFS] endianess annotations for xfs_attr_shortform_t	2006-03-17 17:29:25 +11:00
xfs_attr.c	[XFS] The last argument "lsn" of xfs_trans_commit() is always called with	2007-05-08 13:48:42 +10:00
xfs_attr.h	[XFS] Add EA list callbacks for xfs kernel use. Cleanup some namespace	2006-09-28 11:01:37 +10:00
xfs_behavior.c	[XFS] remove bhv_lookup, _range version works aswell and has more useful	2006-09-28 10:58:52 +10:00
xfs_behavior.h	[XFS] remove bhv_lookup, _range version works aswell and has more useful	2006-09-28 10:58:52 +10:00
xfs_bit.c	[XFS] Keep stack usage down for 4k stacks by using noinline.	2007-02-10 18:34:56 +11:00
xfs_bit.h
xfs_bmap_btree.c	[XFS] Remove a bunch of unused functions from XFS.	2007-02-10 18:37:40 +11:00
xfs_bmap_btree.h	[XFS] Remove a bunch of unused functions from XFS.	2007-02-10 18:37:40 +11:00
xfs_bmap.c	[XFS] remove more misc. unused args	2007-05-08 13:48:56 +10:00
xfs_bmap.h	[XFS] Remove unused argument to xfs_bmap_finish	2007-02-10 18:37:16 +11:00
xfs_btree.c	[XFS] endianess annotations for xfs_bmbt_key Trivial as there are no	2006-09-28 10:58:17 +10:00
xfs_btree.h	[XFS] Remove unused arguments from the XFS_BTREE_*_ADDR macros.	2007-02-10 18:37:33 +11:00
xfs_buf_item.c	[XFS] Keep stack usage down for 4k stacks by using noinline.	2007-02-10 18:34:56 +11:00
xfs_buf_item.h	[XFS] Get rid of old 5.3/6.1 v1 log items. Cleanup patch sent in by Eric	2007-02-10 18:35:02 +11:00
xfs_clnt.h	[XFS] Implement the silent parameter to fill_super, previously ignored.	2006-03-31 13:04:17 +10:00
xfs_da_btree.c	[XFS] Remove a bunch of unused functions from XFS.	2007-02-10 18:37:40 +11:00
xfs_da_btree.h	[XFS] Remove a bunch of unused functions from XFS.	2007-02-10 18:37:40 +11:00
xfs_dfrag.c	[XFS] propogate return codes from flush routines	2007-05-08 13:49:27 +10:00
xfs_dfrag.h	[XFS] Add parameters to xfs_bmapi() and xfs_bunmapi() to have them report	2006-06-09 14:48:12 +10:00
xfs_dinode.h	[XFS] Remove version 1 directory code. Never functioned on Linux, just	2006-06-20 13:04:51 +10:00
xfs_dir2_block.c	[XFS] the "aendp" arg to xfs_dir2_data_freescan is always NULL, remove it.	2007-05-08 13:48:49 +10:00
xfs_dir2_block.h	[XFS] endianess annotations for xfs_dir2_block_tail_t	2006-03-17 17:27:56 +11:00
xfs_dir2_data.c	[XFS] the "aendp" arg to xfs_dir2_data_freescan is always NULL, remove it.	2007-05-08 13:48:49 +10:00
xfs_dir2_data.h	[XFS] the "aendp" arg to xfs_dir2_data_freescan is always NULL, remove it.	2007-05-08 13:48:49 +10:00
xfs_dir2_leaf.c	[XFS] the "aendp" arg to xfs_dir2_data_freescan is always NULL, remove it.	2007-05-08 13:48:49 +10:00
xfs_dir2_leaf.h	[XFS] endianess annotations for xfs_dir2_leaf_entry_t	2006-03-17 17:28:18 +11:00
xfs_dir2_node.c	[XFS] the "aendp" arg to xfs_dir2_data_freescan is always NULL, remove it.	2007-05-08 13:48:49 +10:00
xfs_dir2_node.h	[XFS] endianess annotations for xfs_dir2_free_hdr_t	2006-03-17 17:27:07 +11:00
xfs_dir2_sf.c	[XFS] Remove version 1 directory code. Never functioned on Linux, just	2006-06-20 13:04:51 +10:00
xfs_dir2_sf.h
xfs_dir2_trace.c	[XFS] Remove version 1 directory code. Never functioned on Linux, just	2006-06-20 13:04:51 +10:00
xfs_dir2_trace.h
xfs_dir2.c	[XFS] rename uio_read() to xfs_uio_read()	2006-11-11 18:04:41 +11:00
xfs_dir2.h	[XFS] Remove version 1 directory code. Never functioned on Linux, just	2006-06-20 13:04:51 +10:00
xfs_dmapi.h	[XFS] Remove KERNEL_VERSION macros from xfs_dmapi.h	2006-11-11 18:05:06 +11:00
xfs_dmops.c	[XFS] Remove version 1 directory code. Never functioned on Linux, just	2006-06-20 13:04:51 +10:00
xfs_error.c	[XFS] reducing the number of random number functions.	2007-05-08 13:49:03 +10:00
xfs_error.h	[XFS] Remove a bunch of unused functions from XFS.	2007-02-10 18:37:40 +11:00
xfs_extfree_item.c	[XFS] Keep stack usage down for 4k stacks by using noinline.	2007-02-10 18:34:56 +11:00
xfs_extfree_item.h	[XFS] cleanup the field types of some item format structures	2006-09-28 10:55:43 +10:00
xfs_fs.h	[XFS] Remove several macros that are no longer used anywhere	2006-09-28 11:02:57 +10:00
xfs_fsops.c	[XFS] The last argument "lsn" of xfs_trans_commit() is always called with	2007-05-08 13:48:42 +10:00
xfs_fsops.h
xfs_ialloc_btree.c	[XFS] use NULL for pointer initialisation instead of zero-cast-to-ptr	2006-09-28 10:58:40 +10:00
xfs_ialloc_btree.h	[XFS] Remove unused arguments from the XFS_BTREE_*_ADDR macros.	2007-02-10 18:37:33 +11:00
xfs_ialloc.c	[XFS] Keep stack usage down for 4k stacks by using noinline.	2007-02-10 18:34:56 +11:00
xfs_ialloc.h
xfs_iget.c	[XFS] Prevent a deadlock when xfslogd unpins inodes.	2006-11-11 18:05:00 +11:00
xfs_imap.h
xfs_inode_item.c	[XFS] Keep stack usage down for 4k stacks by using noinline.	2007-02-10 18:34:56 +11:00
xfs_inode_item.h	[XFS] cleanup the field types of some item format structures	2006-09-28 10:55:43 +10:00
xfs_inode.c	[XFS] propogate return codes from flush routines	2007-05-08 13:49:27 +10:00
xfs_inode.h	[XFS] propogate return codes from flush routines	2007-05-08 13:49:27 +10:00
xfs_inum.h
xfs_iocore.c	[XFS] Remove version 1 directory code. Never functioned on Linux, just	2006-06-20 13:04:51 +10:00
xfs_iomap.c	[XFS] The last argument "lsn" of xfs_trans_commit() is always called with	2007-05-08 13:48:42 +10:00
xfs_iomap.h
xfs_itable.c	[XFS] 955947: Infinite loop in xfs_bulkstat() on formatter() error	2006-09-28 11:06:21 +10:00
xfs_itable.h	[XFS] pv 956241, author: nathans, rv: vapo - make ino validation checks	2006-09-28 11:06:15 +10:00
xfs_log_priv.h	[XFS] Fixes the leak in reservation space because we weren't ungranting	2006-09-28 11:04:16 +10:00
xfs_log_recover.c	[XFS] remove more misc. unused args	2007-05-08 13:48:56 +10:00
xfs_log_recover.h
xfs_log.c	[XFS] Fixes the leak in reservation space because we weren't ungranting	2006-09-28 11:04:16 +10:00
xfs_log.h	[XFS] Remove several macros that are no longer used anywhere	2006-09-28 11:02:57 +10:00
xfs_mount.c	[XFS] The last argument "lsn" of xfs_trans_commit() is always called with	2007-05-08 13:48:42 +10:00
xfs_mount.h	[XFS] Re-initialize the per-cpu superblock counters after recovery.	2007-02-10 18:36:29 +11:00
xfs_qmops.c	[XFS] The last argument "lsn" of xfs_trans_commit() is always called with	2007-05-08 13:48:42 +10:00
xfs_quota.h	[XFS] Fix uquota and oquota enforcement problems.	2007-05-08 13:49:33 +10:00
xfs_refcache.h
xfs_rename.c	[XFS] The last argument "lsn" of xfs_trans_commit() is always called with	2007-05-08 13:48:42 +10:00
xfs_rtalloc.c	[XFS] The last argument "lsn" of xfs_trans_commit() is always called with	2007-05-08 13:48:42 +10:00
xfs_rtalloc.h	[XFS] Remove a bunch of unused functions from XFS.	2007-02-10 18:37:40 +11:00
xfs_rw.c	[XFS] The last argument "lsn" of xfs_trans_commit() is always called with	2007-05-08 13:48:42 +10:00
xfs_rw.h	[XFS] Push some common code out of write path into core XFS code for	2006-06-19 08:39:53 +10:00
xfs_sb.h	[XFS] Remove several macros that are no longer used anywhere	2006-09-28 11:02:57 +10:00
xfs_trans_ail.c	[XFS] Workaround log space issue by increasing XFS_TRANS_PUSH_AIL_RESTARTS	2007-02-10 18:35:52 +11:00
xfs_trans_buf.c	[XFS] Remove version 1 directory code. Never functioned on Linux, just	2006-06-20 13:04:51 +10:00
xfs_trans_extfree.c	[XFS] Remove version 1 directory code. Never functioned on Linux, just	2006-06-20 13:04:51 +10:00
xfs_trans_inode.c	[XFS] Remove version 1 directory code. Never functioned on Linux, just	2006-06-20 13:04:51 +10:00
xfs_trans_item.c	[XFS] Portability changes: remove prdev, stick to one diagnostic	2006-06-09 15:29:40 +10:00
xfs_trans_priv.h	[XFS] Add lock annotations to xfs_trans_update_ail and	2006-09-28 11:04:07 +10:00
xfs_trans_space.h	[XFS] Remove version 1 directory code. Never functioned on Linux, just	2006-06-20 13:04:51 +10:00
xfs_trans.c	[XFS] The last argument "lsn" of xfs_trans_commit() is always called with	2007-05-08 13:48:42 +10:00
xfs_trans.h	[XFS] The last argument "lsn" of xfs_trans_commit() is always called with	2007-05-08 13:48:42 +10:00
xfs_types.h
xfs_utils.c	[XFS] propogate return codes from flush routines	2007-05-08 13:49:27 +10:00
xfs_utils.h	[XFS] Resolve a namespace collision on remaining vtypes for FreeBSD	2006-06-09 17:07:12 +10:00
xfs_vfsops.c	[XFS] propogate return codes from flush routines	2007-05-08 13:49:27 +10:00
xfs_vnodeops.c	[XFS] propogate return codes from flush routines	2007-05-08 13:49:27 +10:00
xfs.h	[XFS] 956618: Linux crashes on boot with XFS-DMAPI filesystem when	2006-11-11 18:03:49 +11:00