mirror of
https://mirrors.bfsu.edu.cn/git/linux.git
synced 2024-12-07 19:14:21 +08:00
41d49e7939
When timer_of_init fails, it cleans up after itself by undoing
everything it did during the initialization function.
mtk_syst_init and mtk_gpt_init both call timer_of_cleanup if
timer_of_init fails. timer_of_cleanup try to release the resource
taken. Since these resources have already been cleaned up by
timer_of_init, we end up getting a few warnings printed:
[ 0.001935] WARNING: CPU: 0 PID: 0 at __clk_put+0xe8/0x128
[ 0.002650] Modules linked in:
[ 0.003058] CPU: 0 PID: 0 Comm: swapper/0 Not tainted 4.19.67+ #1
[ 0.003852] Hardware name: MediaTek MT8183 (DT)
[ 0.004446] pstate: 20400085 (nzCv daIf +PAN -UAO)
[ 0.005073] pc : __clk_put+0xe8/0x128
[ 0.005555] lr : clk_put+0xc/0x14
[ 0.005988] sp : ffffff80090b3ea0
[ 0.006422] x29: ffffff80090b3ea0 x28: 0000000040e20018
[ 0.007121] x27: ffffffc07bfff780 x26: 0000000000000001
[ 0.007819] x25: ffffff80090bda80 x24: ffffff8008ec5828
[ 0.008517] x23: ffffff80090bd000 x22: ffffff8008d8b2e8
[ 0.009216] x21: 0000000000000001 x20: fffffffffffffdfb
[ 0.009914] x19: ffffff8009166180 x18: 00000000002bffa8
[ 0.010612] x17: ffffffc012996980 x16: 0000000000000000
[ 0.011311] x15: ffffffbf004a6800 x14: 3536343038393334
[ 0.012009] x13: 2079726576652073 x12: 7eb9c62c5c38f100
[ 0.012707] x11: ffffff80090b3ba0 x10: ffffff80090b3ba0
[ 0.013405] x9 : 0000000000000004 x8 : 0000000000000040
[ 0.014103] x7 : ffffffc079400270 x6 : 0000000000000000
[ 0.014801] x5 : ffffffc079400248 x4 : 0000000000000000
[ 0.015499] x3 : 0000000000000000 x2 : 0000000000000000
[ 0.016197] x1 : ffffff80091661c0 x0 : fffffffffffffdfb
[ 0.016896] Call trace:
[ 0.017218] __clk_put+0xe8/0x128
[ 0.017654] clk_put+0xc/0x14
[ 0.018048] timer_of_cleanup+0x60/0x7c
[ 0.018551] mtk_syst_init+0x8c/0x9c
[ 0.019020] timer_probe+0x6c/0xe0
[ 0.019469] time_init+0x14/0x44
[ 0.019893] start_kernel+0x2d0/0x46c
[ 0.020378] ---[ end trace 8c1efabea1267649 ]---
[ 0.020982] ------------[ cut here ]------------
[ 0.021586] Trying to vfree() nonexistent vm area ((____ptrval____))
[ 0.022427] WARNING: CPU: 0 PID: 0 at __vunmap+0xd0/0xd8
[ 0.023119] Modules linked in:
[ 0.023524] CPU: 0 PID: 0 Comm: swapper/0 Tainted: G W 4.19.67+ #1
[ 0.024498] Hardware name: MediaTek MT8183 (DT)
[ 0.025091] pstate: 60400085 (nZCv daIf +PAN -UAO)
[ 0.025718] pc : __vunmap+0xd0/0xd8
[ 0.026176] lr : __vunmap+0xd0/0xd8
[ 0.026632] sp : ffffff80090b3e90
[ 0.027066] x29: ffffff80090b3e90 x28: 0000000040e20018
[ 0.027764] x27: ffffffc07bfff780 x26: 0000000000000001
[ 0.028462] x25: ffffff80090bda80 x24: ffffff8008ec5828
[ 0.029160] x23: ffffff80090bd000 x22: ffffff8008d8b2e8
[ 0.029858] x21: 0000000000000000 x20: 0000000000000000
[ 0.030556] x19: ffffff800800d000 x18: 00000000002bffa8
[ 0.031254] x17: 0000000000000000 x16: 0000000000000000
[ 0.031952] x15: ffffffbf004a6800 x14: 3536343038393334
[ 0.032651] x13: 2079726576652073 x12: 7eb9c62c5c38f100
[ 0.033349] x11: ffffff80090b3b40 x10: ffffff80090b3b40
[ 0.034047] x9 : 0000000000000005 x8 : 5f5f6c6176727470
[ 0.034745] x7 : 5f5f5f5f28282061 x6 : ffffff80091c86ef
[ 0.035443] x5 : ffffff800852b690 x4 : 0000000000000000
[ 0.036141] x3 : 0000000000000002 x2 : 0000000000000002
[ 0.036839] x1 : 7eb9c62c5c38f100 x0 : 7eb9c62c5c38f100
[ 0.037536] Call trace:
[ 0.037859] __vunmap+0xd0/0xd8
[ 0.038271] vunmap+0x24/0x30
[ 0.038664] __iounmap+0x2c/0x34
[ 0.039088] timer_of_cleanup+0x70/0x7c
[ 0.039591] mtk_syst_init+0x8c/0x9c
[ 0.040060] timer_probe+0x6c/0xe0
[ 0.040507] time_init+0x14/0x44
[ 0.040932] start_kernel+0x2d0/0x46c
This commit remove the calls to timer_of_cleanup when timer_of_init
fails since it is unnecessary and actually cause warnings to be printed.
Fixes: a0858f9379
("mediatek: Convert the driver to timer-of")
Signed-off-by: Fabien Parent <fparent@baylibre.com>
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Link: https://lore.kernel.org/linux-arm-kernel/20190919191315.25190-1-fparent@baylibre.com/
314 lines
8.2 KiB
C
314 lines
8.2 KiB
C
// SPDX-License-Identifier: GPL-2.0-or-later
|
|
/*
|
|
* Mediatek SoCs General-Purpose Timer handling.
|
|
*
|
|
* Copyright (C) 2014 Matthias Brugger
|
|
*
|
|
* Matthias Brugger <matthias.bgg@gmail.com>
|
|
*/
|
|
|
|
#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
|
|
|
|
#include <linux/clockchips.h>
|
|
#include <linux/clocksource.h>
|
|
#include <linux/interrupt.h>
|
|
#include <linux/irqreturn.h>
|
|
#include <linux/sched_clock.h>
|
|
#include <linux/slab.h>
|
|
#include "timer-of.h"
|
|
|
|
#define TIMER_CLK_EVT (1)
|
|
#define TIMER_CLK_SRC (2)
|
|
|
|
#define TIMER_SYNC_TICKS (3)
|
|
|
|
/* gpt */
|
|
#define GPT_IRQ_EN_REG 0x00
|
|
#define GPT_IRQ_ENABLE(val) BIT((val) - 1)
|
|
#define GPT_IRQ_ACK_REG 0x08
|
|
#define GPT_IRQ_ACK(val) BIT((val) - 1)
|
|
|
|
#define GPT_CTRL_REG(val) (0x10 * (val))
|
|
#define GPT_CTRL_OP(val) (((val) & 0x3) << 4)
|
|
#define GPT_CTRL_OP_ONESHOT (0)
|
|
#define GPT_CTRL_OP_REPEAT (1)
|
|
#define GPT_CTRL_OP_FREERUN (3)
|
|
#define GPT_CTRL_CLEAR (2)
|
|
#define GPT_CTRL_ENABLE (1)
|
|
#define GPT_CTRL_DISABLE (0)
|
|
|
|
#define GPT_CLK_REG(val) (0x04 + (0x10 * (val)))
|
|
#define GPT_CLK_SRC(val) (((val) & 0x1) << 4)
|
|
#define GPT_CLK_SRC_SYS13M (0)
|
|
#define GPT_CLK_SRC_RTC32K (1)
|
|
#define GPT_CLK_DIV1 (0x0)
|
|
#define GPT_CLK_DIV2 (0x1)
|
|
|
|
#define GPT_CNT_REG(val) (0x08 + (0x10 * (val)))
|
|
#define GPT_CMP_REG(val) (0x0C + (0x10 * (val)))
|
|
|
|
/* system timer */
|
|
#define SYST_BASE (0x40)
|
|
|
|
#define SYST_CON (SYST_BASE + 0x0)
|
|
#define SYST_VAL (SYST_BASE + 0x4)
|
|
|
|
#define SYST_CON_REG(to) (timer_of_base(to) + SYST_CON)
|
|
#define SYST_VAL_REG(to) (timer_of_base(to) + SYST_VAL)
|
|
|
|
/*
|
|
* SYST_CON_EN: Clock enable. Shall be set to
|
|
* - Start timer countdown.
|
|
* - Allow timeout ticks being updated.
|
|
* - Allow changing interrupt functions.
|
|
*
|
|
* SYST_CON_IRQ_EN: Set to allow interrupt.
|
|
*
|
|
* SYST_CON_IRQ_CLR: Set to clear interrupt.
|
|
*/
|
|
#define SYST_CON_EN BIT(0)
|
|
#define SYST_CON_IRQ_EN BIT(1)
|
|
#define SYST_CON_IRQ_CLR BIT(4)
|
|
|
|
static void __iomem *gpt_sched_reg __read_mostly;
|
|
|
|
static void mtk_syst_ack_irq(struct timer_of *to)
|
|
{
|
|
/* Clear and disable interrupt */
|
|
writel(SYST_CON_IRQ_CLR | SYST_CON_EN, SYST_CON_REG(to));
|
|
}
|
|
|
|
static irqreturn_t mtk_syst_handler(int irq, void *dev_id)
|
|
{
|
|
struct clock_event_device *clkevt = dev_id;
|
|
struct timer_of *to = to_timer_of(clkevt);
|
|
|
|
mtk_syst_ack_irq(to);
|
|
clkevt->event_handler(clkevt);
|
|
|
|
return IRQ_HANDLED;
|
|
}
|
|
|
|
static int mtk_syst_clkevt_next_event(unsigned long ticks,
|
|
struct clock_event_device *clkevt)
|
|
{
|
|
struct timer_of *to = to_timer_of(clkevt);
|
|
|
|
/* Enable clock to allow timeout tick update later */
|
|
writel(SYST_CON_EN, SYST_CON_REG(to));
|
|
|
|
/*
|
|
* Write new timeout ticks. Timer shall start countdown
|
|
* after timeout ticks are updated.
|
|
*/
|
|
writel(ticks, SYST_VAL_REG(to));
|
|
|
|
/* Enable interrupt */
|
|
writel(SYST_CON_EN | SYST_CON_IRQ_EN, SYST_CON_REG(to));
|
|
|
|
return 0;
|
|
}
|
|
|
|
static int mtk_syst_clkevt_shutdown(struct clock_event_device *clkevt)
|
|
{
|
|
/* Disable timer */
|
|
writel(0, SYST_CON_REG(to_timer_of(clkevt)));
|
|
|
|
return 0;
|
|
}
|
|
|
|
static int mtk_syst_clkevt_resume(struct clock_event_device *clkevt)
|
|
{
|
|
return mtk_syst_clkevt_shutdown(clkevt);
|
|
}
|
|
|
|
static int mtk_syst_clkevt_oneshot(struct clock_event_device *clkevt)
|
|
{
|
|
return 0;
|
|
}
|
|
|
|
static u64 notrace mtk_gpt_read_sched_clock(void)
|
|
{
|
|
return readl_relaxed(gpt_sched_reg);
|
|
}
|
|
|
|
static void mtk_gpt_clkevt_time_stop(struct timer_of *to, u8 timer)
|
|
{
|
|
u32 val;
|
|
|
|
val = readl(timer_of_base(to) + GPT_CTRL_REG(timer));
|
|
writel(val & ~GPT_CTRL_ENABLE, timer_of_base(to) +
|
|
GPT_CTRL_REG(timer));
|
|
}
|
|
|
|
static void mtk_gpt_clkevt_time_setup(struct timer_of *to,
|
|
unsigned long delay, u8 timer)
|
|
{
|
|
writel(delay, timer_of_base(to) + GPT_CMP_REG(timer));
|
|
}
|
|
|
|
static void mtk_gpt_clkevt_time_start(struct timer_of *to,
|
|
bool periodic, u8 timer)
|
|
{
|
|
u32 val;
|
|
|
|
/* Acknowledge interrupt */
|
|
writel(GPT_IRQ_ACK(timer), timer_of_base(to) + GPT_IRQ_ACK_REG);
|
|
|
|
val = readl(timer_of_base(to) + GPT_CTRL_REG(timer));
|
|
|
|
/* Clear 2 bit timer operation mode field */
|
|
val &= ~GPT_CTRL_OP(0x3);
|
|
|
|
if (periodic)
|
|
val |= GPT_CTRL_OP(GPT_CTRL_OP_REPEAT);
|
|
else
|
|
val |= GPT_CTRL_OP(GPT_CTRL_OP_ONESHOT);
|
|
|
|
writel(val | GPT_CTRL_ENABLE | GPT_CTRL_CLEAR,
|
|
timer_of_base(to) + GPT_CTRL_REG(timer));
|
|
}
|
|
|
|
static int mtk_gpt_clkevt_shutdown(struct clock_event_device *clk)
|
|
{
|
|
mtk_gpt_clkevt_time_stop(to_timer_of(clk), TIMER_CLK_EVT);
|
|
|
|
return 0;
|
|
}
|
|
|
|
static int mtk_gpt_clkevt_set_periodic(struct clock_event_device *clk)
|
|
{
|
|
struct timer_of *to = to_timer_of(clk);
|
|
|
|
mtk_gpt_clkevt_time_stop(to, TIMER_CLK_EVT);
|
|
mtk_gpt_clkevt_time_setup(to, to->of_clk.period, TIMER_CLK_EVT);
|
|
mtk_gpt_clkevt_time_start(to, true, TIMER_CLK_EVT);
|
|
|
|
return 0;
|
|
}
|
|
|
|
static int mtk_gpt_clkevt_next_event(unsigned long event,
|
|
struct clock_event_device *clk)
|
|
{
|
|
struct timer_of *to = to_timer_of(clk);
|
|
|
|
mtk_gpt_clkevt_time_stop(to, TIMER_CLK_EVT);
|
|
mtk_gpt_clkevt_time_setup(to, event, TIMER_CLK_EVT);
|
|
mtk_gpt_clkevt_time_start(to, false, TIMER_CLK_EVT);
|
|
|
|
return 0;
|
|
}
|
|
|
|
static irqreturn_t mtk_gpt_interrupt(int irq, void *dev_id)
|
|
{
|
|
struct clock_event_device *clkevt = (struct clock_event_device *)dev_id;
|
|
struct timer_of *to = to_timer_of(clkevt);
|
|
|
|
/* Acknowledge timer0 irq */
|
|
writel(GPT_IRQ_ACK(TIMER_CLK_EVT), timer_of_base(to) + GPT_IRQ_ACK_REG);
|
|
clkevt->event_handler(clkevt);
|
|
|
|
return IRQ_HANDLED;
|
|
}
|
|
|
|
static void
|
|
__init mtk_gpt_setup(struct timer_of *to, u8 timer, u8 option)
|
|
{
|
|
writel(GPT_CTRL_CLEAR | GPT_CTRL_DISABLE,
|
|
timer_of_base(to) + GPT_CTRL_REG(timer));
|
|
|
|
writel(GPT_CLK_SRC(GPT_CLK_SRC_SYS13M) | GPT_CLK_DIV1,
|
|
timer_of_base(to) + GPT_CLK_REG(timer));
|
|
|
|
writel(0x0, timer_of_base(to) + GPT_CMP_REG(timer));
|
|
|
|
writel(GPT_CTRL_OP(option) | GPT_CTRL_ENABLE,
|
|
timer_of_base(to) + GPT_CTRL_REG(timer));
|
|
}
|
|
|
|
static void mtk_gpt_enable_irq(struct timer_of *to, u8 timer)
|
|
{
|
|
u32 val;
|
|
|
|
/* Disable all interrupts */
|
|
writel(0x0, timer_of_base(to) + GPT_IRQ_EN_REG);
|
|
|
|
/* Acknowledge all spurious pending interrupts */
|
|
writel(0x3f, timer_of_base(to) + GPT_IRQ_ACK_REG);
|
|
|
|
val = readl(timer_of_base(to) + GPT_IRQ_EN_REG);
|
|
writel(val | GPT_IRQ_ENABLE(timer),
|
|
timer_of_base(to) + GPT_IRQ_EN_REG);
|
|
}
|
|
|
|
static struct timer_of to = {
|
|
.flags = TIMER_OF_IRQ | TIMER_OF_BASE | TIMER_OF_CLOCK,
|
|
|
|
.clkevt = {
|
|
.name = "mtk-clkevt",
|
|
.rating = 300,
|
|
.cpumask = cpu_possible_mask,
|
|
},
|
|
|
|
.of_irq = {
|
|
.flags = IRQF_TIMER | IRQF_IRQPOLL,
|
|
},
|
|
};
|
|
|
|
static int __init mtk_syst_init(struct device_node *node)
|
|
{
|
|
int ret;
|
|
|
|
to.clkevt.features = CLOCK_EVT_FEAT_DYNIRQ | CLOCK_EVT_FEAT_ONESHOT;
|
|
to.clkevt.set_state_shutdown = mtk_syst_clkevt_shutdown;
|
|
to.clkevt.set_state_oneshot = mtk_syst_clkevt_oneshot;
|
|
to.clkevt.tick_resume = mtk_syst_clkevt_resume;
|
|
to.clkevt.set_next_event = mtk_syst_clkevt_next_event;
|
|
to.of_irq.handler = mtk_syst_handler;
|
|
|
|
ret = timer_of_init(node, &to);
|
|
if (ret)
|
|
return ret;
|
|
|
|
clockevents_config_and_register(&to.clkevt, timer_of_rate(&to),
|
|
TIMER_SYNC_TICKS, 0xffffffff);
|
|
|
|
return 0;
|
|
}
|
|
|
|
static int __init mtk_gpt_init(struct device_node *node)
|
|
{
|
|
int ret;
|
|
|
|
to.clkevt.features = CLOCK_EVT_FEAT_PERIODIC | CLOCK_EVT_FEAT_ONESHOT;
|
|
to.clkevt.set_state_shutdown = mtk_gpt_clkevt_shutdown;
|
|
to.clkevt.set_state_periodic = mtk_gpt_clkevt_set_periodic;
|
|
to.clkevt.set_state_oneshot = mtk_gpt_clkevt_shutdown;
|
|
to.clkevt.tick_resume = mtk_gpt_clkevt_shutdown;
|
|
to.clkevt.set_next_event = mtk_gpt_clkevt_next_event;
|
|
to.of_irq.handler = mtk_gpt_interrupt;
|
|
|
|
ret = timer_of_init(node, &to);
|
|
if (ret)
|
|
return ret;
|
|
|
|
/* Configure clock source */
|
|
mtk_gpt_setup(&to, TIMER_CLK_SRC, GPT_CTRL_OP_FREERUN);
|
|
clocksource_mmio_init(timer_of_base(&to) + GPT_CNT_REG(TIMER_CLK_SRC),
|
|
node->name, timer_of_rate(&to), 300, 32,
|
|
clocksource_mmio_readl_up);
|
|
gpt_sched_reg = timer_of_base(&to) + GPT_CNT_REG(TIMER_CLK_SRC);
|
|
sched_clock_register(mtk_gpt_read_sched_clock, 32, timer_of_rate(&to));
|
|
|
|
/* Configure clock event */
|
|
mtk_gpt_setup(&to, TIMER_CLK_EVT, GPT_CTRL_OP_REPEAT);
|
|
clockevents_config_and_register(&to.clkevt, timer_of_rate(&to),
|
|
TIMER_SYNC_TICKS, 0xffffffff);
|
|
|
|
mtk_gpt_enable_irq(&to, TIMER_CLK_EVT);
|
|
|
|
return 0;
|
|
}
|
|
TIMER_OF_DECLARE(mtk_mt6577, "mediatek,mt6577-timer", mtk_gpt_init);
|
|
TIMER_OF_DECLARE(mtk_mt6765, "mediatek,mt6765-timer", mtk_syst_init);
|