Dan Carpenter 31976c68be netdevsim: fix uninitialized data in nsim_dev_trap_fa_cookie_write() ... [ Upstream commit f72207a5c0 ] The simple_write_to_buffer() function is designed to handle partial writes. It returns negatives on error, otherwise it returns the number of bytes that were able to be copied. This code doesn't check the return properly. We only know that the first byte is written, the rest of the buffer might be uninitialized. There is no need to use the simple_write_to_buffer() function. Partial writes are prohibited by the "if (*ppos != 0)" check at the start of the function. Just use memdup_user() and copy the whole buffer. Fixes: d3cbb907ae ("netdevsim: add ACL trap reporting cookie as a metadata") Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> Reviewed-by: Pavan Chebbi <pavan.chebbi@broadcom.com> Reviewed-by: Ido Schimmel <idosch@nvidia.com> Link: https://lore.kernel.org/r/7c1f950b-3a7d-4252-82a6-876e53078ef7@moroto.mountain Signed-off-by: Jakub Kicinski <kuba@kernel.org> Signed-off-by: Sasha Levin <sashal@kernel.org>		2023-07-23 13:47:45 +02:00
..
bpf.c	netdevsim: Avoid allocation warnings triggered from user space	2022-08-17 14:23:36 +02:00
bus.c
dev.c	netdevsim: fix uninitialized data in nsim_dev_trap_fa_cookie_write()	2023-07-23 13:47:45 +02:00
ethtool.c
fib.c	netdevsim: fib: Fix reference count leak on route deletion failure	2022-08-17 14:23:36 +02:00
health.c
ipsec.c
Makefile
netdev.c	net: Use u64_stats_fetch_begin_irq() for stats fetch.	2022-09-08 12:28:07 +02:00
netdevsim.h
psample.c
udp_tunnels.c