mirror of
https://mirrors.bfsu.edu.cn/git/linux.git
synced 2024-12-29 14:05:19 +08:00
284d96a494
Currently the radix tree test suite doesn't build with toolchains that use --as-needed by default, for example Ubuntu's: cc -I. -I../../include -g -O2 -Wall -D_LGPL_SOURCE -fsanitize=address -lpthread -lurcu main.o ... -o main /usr/bin/ld: regression1.o: undefined reference to symbol 'pthread_join@@GLIBC_2.17' /lib/powerpc64le-linux-gnu/libpthread.so.0: error adding symbols: DSO missing from command line collect2: error: ld returned 1 exit status This is caused by the custom makefile rules placing LDFLAGS before the .o files that need the libraries. We could fix it by using --no-as-needed, or rewriting the custom rules. But we can also just drop the custom rules and move the libraries to LDLIBS, and then the default rules work correctly - with the one caveat that we need to add -fsanitize=address to LDFLAGS because that must be passed to the linker as well as the compiler. Signed-off-by: Michael Ellerman <mpe@ellerman.id.au> Signed-off-by: Matthew Wilcox <mawilcox@microsoft.com>
50 lines
1.2 KiB
Makefile
50 lines
1.2 KiB
Makefile
|
|
CFLAGS += -I. -I../../include -g -O2 -Wall -D_LGPL_SOURCE -fsanitize=address
|
|
LDFLAGS += -fsanitize=address
|
|
LDLIBS+= -lpthread -lurcu
|
|
TARGETS = main idr-test multiorder
|
|
CORE_OFILES := radix-tree.o idr.o linux.o test.o find_bit.o
|
|
OFILES = main.o $(CORE_OFILES) regression1.o regression2.o regression3.o \
|
|
tag_check.o multiorder.o idr-test.o iteration_check.o benchmark.o
|
|
|
|
ifndef SHIFT
|
|
SHIFT=3
|
|
endif
|
|
|
|
ifeq ($(BUILD), 32)
|
|
CFLAGS += -m32
|
|
endif
|
|
|
|
targets: mapshift $(TARGETS)
|
|
|
|
main: $(OFILES)
|
|
|
|
idr-test: idr-test.o $(CORE_OFILES)
|
|
|
|
multiorder: multiorder.o $(CORE_OFILES)
|
|
|
|
clean:
|
|
$(RM) $(TARGETS) *.o radix-tree.c idr.c generated/map-shift.h
|
|
|
|
vpath %.c ../../lib
|
|
|
|
$(OFILES): *.h */*.h generated/map-shift.h \
|
|
../../include/linux/*.h \
|
|
../../include/asm/*.h \
|
|
../../../include/linux/radix-tree.h \
|
|
../../../include/linux/idr.h
|
|
|
|
radix-tree.c: ../../../lib/radix-tree.c
|
|
sed -e 's/^static //' -e 's/__always_inline //' -e 's/inline //' < $< > $@
|
|
|
|
idr.c: ../../../lib/idr.c
|
|
sed -e 's/^static //' -e 's/__always_inline //' -e 's/inline //' < $< > $@
|
|
|
|
.PHONY: mapshift
|
|
|
|
mapshift:
|
|
@if ! grep -qw $(SHIFT) generated/map-shift.h; then \
|
|
echo "#define RADIX_TREE_MAP_SHIFT $(SHIFT)" > \
|
|
generated/map-shift.h; \
|
|
fi
|