Osama Muhammad 27e56f59ba UBSAN: array-index-out-of-bounds in dtSplitRoot ... Syzkaller reported the following issue: oop0: detected capacity change from 0 to 32768 UBSAN: array-index-out-of-bounds in fs/jfs/jfs_dtree.c:1971:9 index -2 is out of range for type 'struct dtslot [128]' CPU: 0 PID: 3613 Comm: syz-executor270 Not tainted 6.0.0-syzkaller-09423-g493ffd6605b2 #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 09/22/2022 Call Trace: <TASK> __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0x1b1/0x28e lib/dump_stack.c:106 ubsan_epilogue lib/ubsan.c:151 [inline] __ubsan_handle_out_of_bounds+0xdb/0x130 lib/ubsan.c:283 dtSplitRoot+0x8d8/0x1900 fs/jfs/jfs_dtree.c:1971 dtSplitUp fs/jfs/jfs_dtree.c:985 [inline] dtInsert+0x1189/0x6b80 fs/jfs/jfs_dtree.c:863 jfs_mkdir+0x757/0xb00 fs/jfs/namei.c:270 vfs_mkdir+0x3b3/0x590 fs/namei.c:4013 do_mkdirat+0x279/0x550 fs/namei.c:4038 __do_sys_mkdirat fs/namei.c:4053 [inline] __se_sys_mkdirat fs/namei.c:4051 [inline] __x64_sys_mkdirat+0x85/0x90 fs/namei.c:4051 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x3d/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd RIP: 0033:0x7fcdc0113fd9 Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 c0 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007ffeb8bc67d8 EFLAGS: 00000246 ORIG_RAX: 0000000000000102 RAX: ffffffffffffffda RBX: 0000000000000000 RCX: 00007fcdc0113fd9 RDX: 0000000000000000 RSI: 0000000020000340 RDI: 0000000000000003 RBP: 00007fcdc00d37a0 R08: 0000000000000000 R09: 00007fcdc00d37a0 R10: 00005555559a72c0 R11: 0000000000000246 R12: 00000000f8008000 R13: 0000000000000000 R14: 00083878000000f8 R15: 0000000000000000 </TASK> The issue is caused when the value of fsi becomes less than -1. The check to break the loop when fsi value becomes -1 is present but syzbot was able to produce value less than -1 which cause the error. This patch simply add the change for the values less than 0. The patch is tested via syzbot. Reported-and-tested-by: syzbot+d4b1df2e9d4ded6488ec@syzkaller.appspotmail.com Link: https://syzkaller.appspot.com/bug?extid=d4b1df2e9d4ded6488ec Signed-off-by: Osama Muhammad <osmtendev@gmail.com> Signed-off-by: Dave Kleikamp <dave.kleikamp@oracle.com>		2023-11-21 15:26:33 -06:00
..
acl.c	jfs: convert to ctime accessor functions	2023-07-24 10:30:01 +02:00
file.c	splice: Use filemap_splice_read() instead of generic_file_splice_read()	2023-05-24 08:42:17 -06:00
inode.c	jfs: convert to new timestamp accessors	2023-10-18 14:08:23 +02:00
ioctl.c	jfs: convert to ctime accessor functions	2023-07-24 10:30:01 +02:00
jfs_acl.h	fs: port ->set_acl() to pass mnt_idmap	2023-01-19 09:24:27 +01:00
jfs_btree.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 156	2019-05-30 11:26:35 -07:00
jfs_debug.c	proc: convert everything to "struct proc_ops"	2020-02-04 03:05:26 +00:00
jfs_debug.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 156	2019-05-30 11:26:35 -07:00
jfs_dinode.h	jfs: define xtree root and page independently	2023-10-13 10:39:25 -05:00
jfs_discard.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 156	2019-05-30 11:26:35 -07:00
jfs_discard.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 156	2019-05-30 11:26:35 -07:00
jfs_dmap.c	FS:JFS:UBSAN:array-index-out-of-bounds in dbAdjTree	2023-11-21 15:26:33 -06:00
jfs_dmap.h	jfs: Fix array index bounds check in dbAdjTree	2020-11-13 16:03:07 -06:00
jfs_dtree.c	UBSAN: array-index-out-of-bounds in dtSplitRoot	2023-11-21 15:26:33 -06:00
jfs_dtree.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 156	2019-05-30 11:26:35 -07:00
jfs_extent.c	jfs: validate max amount of blocks before allocation.	2023-08-29 12:25:47 -05:00
jfs_extent.h	jfs: remove unused declarations for jfs	2022-10-18 08:50:26 -05:00
jfs_filsys.h	jfs: jfs_dmap: Validate db_l2nbperpage while mounting	2023-06-20 12:37:50 -05:00
jfs_imap.c	Minor stability improvements	2023-11-02 08:08:28 -10:00
jfs_imap.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 156	2019-05-30 11:26:35 -07:00
jfs_incore.h	jfs: define xtree root and page independently	2023-10-13 10:39:25 -05:00
jfs_inode.c	jfs: convert to new timestamp accessors	2023-10-18 14:08:23 +02:00
jfs_inode.h	fs: port ->fileattr_set() to pass mnt_idmap	2023-01-19 09:24:27 +01:00
jfs_lock.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 156	2019-05-30 11:26:35 -07:00
jfs_logmgr.c	jfs: fix log->bdev_handle null ptr deref in lbmStartIO	2023-10-28 13:29:22 +02:00
jfs_logmgr.h	jfs: Convert to bdev_open_by_dev()	2023-10-28 13:29:21 +02:00
jfs_metapage.c	mm,jfs: move write_one_page/folio_write_one to jfs	2023-03-12 20:00:42 -04:00
jfs_metapage.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 156	2019-05-30 11:26:35 -07:00
jfs_mount.c	jfs: Convert to bdev_open_by_dev()	2023-10-28 13:29:21 +02:00
jfs_superblock.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 156	2019-05-30 11:26:35 -07:00
jfs_txnmgr.c	jfs: define xtree root and page independently	2023-10-13 10:39:25 -05:00
jfs_txnmgr.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 156	2019-05-30 11:26:35 -07:00
jfs_types.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 156	2019-05-30 11:26:35 -07:00
jfs_umount.c	jfs: Fix a typo in function jfs_umount	2022-11-10 15:08:00 -06:00
jfs_unicode.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 156	2019-05-30 11:26:35 -07:00
jfs_unicode.h	fs/jfs: Use common ucs2 upper case table	2023-08-30 08:55:52 -05:00
jfs_xattr.h	jfs: move jfs_xattr_handlers to .rodata	2023-10-09 16:24:19 +02:00
jfs_xtree.c	jfs: define xtree root and page independently	2023-10-13 10:39:25 -05:00
jfs_xtree.h	jfs: define xtree root and page independently	2023-10-13 10:39:25 -05:00
Kconfig	22 smb3/cifs client fixes and two related changes (for unicode mapping)	2023-08-30 21:01:40 -07:00
Makefile	fs/jfs: Use common ucs2 upper case table	2023-08-30 08:55:52 -05:00
namei.c	jfs: convert to new timestamp accessors	2023-10-18 14:08:23 +02:00
resize.c	jfs: use sb_bdev_nr_blocks	2021-10-18 14:43:23 -06:00
super.c	vfs-6.7.fsid	2023-11-07 12:11:26 -08:00
symlink.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 156	2019-05-30 11:26:35 -07:00
xattr.c	jfs: move jfs_xattr_handlers to .rodata	2023-10-09 16:24:19 +02:00