linux/sound/pci/ice1712
Dmitry Fomin ff9657b1e8 ALSA: ice1712: Do not left ice->gpio_mutex locked in aureon_add_controls()
commit 951606a14a upstream.

If snd_ctl_add() fails in aureon_add_controls(), it immediately returns
and leaves ice->gpio_mutex locked. ice->gpio_mutex locks in
snd_ice1712_save_gpio_status and unlocks in
snd_ice1712_restore_gpio_status(ice).

It seems that the mutex is required only for aureon_cs8415_get(),
so snd_ice1712_restore_gpio_status(ice) can be placed
just after that. Compile tested only.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Fixes: 1da177e4c3 ("Linux-2.6.12-rc2")
Signed-off-by: Dmitry Fomin <fomindmitriyfoma@mail.ru>
Cc: <stable@vger.kernel.org>
Link: https://lore.kernel.org/r/20230225184322.6286-1-fomindmitriyfoma@mail.ru
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2023-03-10 09:40:04 +01:00
..
ak4xxx.c treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 156 2019-05-30 11:26:35 -07:00
amp.c treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 156 2019-05-30 11:26:35 -07:00
amp.h treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 156 2019-05-30 11:26:35 -07:00
aureon.c ALSA: ice1712: Do not left ice->gpio_mutex locked in aureon_add_controls() 2023-03-10 09:40:04 +01:00
aureon.h treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 156 2019-05-30 11:26:35 -07:00
delta.c ALSA: ice1712: Fix assignment in if condition 2021-06-09 17:30:14 +02:00
delta.h treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 156 2019-05-30 11:26:35 -07:00
envy24ht.h treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 156 2019-05-30 11:26:35 -07:00
ews.c ALSA: ice1712: Fix assignment in if condition 2021-06-09 17:30:14 +02:00
ews.h treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 156 2019-05-30 11:26:35 -07:00
hoontech.c treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 156 2019-05-30 11:26:35 -07:00
hoontech.h treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 156 2019-05-30 11:26:35 -07:00
ice1712.c ALSA: ice1712: Allocate resources with device-managed APIs 2021-07-19 16:16:58 +02:00
ice1712.h ALSA: ice17xx: Constify snd_ice1712_card_info 2020-01-03 09:24:39 +01:00
ice1724.c ALSA: ice1724: Fix the missing snd_card_free() call at probe error 2022-04-20 09:34:07 +02:00
juli.c ALSA: Convert strlcpy to strscpy when return value is unused 2021-01-08 09:30:05 +01:00
juli.h
Makefile
maya44.c ALSA: ice1712: More constifications 2020-01-05 16:14:41 +01:00
maya44.h
phase.c ALSA: ice1712: More constifications 2020-01-05 16:14:41 +01:00
phase.h treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 156 2019-05-30 11:26:35 -07:00
pontis.c ALSA: ice1712: More constifications 2020-01-05 16:14:41 +01:00
pontis.h treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 156 2019-05-30 11:26:35 -07:00
prodigy192.c ALSA: pci: delete repeated words in comments 2020-08-06 09:30:02 +02:00
prodigy192.h
prodigy_hifi.c ALSA: ice1724: Fix invalid access for enumerated ctl items 2020-04-07 16:43:46 +02:00
prodigy_hifi.h treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 156 2019-05-30 11:26:35 -07:00
psc724.c ALSA: Convert strlcpy to strscpy when return value is unused 2021-01-08 09:30:05 +01:00
psc724.h
quartet.c ALSA: Convert strlcpy to strscpy when return value is unused 2021-01-08 09:30:05 +01:00
quartet.h
revo.c treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 156 2019-05-30 11:26:35 -07:00
revo.h treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 156 2019-05-30 11:26:35 -07:00
se.c ALSA: ice1712: More constifications 2020-01-05 16:14:41 +01:00
se.h
stac946x.h
vt1720_mobo.c ALSA: ice1712: More constifications 2020-01-05 16:14:41 +01:00
vt1720_mobo.h treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 156 2019-05-30 11:26:35 -07:00
wm8766.c ALSA: ice1712: Constify wm-specific tables 2020-01-03 09:24:39 +01:00
wm8766.h treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 156 2019-05-30 11:26:35 -07:00
wm8776.c ALSA: Convert strlcpy to strscpy when return value is unused 2021-01-08 09:30:05 +01:00
wm8776.h treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 156 2019-05-30 11:26:35 -07:00
wtm.c ALSA: ice1712: More constifications 2020-01-05 16:14:41 +01:00
wtm.h