mirror of
https://mirrors.bfsu.edu.cn/git/linux.git
synced 2024-11-17 01:04:19 +08:00
5a0e3ad6af
percpu.h is included by sched.h and module.h and thus ends up being included when building most .c files. percpu.h includes slab.h which in turn includes gfp.h making everything defined by the two files universally available and complicating inclusion dependencies. percpu.h -> slab.h dependency is about to be removed. Prepare for this change by updating users of gfp and slab facilities include those headers directly instead of assuming availability. As this conversion needs to touch large number of source files, the following script is used as the basis of conversion. http://userweb.kernel.org/~tj/misc/slabh-sweep.py The script does the followings. * Scan files for gfp and slab usages and update includes such that only the necessary includes are there. ie. if only gfp is used, gfp.h, if slab is used, slab.h. * When the script inserts a new include, it looks at the include blocks and try to put the new include such that its order conforms to its surrounding. It's put in the include block which contains core kernel includes, in the same order that the rest are ordered - alphabetical, Christmas tree, rev-Xmas-tree or at the end if there doesn't seem to be any matching order. * If the script can't find a place to put a new include (mostly because the file doesn't have fitting include block), it prints out an error message indicating which .h file needs to be added to the file. The conversion was done in the following steps. 1. The initial automatic conversion of all .c files updated slightly over 4000 files, deleting around 700 includes and adding ~480 gfp.h and ~3000 slab.h inclusions. The script emitted errors for ~400 files. 2. Each error was manually checked. Some didn't need the inclusion, some needed manual addition while adding it to implementation .h or embedding .c file was more appropriate for others. This step added inclusions to around 150 files. 3. The script was run again and the output was compared to the edits from #2 to make sure no file was left behind. 4. Several build tests were done and a couple of problems were fixed. e.g. lib/decompress_*.c used malloc/free() wrappers around slab APIs requiring slab.h to be added manually. 5. The script was run on all .h files but without automatically editing them as sprinkling gfp.h and slab.h inclusions around .h files could easily lead to inclusion dependency hell. Most gfp.h inclusion directives were ignored as stuff from gfp.h was usually wildly available and often used in preprocessor macros. Each slab.h inclusion directive was examined and added manually as necessary. 6. percpu.h was updated not to include slab.h. 7. Build test were done on the following configurations and failures were fixed. CONFIG_GCOV_KERNEL was turned off for all tests (as my distributed build env didn't work with gcov compiles) and a few more options had to be turned off depending on archs to make things build (like ipr on powerpc/64 which failed due to missing writeq). * x86 and x86_64 UP and SMP allmodconfig and a custom test config. * powerpc and powerpc64 SMP allmodconfig * sparc and sparc64 SMP allmodconfig * ia64 SMP allmodconfig * s390 SMP allmodconfig * alpha SMP allmodconfig * um on x86_64 SMP allmodconfig 8. percpu.h modifications were reverted so that it could be applied as a separate patch and serve as bisection point. Given the fact that I had only a couple of failures from tests on step 6, I'm fairly confident about the coverage of this conversion patch. If there is a breakage, it's likely to be something in one of the arch headers which should be easily discoverable easily on most builds of the specific arch. Signed-off-by: Tejun Heo <tj@kernel.org> Guess-its-ok-by: Christoph Lameter <cl@linux-foundation.org> Cc: Ingo Molnar <mingo@redhat.com> Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>
134 lines
3.5 KiB
C
134 lines
3.5 KiB
C
/* SCTP kernel implementation
|
|
* Copyright (c) 2003 International Business Machines, Corp.
|
|
*
|
|
* This file is part of the SCTP kernel implementation
|
|
*
|
|
* These functions manipulate sctp SSN tracker.
|
|
*
|
|
* This SCTP implementation is free software;
|
|
* you can redistribute it and/or modify it under the terms of
|
|
* the GNU General Public License as published by
|
|
* the Free Software Foundation; either version 2, or (at your option)
|
|
* any later version.
|
|
*
|
|
* This SCTP implementation is distributed in the hope that it
|
|
* will be useful, but WITHOUT ANY WARRANTY; without even the implied
|
|
* ************************
|
|
* warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
|
|
* See the GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with GNU CC; see the file COPYING. If not, write to
|
|
* the Free Software Foundation, 59 Temple Place - Suite 330,
|
|
* Boston, MA 02111-1307, USA.
|
|
*
|
|
* Please send any bug reports or fixes you make to the
|
|
* email address(es):
|
|
* lksctp developers <lksctp-developers@lists.sourceforge.net>
|
|
*
|
|
* Or submit a bug report through the following website:
|
|
* http://www.sf.net/projects/lksctp
|
|
*
|
|
* Written or modified by:
|
|
* Jon Grimm <jgrimm@us.ibm.com>
|
|
*
|
|
* Any bugs reported given to us we will try to fix... any fixes shared will
|
|
* be incorporated into the next SCTP release.
|
|
*/
|
|
|
|
#include <linux/types.h>
|
|
#include <linux/slab.h>
|
|
#include <net/sctp/sctp.h>
|
|
#include <net/sctp/sm.h>
|
|
|
|
#define MAX_KMALLOC_SIZE 131072
|
|
|
|
static struct sctp_ssnmap *sctp_ssnmap_init(struct sctp_ssnmap *map, __u16 in,
|
|
__u16 out);
|
|
|
|
/* Storage size needed for map includes 2 headers and then the
|
|
* specific needs of in or out streams.
|
|
*/
|
|
static inline size_t sctp_ssnmap_size(__u16 in, __u16 out)
|
|
{
|
|
return sizeof(struct sctp_ssnmap) + (in + out) * sizeof(__u16);
|
|
}
|
|
|
|
|
|
/* Create a new sctp_ssnmap.
|
|
* Allocate room to store at least 'len' contiguous TSNs.
|
|
*/
|
|
struct sctp_ssnmap *sctp_ssnmap_new(__u16 in, __u16 out,
|
|
gfp_t gfp)
|
|
{
|
|
struct sctp_ssnmap *retval;
|
|
int size;
|
|
|
|
size = sctp_ssnmap_size(in, out);
|
|
if (size <= MAX_KMALLOC_SIZE)
|
|
retval = kmalloc(size, gfp);
|
|
else
|
|
retval = (struct sctp_ssnmap *)
|
|
__get_free_pages(gfp, get_order(size));
|
|
if (!retval)
|
|
goto fail;
|
|
|
|
if (!sctp_ssnmap_init(retval, in, out))
|
|
goto fail_map;
|
|
|
|
retval->malloced = 1;
|
|
SCTP_DBG_OBJCNT_INC(ssnmap);
|
|
|
|
return retval;
|
|
|
|
fail_map:
|
|
if (size <= MAX_KMALLOC_SIZE)
|
|
kfree(retval);
|
|
else
|
|
free_pages((unsigned long)retval, get_order(size));
|
|
fail:
|
|
return NULL;
|
|
}
|
|
|
|
|
|
/* Initialize a block of memory as a ssnmap. */
|
|
static struct sctp_ssnmap *sctp_ssnmap_init(struct sctp_ssnmap *map, __u16 in,
|
|
__u16 out)
|
|
{
|
|
memset(map, 0x00, sctp_ssnmap_size(in, out));
|
|
|
|
/* Start 'in' stream just after the map header. */
|
|
map->in.ssn = (__u16 *)&map[1];
|
|
map->in.len = in;
|
|
|
|
/* Start 'out' stream just after 'in'. */
|
|
map->out.ssn = &map->in.ssn[in];
|
|
map->out.len = out;
|
|
|
|
return map;
|
|
}
|
|
|
|
/* Clear out the ssnmap streams. */
|
|
void sctp_ssnmap_clear(struct sctp_ssnmap *map)
|
|
{
|
|
size_t size;
|
|
|
|
size = (map->in.len + map->out.len) * sizeof(__u16);
|
|
memset(map->in.ssn, 0x00, size);
|
|
}
|
|
|
|
/* Dispose of a ssnmap. */
|
|
void sctp_ssnmap_free(struct sctp_ssnmap *map)
|
|
{
|
|
if (map && map->malloced) {
|
|
int size;
|
|
|
|
size = sctp_ssnmap_size(map->in.len, map->out.len);
|
|
if (size <= MAX_KMALLOC_SIZE)
|
|
kfree(map);
|
|
else
|
|
free_pages((unsigned long)map, get_order(size));
|
|
SCTP_DBG_OBJCNT_DEC(ssnmap);
|
|
}
|
|
}
|