linux/fs/ecryptfs
Michael Halcrow 22e78fafbd eCryptfs: kerneldoc fixes for crypto.c and keystore.c
Andrew Morton wrote:
From: mhalcrow@us.ibm.com <mhalcrow@halcrow.austin.ibm.com>
> > +/**
> > + * decrypt_passphrase_encrypted_session_key - Decrypt the session key
> > + * with the given auth_tok.
> >   *
> >   * Returns Zero on success; non-zero error otherwise.
> >   */
>
> That comment purports to be a kerneldoc-style comment.  But
>
> - kerneldoc doesn't support multiple lines on the introductory line
>   which identifies the name of the function (alas).  So you'll need to
>   overflow 80 cols here.
>
> - the function args weren't documented
>
> But the return value is!  People regularly forget to do that.  And
> they frequently forget to document the locking prerequisites and the
> permissible calling contexts (process/might_sleep/hardirq, etc)
>
> (please check all ecryptfs kerneldoc for this stuff sometime)

This patch cleans up some of the existing comments and makes a couple
of line break tweaks. There is more work to do to bring eCryptfs into
full kerneldoc-compliance.

Signed-off-by: Michael Halcrow <mhalcrow@us.ibm.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2007-10-16 09:43:11 -07:00
..
crypto.c eCryptfs: kerneldoc fixes for crypto.c and keystore.c 2007-10-16 09:43:11 -07:00
debug.c eCryptfs: update comment and debug statement 2007-10-16 09:43:11 -07:00
dentry.c [PATCH] eCryptfs: fix possible NULL ptr deref in ecryptfs_d_release() 2007-03-16 19:25:05 -07:00
ecryptfs_kernel.h eCryptfs: comments for some structs 2007-10-16 09:43:11 -07:00
file.c sendfile: remove .sendfile from filesystems that use generic_file_sendfile() 2007-07-10 08:04:13 +02:00
inode.c revert "eCryptfs: fix lookup error for special files" 2007-08-31 01:42:22 -07:00
keystore.c eCryptfs: kerneldoc fixes for crypto.c and keystore.c 2007-10-16 09:43:11 -07:00
main.c eCryptfs: grammatical fix (destruct to destroy) 2007-10-16 09:43:11 -07:00
Makefile [PATCH] eCryptfs: Public key; packet management 2007-02-12 09:48:36 -08:00
messaging.c Detach sched.h from mm.h 2007-05-21 09:18:19 -07:00
mmap.c fs: remove some AOP_TRUNCATED_PAGE 2007-10-16 09:42:58 -07:00
netlink.c [NET]: make netlink user -> kernel interface synchronious 2007-10-10 21:15:29 -07:00
super.c eCryptfs: grammatical fix (destruct to destroy) 2007-10-16 09:43:11 -07:00