mirror of
https://mirrors.bfsu.edu.cn/git/linux.git
synced 2024-11-16 00:34:20 +08:00
2aa72ec97c
The device creator is supposed to use the dev.groups value to add sysfs files before device_add is called, not call sysfs_create_files() after device_add() returns. This creates a race with uevent delivery where the extra attribute will not be visible. This was being done because the groups had been co-opted by the mdev driver, now that prior patches have moved the driver's groups to the struct device_driver the dev.group is properly free for use here. Signed-off-by: Jason Gunthorpe <jgg@nvidia.com> Signed-off-by: Christoph Hellwig <hch@lst.de> Signed-off-by: Zhi Wang <zhi.a.wang@intel.com> Link: http://patchwork.freedesktop.org/patch/msgid/20220411141403.86980-34-hch@lst.de Reviewed-by: Kirti Wankhede <kwankhede@nvidia.com> Reviewed-by: Zhi Wang <zhi.a.wang@intel.com>
64 lines
1.6 KiB
C
64 lines
1.6 KiB
C
/* SPDX-License-Identifier: GPL-2.0-only */
|
|
/*
|
|
* Mediated device internal definitions
|
|
*
|
|
* Copyright (c) 2016, NVIDIA CORPORATION. All rights reserved.
|
|
* Author: Neo Jia <cjia@nvidia.com>
|
|
* Kirti Wankhede <kwankhede@nvidia.com>
|
|
*/
|
|
|
|
#ifndef MDEV_PRIVATE_H
|
|
#define MDEV_PRIVATE_H
|
|
|
|
int mdev_bus_register(void);
|
|
void mdev_bus_unregister(void);
|
|
|
|
struct mdev_parent {
|
|
struct device *dev;
|
|
struct mdev_driver *mdev_driver;
|
|
struct kref ref;
|
|
struct list_head next;
|
|
struct kset *mdev_types_kset;
|
|
struct list_head type_list;
|
|
/* Synchronize device creation/removal with parent unregistration */
|
|
struct rw_semaphore unreg_sem;
|
|
};
|
|
|
|
struct mdev_type {
|
|
struct kobject kobj;
|
|
struct kobject *devices_kobj;
|
|
struct mdev_parent *parent;
|
|
struct list_head next;
|
|
unsigned int type_group_id;
|
|
};
|
|
|
|
extern const struct attribute_group *mdev_device_groups[];
|
|
|
|
#define to_mdev_type_attr(_attr) \
|
|
container_of(_attr, struct mdev_type_attribute, attr)
|
|
#define to_mdev_type(_kobj) \
|
|
container_of(_kobj, struct mdev_type, kobj)
|
|
|
|
int parent_create_sysfs_files(struct mdev_parent *parent);
|
|
void parent_remove_sysfs_files(struct mdev_parent *parent);
|
|
|
|
int mdev_create_sysfs_files(struct mdev_device *mdev);
|
|
void mdev_remove_sysfs_files(struct mdev_device *mdev);
|
|
|
|
int mdev_device_create(struct mdev_type *kobj, const guid_t *uuid);
|
|
int mdev_device_remove(struct mdev_device *dev);
|
|
|
|
void mdev_release_parent(struct kref *kref);
|
|
|
|
static inline void mdev_get_parent(struct mdev_parent *parent)
|
|
{
|
|
kref_get(&parent->ref);
|
|
}
|
|
|
|
static inline void mdev_put_parent(struct mdev_parent *parent)
|
|
{
|
|
kref_put(&parent->ref, mdev_release_parent);
|
|
}
|
|
|
|
#endif /* MDEV_PRIVATE_H */
|