mirror of
https://mirrors.bfsu.edu.cn/git/linux.git
synced 2024-12-04 17:44:14 +08:00
246bbf2f97
If the port isn't a CPU port nor a user port, 'cpu_dp'
is a null pointer and a crash happened on dereferencing
it in mv88e6060_setup_port():
[ 9.575872] Unable to handle kernel NULL pointer dereference at virtual address 00000014
...
[ 9.942216] mv88e6060_setup from dsa_register_switch+0x814/0xe84
[ 9.948616] dsa_register_switch from mdio_probe+0x2c/0x54
[ 9.954433] mdio_probe from really_probe.part.0+0x98/0x2a0
[ 9.960375] really_probe.part.0 from driver_probe_device+0x30/0x10c
[ 9.967029] driver_probe_device from __device_attach_driver+0xb8/0x13c
[ 9.973946] __device_attach_driver from bus_for_each_drv+0x90/0xe0
[ 9.980509] bus_for_each_drv from __device_attach+0x110/0x184
[ 9.986632] __device_attach from bus_probe_device+0x8c/0x94
[ 9.992577] bus_probe_device from deferred_probe_work_func+0x78/0xa8
[ 9.999311] deferred_probe_work_func from process_one_work+0x290/0x73c
[ 10.006292] process_one_work from worker_thread+0x30/0x4b8
[ 10.012155] worker_thread from kthread+0xd4/0x10c
[ 10.017238] kthread from ret_from_fork+0x14/0x3c
Fixes: 0abfd494de
("net: dsa: use dedicated CPU port")
CC: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
CC: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: Sergei Antonov <saproj@gmail.com>
Signed-off-by: Vladimir Oltean <olteanv@gmail.com>
Link: https://lore.kernel.org/r/20220811070939.1717146-1-saproj@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
339 lines
7.6 KiB
C
339 lines
7.6 KiB
C
// SPDX-License-Identifier: GPL-2.0+
|
|
/*
|
|
* net/dsa/mv88e6060.c - Driver for Marvell 88e6060 switch chips
|
|
* Copyright (c) 2008-2009 Marvell Semiconductor
|
|
*/
|
|
|
|
#include <linux/delay.h>
|
|
#include <linux/etherdevice.h>
|
|
#include <linux/jiffies.h>
|
|
#include <linux/list.h>
|
|
#include <linux/module.h>
|
|
#include <linux/netdevice.h>
|
|
#include <linux/phy.h>
|
|
#include <net/dsa.h>
|
|
#include "mv88e6060.h"
|
|
|
|
static int reg_read(struct mv88e6060_priv *priv, int addr, int reg)
|
|
{
|
|
return mdiobus_read_nested(priv->bus, priv->sw_addr + addr, reg);
|
|
}
|
|
|
|
static int reg_write(struct mv88e6060_priv *priv, int addr, int reg, u16 val)
|
|
{
|
|
return mdiobus_write_nested(priv->bus, priv->sw_addr + addr, reg, val);
|
|
}
|
|
|
|
static const char *mv88e6060_get_name(struct mii_bus *bus, int sw_addr)
|
|
{
|
|
int ret;
|
|
|
|
ret = mdiobus_read(bus, sw_addr + REG_PORT(0), PORT_SWITCH_ID);
|
|
if (ret >= 0) {
|
|
if (ret == PORT_SWITCH_ID_6060)
|
|
return "Marvell 88E6060 (A0)";
|
|
if (ret == PORT_SWITCH_ID_6060_R1 ||
|
|
ret == PORT_SWITCH_ID_6060_R2)
|
|
return "Marvell 88E6060 (B0)";
|
|
if ((ret & PORT_SWITCH_ID_6060_MASK) == PORT_SWITCH_ID_6060)
|
|
return "Marvell 88E6060";
|
|
}
|
|
|
|
return NULL;
|
|
}
|
|
|
|
static enum dsa_tag_protocol mv88e6060_get_tag_protocol(struct dsa_switch *ds,
|
|
int port,
|
|
enum dsa_tag_protocol m)
|
|
{
|
|
return DSA_TAG_PROTO_TRAILER;
|
|
}
|
|
|
|
static int mv88e6060_switch_reset(struct mv88e6060_priv *priv)
|
|
{
|
|
int i;
|
|
int ret;
|
|
unsigned long timeout;
|
|
|
|
/* Set all ports to the disabled state. */
|
|
for (i = 0; i < MV88E6060_PORTS; i++) {
|
|
ret = reg_read(priv, REG_PORT(i), PORT_CONTROL);
|
|
if (ret < 0)
|
|
return ret;
|
|
ret = reg_write(priv, REG_PORT(i), PORT_CONTROL,
|
|
ret & ~PORT_CONTROL_STATE_MASK);
|
|
if (ret)
|
|
return ret;
|
|
}
|
|
|
|
/* Wait for transmit queues to drain. */
|
|
usleep_range(2000, 4000);
|
|
|
|
/* Reset the switch. */
|
|
ret = reg_write(priv, REG_GLOBAL, GLOBAL_ATU_CONTROL,
|
|
GLOBAL_ATU_CONTROL_SWRESET |
|
|
GLOBAL_ATU_CONTROL_LEARNDIS);
|
|
if (ret)
|
|
return ret;
|
|
|
|
/* Wait up to one second for reset to complete. */
|
|
timeout = jiffies + 1 * HZ;
|
|
while (time_before(jiffies, timeout)) {
|
|
ret = reg_read(priv, REG_GLOBAL, GLOBAL_STATUS);
|
|
if (ret < 0)
|
|
return ret;
|
|
|
|
if (ret & GLOBAL_STATUS_INIT_READY)
|
|
break;
|
|
|
|
usleep_range(1000, 2000);
|
|
}
|
|
if (time_after(jiffies, timeout))
|
|
return -ETIMEDOUT;
|
|
|
|
return 0;
|
|
}
|
|
|
|
static int mv88e6060_setup_global(struct mv88e6060_priv *priv)
|
|
{
|
|
int ret;
|
|
|
|
/* Disable discarding of frames with excessive collisions,
|
|
* set the maximum frame size to 1536 bytes, and mask all
|
|
* interrupt sources.
|
|
*/
|
|
ret = reg_write(priv, REG_GLOBAL, GLOBAL_CONTROL,
|
|
GLOBAL_CONTROL_MAX_FRAME_1536);
|
|
if (ret)
|
|
return ret;
|
|
|
|
/* Disable automatic address learning.
|
|
*/
|
|
return reg_write(priv, REG_GLOBAL, GLOBAL_ATU_CONTROL,
|
|
GLOBAL_ATU_CONTROL_LEARNDIS);
|
|
}
|
|
|
|
static int mv88e6060_setup_port(struct mv88e6060_priv *priv, int p)
|
|
{
|
|
int addr = REG_PORT(p);
|
|
int ret;
|
|
|
|
if (dsa_is_unused_port(priv->ds, p))
|
|
return 0;
|
|
|
|
/* Do not force flow control, disable Ingress and Egress
|
|
* Header tagging, disable VLAN tunneling, and set the port
|
|
* state to Forwarding. Additionally, if this is the CPU
|
|
* port, enable Ingress and Egress Trailer tagging mode.
|
|
*/
|
|
ret = reg_write(priv, addr, PORT_CONTROL,
|
|
dsa_is_cpu_port(priv->ds, p) ?
|
|
PORT_CONTROL_TRAILER |
|
|
PORT_CONTROL_INGRESS_MODE |
|
|
PORT_CONTROL_STATE_FORWARDING :
|
|
PORT_CONTROL_STATE_FORWARDING);
|
|
if (ret)
|
|
return ret;
|
|
|
|
/* Port based VLAN map: give each port its own address
|
|
* database, allow the CPU port to talk to each of the 'real'
|
|
* ports, and allow each of the 'real' ports to only talk to
|
|
* the CPU port.
|
|
*/
|
|
ret = reg_write(priv, addr, PORT_VLAN_MAP,
|
|
((p & 0xf) << PORT_VLAN_MAP_DBNUM_SHIFT) |
|
|
(dsa_is_cpu_port(priv->ds, p) ?
|
|
dsa_user_ports(priv->ds) :
|
|
BIT(dsa_to_port(priv->ds, p)->cpu_dp->index)));
|
|
if (ret)
|
|
return ret;
|
|
|
|
/* Port Association Vector: when learning source addresses
|
|
* of packets, add the address to the address database using
|
|
* a port bitmap that has only the bit for this port set and
|
|
* the other bits clear.
|
|
*/
|
|
return reg_write(priv, addr, PORT_ASSOC_VECTOR, BIT(p));
|
|
}
|
|
|
|
static int mv88e6060_setup_addr(struct mv88e6060_priv *priv)
|
|
{
|
|
u8 addr[ETH_ALEN];
|
|
int ret;
|
|
u16 val;
|
|
|
|
eth_random_addr(addr);
|
|
|
|
val = addr[0] << 8 | addr[1];
|
|
|
|
/* The multicast bit is always transmitted as a zero, so the switch uses
|
|
* bit 8 for "DiffAddr", where 0 means all ports transmit the same SA.
|
|
*/
|
|
val &= 0xfeff;
|
|
|
|
ret = reg_write(priv, REG_GLOBAL, GLOBAL_MAC_01, val);
|
|
if (ret)
|
|
return ret;
|
|
|
|
ret = reg_write(priv, REG_GLOBAL, GLOBAL_MAC_23,
|
|
(addr[2] << 8) | addr[3]);
|
|
if (ret)
|
|
return ret;
|
|
|
|
return reg_write(priv, REG_GLOBAL, GLOBAL_MAC_45,
|
|
(addr[4] << 8) | addr[5]);
|
|
}
|
|
|
|
static int mv88e6060_setup(struct dsa_switch *ds)
|
|
{
|
|
struct mv88e6060_priv *priv = ds->priv;
|
|
int ret;
|
|
int i;
|
|
|
|
priv->ds = ds;
|
|
|
|
ret = mv88e6060_switch_reset(priv);
|
|
if (ret < 0)
|
|
return ret;
|
|
|
|
/* @@@ initialise atu */
|
|
|
|
ret = mv88e6060_setup_global(priv);
|
|
if (ret < 0)
|
|
return ret;
|
|
|
|
ret = mv88e6060_setup_addr(priv);
|
|
if (ret < 0)
|
|
return ret;
|
|
|
|
for (i = 0; i < MV88E6060_PORTS; i++) {
|
|
ret = mv88e6060_setup_port(priv, i);
|
|
if (ret < 0)
|
|
return ret;
|
|
}
|
|
|
|
return 0;
|
|
}
|
|
|
|
static int mv88e6060_port_to_phy_addr(int port)
|
|
{
|
|
if (port >= 0 && port < MV88E6060_PORTS)
|
|
return port;
|
|
return -1;
|
|
}
|
|
|
|
static int mv88e6060_phy_read(struct dsa_switch *ds, int port, int regnum)
|
|
{
|
|
struct mv88e6060_priv *priv = ds->priv;
|
|
int addr;
|
|
|
|
addr = mv88e6060_port_to_phy_addr(port);
|
|
if (addr == -1)
|
|
return 0xffff;
|
|
|
|
return reg_read(priv, addr, regnum);
|
|
}
|
|
|
|
static int
|
|
mv88e6060_phy_write(struct dsa_switch *ds, int port, int regnum, u16 val)
|
|
{
|
|
struct mv88e6060_priv *priv = ds->priv;
|
|
int addr;
|
|
|
|
addr = mv88e6060_port_to_phy_addr(port);
|
|
if (addr == -1)
|
|
return 0xffff;
|
|
|
|
return reg_write(priv, addr, regnum, val);
|
|
}
|
|
|
|
static const struct dsa_switch_ops mv88e6060_switch_ops = {
|
|
.get_tag_protocol = mv88e6060_get_tag_protocol,
|
|
.setup = mv88e6060_setup,
|
|
.phy_read = mv88e6060_phy_read,
|
|
.phy_write = mv88e6060_phy_write,
|
|
};
|
|
|
|
static int mv88e6060_probe(struct mdio_device *mdiodev)
|
|
{
|
|
struct device *dev = &mdiodev->dev;
|
|
struct mv88e6060_priv *priv;
|
|
struct dsa_switch *ds;
|
|
const char *name;
|
|
|
|
priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL);
|
|
if (!priv)
|
|
return -ENOMEM;
|
|
|
|
priv->bus = mdiodev->bus;
|
|
priv->sw_addr = mdiodev->addr;
|
|
|
|
name = mv88e6060_get_name(priv->bus, priv->sw_addr);
|
|
if (!name)
|
|
return -ENODEV;
|
|
|
|
dev_info(dev, "switch %s detected\n", name);
|
|
|
|
ds = devm_kzalloc(dev, sizeof(*ds), GFP_KERNEL);
|
|
if (!ds)
|
|
return -ENOMEM;
|
|
|
|
ds->dev = dev;
|
|
ds->num_ports = MV88E6060_PORTS;
|
|
ds->priv = priv;
|
|
ds->dev = dev;
|
|
ds->ops = &mv88e6060_switch_ops;
|
|
|
|
dev_set_drvdata(dev, ds);
|
|
|
|
return dsa_register_switch(ds);
|
|
}
|
|
|
|
static void mv88e6060_remove(struct mdio_device *mdiodev)
|
|
{
|
|
struct dsa_switch *ds = dev_get_drvdata(&mdiodev->dev);
|
|
|
|
if (!ds)
|
|
return;
|
|
|
|
dsa_unregister_switch(ds);
|
|
|
|
dev_set_drvdata(&mdiodev->dev, NULL);
|
|
}
|
|
|
|
static void mv88e6060_shutdown(struct mdio_device *mdiodev)
|
|
{
|
|
struct dsa_switch *ds = dev_get_drvdata(&mdiodev->dev);
|
|
|
|
if (!ds)
|
|
return;
|
|
|
|
dsa_switch_shutdown(ds);
|
|
|
|
dev_set_drvdata(&mdiodev->dev, NULL);
|
|
}
|
|
|
|
static const struct of_device_id mv88e6060_of_match[] = {
|
|
{
|
|
.compatible = "marvell,mv88e6060",
|
|
},
|
|
{ /* sentinel */ },
|
|
};
|
|
|
|
static struct mdio_driver mv88e6060_driver = {
|
|
.probe = mv88e6060_probe,
|
|
.remove = mv88e6060_remove,
|
|
.shutdown = mv88e6060_shutdown,
|
|
.mdiodrv.driver = {
|
|
.name = "mv88e6060",
|
|
.of_match_table = mv88e6060_of_match,
|
|
},
|
|
};
|
|
|
|
mdio_module_driver(mv88e6060_driver);
|
|
|
|
MODULE_AUTHOR("Lennert Buytenhek <buytenh@wantstofly.org>");
|
|
MODULE_DESCRIPTION("Driver for Marvell 88E6060 ethernet switch chip");
|
|
MODULE_LICENSE("GPL");
|
|
MODULE_ALIAS("platform:mv88e6060");
|