Alex Estrin 612601d001 Revert "IB/ipoib: Update broadcast object if PKey value was changed in index 0" ... commit 9a9b811269 will cause core to fail UD QP from being destroyed on ipoib unload, therefore cause resources leakage. On pkey change event above patch modifies mgid before calling underlying driver to detach it from QP. Drivers' detach_mcast() will fail to find modified mgid it was never given to attach in a first place. Core qp->usecnt will never go down, so ib_destroy_qp() will fail. IPoIB driver actually does take care of new broadcast mgid based on new pkey by destroying an old mcast object in ipoib_mcast_dev_flush()) .... if (priv->broadcast) { rb_erase(&priv->broadcast->rb_node, &priv->multicast_tree); list_add_tail(&priv->broadcast->list, &remove_list); priv->broadcast = NULL; } ... then in restarted ipoib_macst_join_task() creating a new broadcast mcast object, sending join request and on completion tells the driver to attach to reinitialized QP: ... if (!priv->broadcast) { ... broadcast = ipoib_mcast_alloc(dev, 0); ... memcpy(broadcast->mcmember.mgid.raw, priv->dev->broadcast + 4, sizeof (union ib_gid)); priv->broadcast = broadcast; ... Fixes: 9a9b811269 ("IB/ipoib: Update broadcast object if PKey value was changed in index 0") Cc: stable@vger.kernel.org Reviewed-by: Mike Marciniszyn <mike.marciniszyn@intel.com> Reviewed-by: Dennis Dalessandro <dennis.dalessandro@intel.com> Signed-off-by: Alex Estrin <alex.estrin@intel.com> Signed-off-by: Dennis Dalessandro <dennis.dalessandro@intel.com> Reviewed-by: Feras Daoud <ferasda@mellanox.com> Signed-off-by: Doug Ledford <dledford@redhat.com>		2017-09-27 11:10:36 -04:00
..
ipoib	Revert "IB/ipoib: Update broadcast object if PKey value was changed in index 0"	2017-09-27 11:10:36 -04:00
iser	IB: Correct MR length field to be 64-bit	2017-09-25 11:47:23 -04:00
isert	RDMA: Remove useless MODULE_VERSION	2017-07-24 08:45:11 -04:00
opa_vnic	RDMA/(core, ulp): Convert register/unregister event handler to be void	2017-08-24 16:27:10 -04:00
srp	RDMA: Remove useless MODULE_VERSION	2017-07-24 08:45:11 -04:00
srpt	RDMA/(core, ulp): Convert register/unregister event handler to be void	2017-08-24 16:27:10 -04:00
Makefile	IB/opa-vnic: Virtual Network Interface Controller (VNIC) netdev	2017-04-20 12:01:38 -04:00