Baokun Li ac894a1e19 ext4: avoid bb_free and bb_fragments inconsistency in mb_free_blocks() ... commit 2331fd4a49 upstream. After updating bb_free in mb_free_blocks, it is possible to return without updating bb_fragments because the block being freed is found to have already been freed, which leads to inconsistency between bb_free and bb_fragments. Since the group may be unlocked in ext4_grp_locked_error(), this can lead to problems such as dividing by zero when calculating the average fragment length. Hence move the update of bb_free to after the block double-free check guarantees that the corresponding statistics are updated only after the core block bitmap is modified. Fixes: eabe0444df ("ext4: speed-up releasing blocks on commit") CC: <stable@vger.kernel.org> # 3.10 Suggested-by: Jan Kara <jack@suse.cz> Signed-off-by: Baokun Li <libaokun1@huawei.com> Reviewed-by: Jan Kara <jack@suse.cz> Link: https://lore.kernel.org/r/20240104142040.2835097-5-libaokun1@huawei.com Signed-off-by: Theodore Ts'o <tytso@mit.edu> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2024-02-23 09:12:39 +01:00
..
.kunitconfig	ext4: add .kunitconfig fragment to enable ext4-specific tests	2021-02-11 23:16:30 -05:00
acl.c	fs/ext4: fix comments mentioning i_mutex	2022-02-03 10:57:53 -05:00
acl.h	ext4: apply umask if ACL support is disabled	2023-11-28 17:07:21 +00:00
balloc.c	ext4: add correct group descriptors and reserved GDT blocks to system zone	2023-09-19 12:28:05 +02:00
bitmap.c
block_validity.c	ext4: add correct group descriptors and reserved GDT blocks to system zone	2023-09-19 12:28:05 +02:00
crypto.c	ext4: fix memory leaks in ext4_fname_{setup_filename,prepare_lookup}	2023-09-19 12:28:05 +02:00
dir.c	ext4: fix spelling errors in comments	2022-05-11 15:19:06 -04:00
ext4_extents.h	ext4: fix sparse warnings	2021-08-30 23:36:50 -04:00
ext4_jbd2.c	ext4: use ext4_debug() instead of jbd_debug()	2022-08-02 23:52:19 -04:00
ext4_jbd2.h	fs/ext4: fix comments mentioning i_mutex	2022-02-03 10:57:53 -05:00
ext4.h	ext4: add correct group descriptors and reserved GDT blocks to system zone	2023-09-19 12:28:05 +02:00
extents_status.c	ext4: make sure allocate pending entry not fail	2023-12-03 07:32:10 +01:00
extents_status.h
extents.c	ext4: move 'ix' sanity check to corrent position	2023-11-20 11:52:06 +01:00
fast_commit.c	ext4: use ext4_fc_tl_mem in fast-commit replay path	2023-03-11 13:55:22 +01:00
fast_commit.h	ext4: add missing validation of fast-commit record lengths	2023-01-07 11:12:00 +01:00
file.c	ext4: fix warning in ext4_dio_write_end_io()	2023-12-20 17:00:14 +01:00
fsmap.c	ext4: fix another off-by-one fsmap error on 1k block filesystems	2023-03-17 08:50:16 +01:00
fsmap.h	ext4: fsmap: fix the block/inode bitmap comment	2021-06-24 09:48:29 -04:00
fsync.c	block: use an on-stack bio in blkdev_issue_flush	2021-01-27 09:51:48 -07:00
hash.c	ext4: improve error handling from ext4_dirhash()	2023-05-17 11:53:58 +02:00
ialloc.c	ext4: allow ext4_get_group_info() to fail	2023-05-24 17:32:33 +01:00
indirect.c	ext4: only update i_reserved_data_blocks on successful block allocation	2023-07-23 13:49:34 +02:00
inline.c	ext4: bail out of ext4_xattr_ibody_get() fails for any reason	2023-05-17 11:53:58 +02:00
inode-test.c	fs: ext4: Modify inode-test.c to use KUnit parameterized testing feature	2020-12-02 16:07:25 -07:00
inode.c	ext4: mark buffer new if it is unwritten to avoid stale data exposure	2023-11-28 17:07:21 +00:00
ioctl.c	ext4: fix to check return value of freeze_bdev() in ext4_shutdown()	2023-07-23 13:49:34 +02:00
Kconfig	ext: EXT4_KUNIT_TESTS should depend on EXT4_FS instead of selecting it	2021-02-11 23:12:59 -05:00
Makefile	ext4: move ext4 crypto code to its own file crypto.c	2022-05-21 22:24:24 -04:00
mballoc.c	ext4: avoid bb_free and bb_fragments inconsistency in mb_free_blocks()	2024-02-23 09:12:39 +01:00
mballoc.h	ext4: add two helper functions extent_logical_end() and pa_logical_end()	2023-11-02 09:35:32 +01:00
migrate.c	ext4: fix warning in 'ext4_da_release_space'	2022-11-06 01:07:59 -04:00
mmp.c	ext4: reflect error codes from ext4_multi_mount_protect() to its callers	2023-05-24 17:32:33 +01:00
move_extent.c	ext4: fix double-free of blocks due to wrong extents moved_len	2024-02-23 09:12:39 +01:00
namei.c	ext4: fix rec_len verify error	2023-09-23 11:11:12 +02:00
orphan.c	ext4: remove trailing newline from ext4_msg() message	2023-01-07 11:11:58 +01:00
page-io.c	ext4: fix cgroup writeback accounting with fs-layer encryption	2023-03-17 08:50:16 +01:00
readpage.c	fscrypt: stop using PG_error to track error status	2022-09-06 15:15:56 -07:00
resize.c	ext4: avoid online resizing failures due to oversized flex bg	2024-02-05 20:12:49 +00:00
super.c	ext4: turn quotas off if mount failed after enabling quotas	2023-07-23 13:49:34 +02:00
symlink.c	ext4: fix reading leftover inlined symlinks	2022-08-02 23:37:50 -04:00
sysfs.c	ext4: Fix function prototype mismatch for ext4_feat_ktype	2023-02-25 11:25:43 +01:00
truncate.h	ext4: Convert to use mapping->invalidate_lock	2021-07-13 14:29:00 +02:00
verity.c	fs: ext4: initialize fsdata in pagecache_write()	2023-01-07 11:11:58 +01:00
xattr_hurd.c	acl: handle idmapped mounts	2021-01-24 14:27:17 +01:00
xattr_security.c	acl: handle idmapped mounts	2021-01-24 14:27:17 +01:00
xattr_trusted.c	acl: handle idmapped mounts	2021-01-24 14:27:17 +01:00
xattr_user.c	acl: handle idmapped mounts	2021-01-24 14:27:17 +01:00
xattr.c	ext4: correct inline offset when handling xattrs in inode body	2023-07-27 08:50:31 +02:00
xattr.h	ext4: remove EA inode entry from mbcache on inode eviction	2022-08-02 23:56:25 -04:00