Harshit Mogalapalli 16bbdfe5fb io_uring/msg_ring: Fix NULL pointer dereference in io_msg_send_fd() ... Syzkaller produced the below call trace: BUG: KASAN: null-ptr-deref in io_msg_ring+0x3cb/0x9f0 Write of size 8 at addr 0000000000000070 by task repro/16399 CPU: 0 PID: 16399 Comm: repro Not tainted 6.1.0-rc1 #28 Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.11.0-2.el7 Call Trace: <TASK> dump_stack_lvl+0xcd/0x134 ? io_msg_ring+0x3cb/0x9f0 kasan_report+0xbc/0xf0 ? io_msg_ring+0x3cb/0x9f0 kasan_check_range+0x140/0x190 io_msg_ring+0x3cb/0x9f0 ? io_msg_ring_prep+0x300/0x300 io_issue_sqe+0x698/0xca0 io_submit_sqes+0x92f/0x1c30 __do_sys_io_uring_enter+0xae4/0x24b0 .... RIP: 0033:0x7f2eaf8f8289 RSP: 002b:00007fff40939718 EFLAGS: 00000246 ORIG_RAX: 00000000000001aa RAX: ffffffffffffffda RBX: 0000000000000000 RCX: 00007f2eaf8f8289 RDX: 0000000000000000 RSI: 0000000000006f71 RDI: 0000000000000004 RBP: 00007fff409397a0 R08: 0000000000000000 R09: 0000000000000039 R10: 0000000000000000 R11: 0000000000000246 R12: 00000000004006d0 R13: 00007fff40939880 R14: 0000000000000000 R15: 0000000000000000 </TASK> Kernel panic - not syncing: panic_on_warn set ... We don't have a NULL check on file_ptr in io_msg_send_fd() function, so when file_ptr is NUL src_file is also NULL and get_file() dereferences a NULL pointer and leads to above crash. Add a NULL check to fix this issue. Fixes: e6130eba8a ("io_uring: add support for passing fixed file descriptors") Reported-by: syzkaller <syzkaller@googlegroups.com> Signed-off-by: Harshit Mogalapalli <harshit.m.mogalapalli@oracle.com> Link: https://lore.kernel.org/r/20221019171218.1337614-1-harshit.m.mogalapalli@oracle.com Signed-off-by: Jens Axboe <axboe@kernel.dk>		2022-10-19 12:33:33 -07:00
..
advise.c	io_uring: make io_kiocb_to_cmd() typesafe	2022-08-12 17:01:00 -06:00
advise.h
alloc_cache.h
cancel.c	io_uring: add IORING_SETUP_DEFER_TASKRUN	2022-09-21 10:30:42 -06:00
cancel.h
epoll.c	io_uring: make io_kiocb_to_cmd() typesafe	2022-08-12 17:01:00 -06:00
epoll.h
fdinfo.c	io_uring: fix fdinfo sqe offsets calculation	2022-10-12 16:30:56 -06:00
fdinfo.h
filetable.c
filetable.h	io_uring: kill hot path fixed file bitmap debug checks	2022-10-16 17:07:53 -06:00
fs.c	io_uring: make io_kiocb_to_cmd() typesafe	2022-08-12 17:01:00 -06:00
fs.h
io_uring.c	io_uring: don't iopoll from io_ring_ctx_wait_and_kill()	2022-10-16 17:08:42 -06:00
io_uring.h	io_uring: optimise locking for local tw with submit_wait	2022-10-12 16:30:56 -06:00
io-wq.c
io-wq.h
kbuf.c	io_uring: make io_kiocb_to_cmd() typesafe	2022-08-12 17:01:00 -06:00
kbuf.h	io_uring: allow buffer recycling in READV	2022-09-21 10:30:43 -06:00
Makefile
msg_ring.c	io_uring/msg_ring: Fix NULL pointer dereference in io_msg_send_fd()	2022-10-19 12:33:33 -07:00
msg_ring.h
net.c	io_uring/net: handle -EINPROGRESS correct for IORING_OP_CONNECT	2022-10-12 16:30:56 -06:00
net.h	io_uring/net: zerocopy sendmsg	2022-09-21 13:15:02 -06:00
nop.c
nop.h
notif.c	io_uring/notif: Remove the unused function io_notif_complete()	2022-09-05 11:42:39 -06:00
notif.h	io_uring/net: simplify zerocopy send user API	2022-09-01 09:13:33 -06:00
opdef.c	io_uring/opdef: remove 'audit_skip' from SENDMSG_ZC	2022-10-12 16:30:56 -06:00
opdef.h	io_uring: add custom opcode hooks on fail	2022-09-21 13:15:02 -06:00
openclose.c	io_uring: make io_kiocb_to_cmd() typesafe	2022-08-12 17:01:00 -06:00
openclose.h
poll.c	io_uring/poll: disable level triggered poll	2022-09-28 19:27:11 -06:00
poll.h
refs.h
rsrc.c	io_uring: remove FFS_SCM	2022-10-16 17:07:12 -06:00
rsrc.h	io_uring: remove FFS_SCM	2022-10-16 17:07:12 -06:00
rw.c	io_uring/rw: remove leftover debug statement	2022-10-16 17:24:10 -06:00
rw.h	io_uring/rw: don't lose partial IO result on fail	2022-09-21 13:15:02 -06:00
slist.h
splice.c	io_uring: make io_kiocb_to_cmd() typesafe	2022-08-12 17:01:00 -06:00
splice.h
sqpoll.c
sqpoll.h
statx.c	io_uring: make io_kiocb_to_cmd() typesafe	2022-08-12 17:01:00 -06:00
statx.h
sync.c	io_uring: make io_kiocb_to_cmd() typesafe	2022-08-12 17:01:00 -06:00
sync.h
tctx.c	io_uring: remove io_register_submitter	2022-10-07 12:25:30 -06:00
tctx.h	io_uring: simplify __io_uring_add_tctx_node	2022-10-07 12:25:30 -06:00
timeout.c	io_uring: remove unused return from io_disarm_next	2022-09-21 13:15:01 -06:00
timeout.h	io_uring: remove unused return from io_disarm_next	2022-09-21 13:15:01 -06:00
uring_cmd.c	io_uring: introduce fixed buffer support for io_uring_cmd	2022-09-30 07:50:59 -06:00
uring_cmd.h
xattr.c	__io_setxattr(): constify path	2022-09-01 17:39:05 -04:00
xattr.h