linux/arch/parisc
Jiri Slaby 49a5f3cf6a TTY: pdc_cons, fix regression in close
The test in pdc_console_tty_close '!tty->count' was always wrong
because tty->count is decremented after tty->ops->close is called and
thus can never be zero. Hence the 'then' branch was never executed and
the timer never deleted.

This did not matter until commit 5dd5bc40f3 ("TTY: pdc_cons, use
tty_port").  There we needed to set TTY in tty_port to NULL, but this
never happened due to the bug above.

So change the test to really trigger at the last close by changing the
condition to 'tty->count == 1'.

Well, the driver should not touch tty->count at all.  It should use
tty_port->count and count open count there itself.

Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Reported-and-tested-by: Mikulas Patocka <mpatocka@redhat.com>
Cc: Kyle McMartin <kyle@mcmartin.ca>
Cc: Helge Deller <deller@gmx.de>
Cc: "James E.J. Bottomley" <jejb@parisc-linux.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2012-05-05 16:21:21 -07:00
..
configs kconfig: rename CONFIG_EMBEDDED to CONFIG_EXPERT 2011-01-20 17:02:05 -08:00
hpux vfs: new helper - vfs_ustat() 2012-01-03 22:53:07 -05:00
include/asm parisc: fix missing cmpxchg file error from system.h split 2012-04-02 14:41:26 -07:00
kernel TTY: pdc_cons, fix regression in close 2012-05-05 16:21:21 -07:00
lib Disintegrate asm/system.h for PA-RISC 2012-03-28 18:30:02 +01:00
math-emu bug.h: add include of it to various implicit C users 2012-02-29 17:15:08 -05:00
mm mm: now that all old mmu_gather code is gone, remove the storage 2011-05-25 08:39:16 -07:00
oprofile oprofile: more whitespace fixes 2008-10-15 20:55:51 +02:00
defpalo.conf Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00
install.sh kbuild: use INSTALLKERNEL to select customized installkernel script 2009-09-20 12:18:14 +02:00
Kconfig parisc: switch to GENERIC_PCI_IOMAP 2011-11-28 21:13:15 +02:00
Kconfig.debug parisc: add strict copy size checks (v2) 2010-03-06 22:54:09 +00:00
Makefile [PARISC] don't unconditionally override CROSS_COMPILE for 64 bit. 2012-02-28 09:39:28 -06:00
nm Linux-2.6.12-rc2 2005-04-16 15:20:36 -07:00