linux/drivers/acpi/nfit
Dan Williams 11189c1089 acpi/nfit: Fix command-supported detection
The _DSM function number validation only happens to succeed when the
generic Linux command number translation corresponds with a
DSM-family-specific function number. This breaks NVDIMM-N
implementations that correctly implement _LSR, _LSW, and _LSI, but do
not happen to publish support for DSM function numbers 4, 5, and 6.

Recall that the support for _LS{I,R,W} family of methods results in the
DIMM being marked as supporting those command numbers at
acpi_nfit_register_dimms() time. The DSM function mask is only used for
ND_CMD_CALL support of non-NVDIMM_FAMILY_INTEL devices.

Fixes: 31eca76ba2 ("nfit, libnvdimm: limited/whitelisted dimm command...")
Cc: <stable@vger.kernel.org>
Link: https://github.com/pmem/ndctl/issues/78
Reported-by: Sujith Pandel <sujith_pandel@dell.com>
Tested-by: Sujith Pandel <sujith_pandel@dell.com>
Reviewed-by: Vishal Verma <vishal.l.verma@intel.com>
Reviewed-by: Jeff Moyer <jmoyer@redhat.com>
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
2019-01-21 09:58:31 -08:00
..
core.c acpi/nfit: Fix command-supported detection 2019-01-21 09:58:31 -08:00
intel.c nfit: Mark some functions as __maybe_unused 2019-01-08 22:04:38 -08:00
intel.h acpi/nfit, libnvdimm: Introduce nvdimm_security_ops 2018-12-13 17:54:13 -08:00
Kconfig acpi/nfit: Add support for Intel DSM 1.8 commands 2018-12-04 10:31:11 -08:00
Makefile acpi/nfit, libnvdimm: Introduce nvdimm_security_ops 2018-12-13 17:54:13 -08:00
mce.c acpi/nfit, x86/mce: Validate a MCE's address before using it 2018-11-06 19:13:26 +01:00
nfit.h acpi/nfit, libnvdimm: Store dimm id as a member to struct nvdimm 2018-12-13 17:54:12 -08:00