Qu Wenruo fdb4a70bb7 btrfs: always report error in run_one_delayed_ref() ... [ Upstream commit 39f501d68e ] Currently we have a btrfs_debug() for run_one_delayed_ref() failure, but if end users hit such problem, there will be no chance that btrfs_debug() is enabled. This can lead to very little useful info for debugging. This patch will: - Add extra info for error reporting Including: * logical bytenr * num_bytes * type * action * ref_mod - Replace the btrfs_debug() with btrfs_err() - Move the error reporting into run_one_delayed_ref() This is to avoid use-after-free, the @node can be freed in the caller. This error should only be triggered at most once. As if run_one_delayed_ref() failed, we trigger the error message, then causing the call chain to error out: btrfs_run_delayed_refs() `- btrfs_run_delayed_refs() `- btrfs_run_delayed_refs_for_head() `- run_one_delayed_ref() And we will abort the current transaction in btrfs_run_delayed_refs(). If we have to run delayed refs for the abort transaction, run_one_delayed_ref() will just cleanup the refs and do nothing, thus no new error messages would be output. Reviewed-by: Anand Jain <anand.jain@oracle.com> Signed-off-by: Qu Wenruo <wqu@suse.com> Signed-off-by: David Sterba <dsterba@suse.com> Signed-off-by: Sasha Levin <sashal@kernel.org>		2023-01-24 07:22:42 +01:00
..
tests	btrfs: remove pointless and double ulist frees in error paths of qgroup tests	2022-11-26 09:24:32 +01:00
acl.c	overlayfs update for 5.15	2021-09-02 09:21:27 -07:00
async-thread.c	btrfs: fix memory ordering between normal and ordered work functions	2021-11-25 09:48:46 +01:00
async-thread.h
backref.c	btrfs: fix resolving backrefs for inline extent followed by prealloc	2023-01-12 11:58:50 +01:00
backref.h	btrfs: sink iterator parameter to btrfs_ioctl_logical_to_ino	2022-12-08 11:28:38 +01:00
block-group.c	btrfs: enhance unsupported compat RO flags handling	2022-10-29 10:12:53 +02:00
block-group.h	btrfs: fix space cache corruption and potential double allocations	2022-09-05 10:30:12 +02:00
block-rsv.c	btrfs: introduce mount option rescue=ignorebadroots	2020-12-08 15:53:41 +01:00
block-rsv.h
btrfs_inode.h	btrfs: put initial index value of a directory in a constant	2022-08-31 17:16:35 +02:00
check-integrity.c	btrfs: rename btrfs_bio to btrfs_io_context	2022-07-21 21:24:32 +02:00
check-integrity.h
compression.c	btrfs: remove unused parameter nr_pages in add_ra_bio_pages()	2022-04-20 09:34:04 +02:00
compression.h	btrfs: rework btrfs_decompress_buf2page()	2021-08-23 13:19:04 +02:00
ctree.c	btrfs: fix lockdep splat with reloc root extent buffers	2022-09-05 10:30:12 +02:00
ctree.h	btrfs: fix space cache corruption and potential double allocations	2022-09-05 10:30:12 +02:00
delalloc-space.c	btrfs: convert count_max_extents() to use fs_info->max_extent_size	2022-08-31 17:16:34 +02:00
delalloc-space.h
delayed-inode.c	btrfs: add ro compat flags to inodes	2021-08-23 13:19:09 +02:00
delayed-inode.h	btrfs: make btrfs_delayed_update_inode take btrfs_inode	2020-12-08 15:54:10 +01:00
delayed-ref.c	btrfs: fix lock inversion problem when doing qgroup extent tracing	2021-07-22 15:50:07 +02:00
delayed-ref.h	btrfs: add additional parameters to btrfs_init_tree_ref/btrfs_init_data_ref	2022-07-12 16:34:50 +02:00
dev-replace.c	btrfs: add info when mount fails due to stale replace target	2022-08-31 17:16:46 +02:00
dev-replace.h	btrfs: zoned: mark block groups to copy for device-replace	2021-02-09 02:46:07 +01:00
dir-item.c	btrfs: unify lookup return value when dir entry is missing	2021-10-07 22:06:32 +02:00
discard.c	btrfs: fix typos in comments	2021-06-22 14:11:57 +02:00
discard.h	btrfs: cleanup btrfs_discard_update_discardable usage	2020-12-08 15:54:02 +01:00
disk-io.c	btrfs: make thaw time super block check to also verify checksum	2023-01-12 11:59:20 +01:00
disk-io.h	btrfs: make thaw time super block check to also verify checksum	2023-01-12 11:59:20 +01:00
export.c	btrfs: fix type of parameter generation in btrfs_get_dentry	2022-11-10 18:15:38 +01:00
export.h	btrfs: fix type of parameter generation in btrfs_get_dentry	2022-11-10 18:15:38 +01:00
extent_io.c	btrfs: fix lockdep splat with reloc root extent buffers	2022-09-05 10:30:12 +02:00
extent_io.h	btrfs: fix qgroup reserve overflow the qgroup limit	2022-04-13 20:59:23 +02:00
extent_map.c	btrfs: rename btrfs_bio to btrfs_io_context	2022-07-21 21:24:32 +02:00
extent_map.h
extent-io-tree.h	btrfs: use fixed width int type for extent_state::state	2020-12-08 15:54:13 +01:00
extent-tree.c	btrfs: always report error in run_one_delayed_ref()	2023-01-24 07:22:42 +01:00
file-item.c	btrfs: make search_csum_tree return 0 if we get -EFBIG	2022-04-08 14:23:58 +02:00
file.c	btrfs: do not BUG_ON() on ENOMEM when dropping extent items for a range	2022-12-31 13:14:47 +01:00
free-space-cache.c	btrfs: dump extra info if one free space cache has more bitmaps than it should	2022-10-26 12:35:44 +02:00
free-space-cache.h	btrfs: zoned: track unusable bytes for zones	2021-02-09 02:46:03 +01:00
free-space-tree.c	btrfs: fix invalid delayed ref after subvolume creation failure	2022-07-12 16:34:50 +02:00
free-space-tree.h
inode-item.c	btrfs: locking: rip out path->leave_spinning	2020-12-08 15:54:02 +01:00
inode.c	btrfs: remove root argument from btrfs_unlink_inode()	2022-09-05 10:30:09 +02:00
ioctl.c	btrfs: replace strncpy() with strscpy()	2023-01-12 11:59:05 +01:00
Kconfig	btrfs: disable build on platforms having page size 256K	2021-06-22 14:11:57 +02:00
locking.c	btrfs: fix lockdep splat with reloc root extent buffers	2022-09-05 10:30:12 +02:00
locking.h	btrfs: fix lockdep splat with reloc root extent buffers	2022-09-05 10:30:12 +02:00
lzo.c	btrfs: prevent copying too big compressed lzo segment	2022-03-02 11:48:07 +01:00
Makefile	btrfs: initial fsverity support	2021-08-23 13:19:09 +02:00
misc.h	btrfs: use correct header for div_u64 in misc.h	2021-09-07 14:29:50 +02:00
ordered-data.c	btrfs: zoned: fix double counting of split ordered extent	2021-09-07 14:30:41 +02:00
ordered-data.h	btrfs: remove uptodate parameter from btrfs_dec_test_first_ordered_pending	2021-08-23 13:19:02 +02:00
orphan.c
print-tree.c	btrfs: print the actual offset in btrfs_root_name	2021-01-07 17:25:05 +01:00
print-tree.h	btrfs: print the actual offset in btrfs_root_name	2021-01-07 17:25:05 +01:00
props.c	btrfs: props: change how empty value is interpreted	2021-06-22 14:11:58 +02:00
props.h
qgroup.c	btrfs: qgroup: fix sleep from invalid context bug in btrfs_qgroup_inherit()	2022-12-08 11:28:38 +01:00
qgroup.h	btrfs: fix lock inversion problem when doing qgroup extent tracing	2021-07-22 15:50:07 +02:00
raid56.c	btrfs: raid56: properly handle the error when unable to find the missing stripe	2022-11-26 09:24:31 +01:00
raid56.h	btrfs: rename btrfs_bio to btrfs_io_context	2022-07-21 21:24:32 +02:00
rcu-string.h	btrfs: replace strncpy() with strscpy()	2023-01-12 11:59:05 +01:00
reada.c	btrfs: rename btrfs_bio to btrfs_io_context	2022-07-21 21:24:32 +02:00
ref-verify.c	btrfs: stop doing GFP_KERNEL memory allocations in the ref verify tool	2021-08-23 13:19:00 +02:00
ref-verify.h
reflink.c	btrfs: fix unexpected error path when reflinking an inline extent	2022-04-08 14:23:11 +02:00
reflink.h
relocation.c	btrfs: fix lockdep splat with reloc root extent buffers	2022-09-05 10:30:12 +02:00
root-tree.c	btrfs: fix silent failure when deleting root reference	2022-08-31 17:16:46 +02:00
scrub.c	btrfs: scrub: try to fix super block errors	2022-10-26 12:35:44 +02:00
send.c	btrfs: send: avoid unaligned encoded writes when attempting to clone range	2022-12-14 11:37:16 +01:00
send.h	btrfs: send: avoid copying file data	2020-10-07 12:13:17 +02:00
space-info.c	btrfs: extend locking to all space_info members accesses	2022-04-08 14:23:02 +02:00
space-info.h	btrfs: rip out btrfs_space_info::total_bytes_pinned	2021-06-22 14:55:25 +02:00
struct-funcs.c	btrfs: add special case to setget helpers for 64k pages	2021-08-23 13:18:58 +02:00
subpage.c	btrfs: subpage: fix a potential use-after-free in writeback helper	2021-08-23 13:19:05 +02:00
subpage.h	btrfs: subpage: fix writeback which does not have ordered extent	2021-08-23 13:19:04 +02:00
super.c	btrfs: make thaw time super block check to also verify checksum	2023-01-12 11:59:20 +01:00
sysfs.c	btrfs: sysfs: normalize the error handling branch in btrfs_init_sysfs()	2022-12-02 17:41:12 +01:00
sysfs.h	btrfs: split and refactor btrfs_sysfs_remove_devices_dir	2020-10-07 12:12:21 +02:00
transaction.c	btrfs: make send work with concurrent block group relocation	2022-03-16 14:23:46 +01:00
transaction.h	btrfs: do not start relocation until in progress drops are done	2022-03-08 19:12:54 +01:00
tree-checker.c	btrfs: tree-checker: check for overlapping extent items	2022-09-05 10:30:12 +02:00
tree-checker.h
tree-defrag.c	btrfs: fix an error handling path in btrfs_defrag_leaves()	2023-01-12 11:59:08 +01:00
tree-log.c	btrfs: fix warning during log replay when bumping inode link count	2022-09-05 10:30:09 +02:00
tree-log.h	btrfs: pass the dentry to btrfs_log_new_name() instead of the inode	2022-08-31 17:16:36 +02:00
tree-mod-log.c	btrfs: fix race when picking most recent mod log operation for an old root	2021-04-20 19:27:17 +02:00
tree-mod-log.h	btrfs: add and use helper to get lowest sequence number for the tree mod log	2021-04-19 17:25:17 +02:00
ulist.c
ulist.h
uuid-tree.c	btrfs: remove unnecessary casts in printk	2020-12-08 15:53:52 +01:00
verity.c	btrfs: fix transaction handle leak after verity rollback failure	2021-09-17 19:29:41 +02:00
volumes.c	btrfs: check superblock to ensure the fs was not modified at thaw time	2023-01-12 11:59:17 +01:00
volumes.h	btrfs: zoned: initialize device's zone info for seeding	2022-11-16 09:58:27 +01:00
xattr.c	btrfs: check if root is readonly while setting security xattr	2022-08-31 17:16:46 +02:00
xattr.h
zlib.c	Revert "btrfs: compression: drop kmap/kunmap from zlib"	2021-10-29 13:03:05 +02:00
zoned.c	btrfs: use kvcalloc in btrfs_get_dev_zone_info	2022-12-02 17:41:12 +01:00
zoned.h	btrfs: zoned: revive max_zone_append_bytes	2022-08-31 17:16:34 +02:00
zstd.c	Revert "btrfs: compression: drop kmap/kunmap from zstd"	2021-10-29 13:02:50 +02:00