Swapnil Sapkal 0f74f12ee0 cpufreq: amd-pstate-ut: Fix kernel panic when loading the driver ... [ Upstream commit 60dd283804 ] After loading the amd-pstate-ut driver, amd_pstate_ut_check_perf() and amd_pstate_ut_check_freq() use cpufreq_cpu_get() to get the policy of the CPU and mark it as busy. In these functions, cpufreq_cpu_put() should be used to release the policy, but it is not, so any other entity trying to access the policy is blocked indefinitely. One such scenario is when amd_pstate mode is changed, leading to the following splat: [ 1332.103727] INFO: task bash:2929 blocked for more than 120 seconds. [ 1332.110001] Not tainted 6.5.0-rc2-amd-pstate-ut #5 [ 1332.115315] "echo 0 > /proc/sys/kernel/hung_task_timeout_secs" disables this message. [ 1332.123140] task:bash state:D stack:0 pid:2929 ppid:2873 flags:0x00004006 [ 1332.123143] Call Trace: [ 1332.123145] <TASK> [ 1332.123148] __schedule+0x3c1/0x16a0 [ 1332.123154] ? _raw_read_lock_irqsave+0x2d/0x70 [ 1332.123157] schedule+0x6f/0x110 [ 1332.123160] schedule_timeout+0x14f/0x160 [ 1332.123162] ? preempt_count_add+0x86/0xd0 [ 1332.123165] __wait_for_common+0x92/0x190 [ 1332.123168] ? __pfx_schedule_timeout+0x10/0x10 [ 1332.123170] wait_for_completion+0x28/0x30 [ 1332.123173] cpufreq_policy_put_kobj+0x4d/0x90 [ 1332.123177] cpufreq_policy_free+0x157/0x1d0 [ 1332.123178] ? preempt_count_add+0x58/0xd0 [ 1332.123180] cpufreq_remove_dev+0xb6/0x100 [ 1332.123182] subsys_interface_unregister+0x114/0x120 [ 1332.123185] ? preempt_count_add+0x58/0xd0 [ 1332.123187] ? __pfx_amd_pstate_change_driver_mode+0x10/0x10 [ 1332.123190] cpufreq_unregister_driver+0x3b/0xd0 [ 1332.123192] amd_pstate_change_driver_mode+0x1e/0x50 [ 1332.123194] store_status+0xe9/0x180 [ 1332.123197] dev_attr_store+0x1b/0x30 [ 1332.123199] sysfs_kf_write+0x42/0x50 [ 1332.123202] kernfs_fop_write_iter+0x143/0x1d0 [ 1332.123204] vfs_write+0x2df/0x400 [ 1332.123208] ksys_write+0x6b/0xf0 [ 1332.123210] __x64_sys_write+0x1d/0x30 [ 1332.123213] do_syscall_64+0x60/0x90 [ 1332.123216] ? fpregs_assert_state_consistent+0x2e/0x50 [ 1332.123219] ? exit_to_user_mode_prepare+0x49/0x1a0 [ 1332.123223] ? irqentry_exit_to_user_mode+0xd/0x20 [ 1332.123225] ? irqentry_exit+0x3f/0x50 [ 1332.123226] ? exc_page_fault+0x8e/0x190 [ 1332.123228] entry_SYSCALL_64_after_hwframe+0x6e/0xd8 [ 1332.123232] RIP: 0033:0x7fa74c514a37 [ 1332.123234] RSP: 002b:00007ffe31dd0788 EFLAGS: 00000246 ORIG_RAX: 0000000000000001 [ 1332.123238] RAX: ffffffffffffffda RBX: 0000000000000008 RCX: 00007fa74c514a37 [ 1332.123239] RDX: 0000000000000008 RSI: 000055e27c447aa0 RDI: 0000000000000001 [ 1332.123241] RBP: 000055e27c447aa0 R08: 00007fa74c5d1460 R09: 000000007fffffff [ 1332.123242] R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000008 [ 1332.123244] R13: 00007fa74c61a780 R14: 00007fa74c616600 R15: 00007fa74c615a00 [ 1332.123247] </TASK> Fix this by calling cpufreq_cpu_put() wherever necessary. Fixes: 14eb1c96e3 ("cpufreq: amd-pstate: Add test module for amd-pstate driver") Reviewed-by: Mario Limonciello <mario.limonciello@amd.com> Reviewed-by: Meng Li <li.meng@amd.com> Reviewed-by: Wyes Karny <wyes.karny@amd.com> Suggested-by: Wyes Karny <wyes.karny@amd.com> Signed-off-by: Swapnil Sapkal <swapnil.sapkal@amd.com> [ rjw: Subject and changelog edits ] Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> Signed-off-by: Sasha Levin <sashal@kernel.org>		2023-09-13 09:53:01 +02:00
..
acpi-cpufreq.c	cpufreq: ACPI: Prevent a warning when another frequency driver is loaded	2023-05-15 19:59:29 +02:00
amd_freq_sensitivity.c	cpufreq: amd_freq_sensitivity: Add missing pci_dev_put()	2022-11-30 19:50:04 +01:00
amd-pstate-trace.c	cpufreq: amd-pstate: Add trace for AMD P-State module	2021-12-30 18:51:39 +01:00
amd-pstate-trace.h	cpufreq: amd-pstate: Add more tracepoint for AMD P-State module	2022-03-09 19:53:01 +01:00
amd-pstate-ut.c	cpufreq: amd-pstate-ut: Fix kernel panic when loading the driver	2023-09-13 09:53:01 +02:00
amd-pstate.c	cpufreq: amd-pstate: fix global sysfs attribute type	2023-08-07 19:41:48 +02:00
apple-soc-cpufreq.c	cpufreq: apple-soc: Fix an IS_ERR() vs NULL check	2023-03-01 19:34:54 +01:00
armada-8k-cpufreq.c	cpufreq: armada-8k: add ap807 support	2023-06-19 09:50:31 +05:30
armada-37xx-cpufreq.c	cpufreq: armada-37xx: stop using 0 as NULL pointer	2023-01-10 09:32:03 +05:30
bmips-cpufreq.c	cpufreq: bmips-cpufreq: Use module_init and add module_exit	2022-08-30 13:49:23 +05:30
brcmstb-avs-cpufreq.c	cpufreq: Make cpufreq_unregister_driver() return void	2023-02-09 20:19:18 +01:00
cppc_cpufreq.c	cpufreq: CPPC: Add u64 casts to avoid overflowing	2022-12-27 08:27:14 +05:30
cpufreq_conservative.c	cpufreq: unify show() and store() naming and use __ATTR_XX	2022-03-10 19:55:05 +01:00
cpufreq_governor_attr_set.c	cpufreq: Move to_gov_attr_set() to cpufreq.h	2022-02-04 19:22:34 +01:00
cpufreq_governor.c	cpufreq: governor: Use kobject release() method to free dbs_data	2022-04-13 15:22:41 +02:00
cpufreq_governor.h	cpufreq: governor: Use kobject release() method to free dbs_data	2022-04-13 15:22:41 +02:00
cpufreq_ondemand.c	cpufreq: ondemand: Use cpumask_var_t for on-stack cpu mask	2022-07-25 20:38:01 +02:00
cpufreq_ondemand.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500	2019-06-19 17:09:55 +02:00
cpufreq_performance.c	cpufreq: Introduce CPUFREQ_GOV_STRICT_TARGET	2020-11-10 18:31:17 +01:00
cpufreq_powersave.c	cpufreq: Introduce CPUFREQ_GOV_STRICT_TARGET	2020-11-10 18:31:17 +01:00
cpufreq_stats.c	cpufreq: stats: Convert to use sysfs_emit_at() API	2022-12-06 12:20:07 +01:00
cpufreq_userspace.c	cpufreq: Register governors at core_initcall	2020-07-02 13:03:30 +02:00
cpufreq-dt-platdev.c	cpufreq: dt-platdev: Support building as module	2023-06-05 16:33:05 +05:30
cpufreq-dt.c	cpufreq: dt: Switch to use dev_err_probe() helper	2022-10-18 16:22:25 +05:30
cpufreq-dt.h	cpufreq: dt: Allow platform specific intermediate callbacks	2020-03-12 15:43:52 +05:30
cpufreq-nforce2.c	cpufreq: Avoid creating excessively large stack frames	2020-01-27 10:33:33 +01:00
cpufreq.c	cpufreq: Fail driver register if it has adjust_perf without fast_switch	2023-06-15 18:15:25 +02:00
davinci-cpufreq.c	cpufreq: davinci: Fix clk use after free	2023-02-09 20:26:42 +01:00
e_powersaver.c	cpufreq: e_powersaver: remove unreachable break	2020-10-27 18:42:54 +01:00
elanfreq.c	cpufreq: Convert to new X86 CPU match macros	2020-03-24 21:31:27 +01:00
freq_table.c	Updates for 6.4	2023-04-20 19:30:01 +02:00
gx-suspmod.c	cpufreq: Avoid creating excessively large stack frames	2020-01-27 10:33:33 +01:00
highbank-cpufreq.c	cpufreq: Add __init annotation to module init funcs	2022-09-26 11:15:04 +05:30
ia64-acpi-cpufreq.c	ia64: fix format string for ia64-acpi-cpu-freq	2021-03-19 17:26:20 +01:00
imx6q-cpufreq.c	cpufreq: imx6q: don't warn for disabling a non-existing frequency	2023-05-15 14:42:33 +05:30
imx-cpufreq-dt.c	cpufreq: Use of_property_present() for testing DT property presence	2023-03-13 09:58:11 +05:30
intel_pstate.c	cpufreq: intel_pstate: set stale CPU frequency to minimum	2023-09-13 09:52:57 +02:00
Kconfig	cpufreq: Make CONFIG_CPUFREQ_DT_PLATDEV depend on OF	2023-06-30 09:43:43 +02:00
Kconfig.arm	cpufreq: Fix typo in the ARM_BRCMSTB_AVS_CPUFREQ Kconfig entry	2023-03-22 20:14:37 +01:00
Kconfig.powerpc	cpufreq: Fix Kconfig indentation	2019-11-29 11:52:02 +01:00
Kconfig.x86	cpufreq: amd-pstate: Add a kernel config option to set default mode	2023-06-21 18:44:56 +02:00
kirkwood-cpufreq.c	cpufreq: Adjust includes to remove of_device.h	2023-04-13 17:46:35 -05:00
longhaul.c	cpufreq: longhaul: Make array speeds static const	2022-11-03 19:13:34 +01:00
longhaul.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 166	2019-05-30 11:26:39 -07:00
longrun.c	cpufreq: Convert to new X86 CPU match macros	2020-03-24 21:31:27 +01:00
loongson2_cpufreq.c	cpufreq: loongson2: Remove unused linux/sched.h headers	2021-06-07 17:43:52 +02:00
Makefile	Power management updates for 6.3-rc1	2023-02-21 12:13:58 -08:00
maple-cpufreq.c	cpufreq: Adjust includes to remove of_device.h	2023-04-13 17:46:35 -05:00
mediatek-cpufreq-hw.c	Cpufreq arm updates for 6.3	2023-02-14 15:25:07 +01:00
mediatek-cpufreq.c	cpufreq: mediatek: correct voltages for MT7622 and MT7623	2023-06-19 09:53:28 +05:30
mvebu-cpufreq.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - gpl-2.0_56.RULE (part 2)	2022-06-10 14:51:35 +02:00
omap-cpufreq.c	cpufreq: Make cpufreq_unregister_driver() return void	2023-02-09 20:19:18 +01:00
p4-clockmod.c	treewide: Use fallthrough pseudo-keyword	2020-08-23 17:36:59 -05:00
pasemi-cpufreq.c	cpufreq: Prepare cleanup of powerpc's asm/prom.h	2022-04-13 17:18:45 +02:00
pcc-cpufreq.c	cpufreq: ACPI: Prevent a warning when another frequency driver is loaded	2023-05-15 19:59:29 +02:00
pmac32-cpufreq.c	Devicetree updates for v6.4, part 2:	2023-04-27 10:09:05 -07:00
pmac64-cpufreq.c	cpufreq: Adjust includes to remove of_device.h	2023-04-13 17:46:35 -05:00
powernow-k6.c	cpufreq: Convert to new X86 CPU match macros	2020-03-24 21:31:27 +01:00
powernow-k7.c	cpufreq: Convert to new X86 CPU match macros	2020-03-24 21:31:27 +01:00
powernow-k7.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 166	2019-05-30 11:26:39 -07:00
powernow-k8.c	cpufreq: powernow-k8: Re-order the init checks	2022-03-17 14:54:11 +01:00
powernow-k8.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 347	2019-06-05 17:37:08 +02:00
powernv-cpufreq.c	cpufreq: Introducing CPUFREQ_RELATION_E	2021-10-05 16:33:05 +02:00
ppc_cbe_cpufreq_pervasive.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 153	2019-05-30 11:26:32 -07:00
ppc_cbe_cpufreq_pmi.c	cpufreq: Prepare cleanup of powerpc's asm/prom.h	2022-04-13 17:18:45 +02:00
ppc_cbe_cpufreq.c	cpufreq: Prepare cleanup of powerpc's asm/prom.h	2022-04-13 17:18:45 +02:00
ppc_cbe_cpufreq.h	cpufreq: powerpc_cbe: Switch to QoS requests for freq limits	2019-08-26 10:02:01 +02:00
pxa2xx-cpufreq.c	cpufreq: pxa3: move clk register access to clk driver	2022-05-07 22:55:49 +02:00
pxa3xx-cpufreq.c	cpufreq: pxa3: move clk register access to clk driver	2022-05-07 22:55:49 +02:00
qcom-cpufreq-hw.c	cpufreq: qcom-cpufreq-hw: Use dev_err_probe() when failing to get icc paths	2023-06-26 12:09:47 +05:30
qcom-cpufreq-nvmem.c	cpufreq: qcom-nvmem: use helper to get SMEM SoC ID	2023-05-26 18:18:57 -07:00
qoriq-cpufreq.c	drivers: cpufreq: Add missing of_node_put() in qoriq-cpufreq.c	2022-06-28 13:34:45 +05:30
raspberrypi-cpufreq.c	cpufreq: add driver for Raspberry Pi	2019-06-13 08:58:22 +05:30
s3c64xx-cpufreq.c	cpufreq: s3c64xx: Remove pointless NULL check in s3c64xx_cpufreq_driver_init	2019-10-23 08:53:23 +05:30
s5pv210-cpufreq.c	cpufreq: Introducing CPUFREQ_RELATION_E	2021-10-05 16:33:05 +02:00
sa1110-cpufreq.c	ARM: sa1100: remove unused board files	2023-01-12 10:53:12 +01:00
sc520_freq.c	cpufreq: sc520_freq: add 'fallthrough' to one case	2021-05-21 18:52:13 +02:00
scmi-cpufreq.c	cpufreq: Use of_property_present() for testing DT property presence	2023-03-13 09:58:11 +05:30
scpi-cpufreq.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - gpl-2.0_320.RULE	2022-06-10 14:51:36 +02:00
sh-cpufreq.c	cpufreq: sh: Remove sh_cpufreq_cpu_ready()	2021-09-02 18:04:17 +02:00
sparc-us2e-cpufreq.c	cpufreq: sparc: Don't mark cpufreq callbacks with __init	2023-07-12 12:45:18 +02:00
sparc-us3-cpufreq.c	cpufreq: sparc: Don't mark cpufreq callbacks with __init	2023-07-12 12:45:18 +02:00
spear-cpufreq.c	cpufreq: Adjust includes to remove of_device.h	2023-04-13 17:46:35 -05:00
speedstep-centrino.c	cpufreq: Convert to new X86 CPU match macros	2020-03-24 21:31:27 +01:00
speedstep-ich.c	cpufreq: Convert to new X86 CPU match macros	2020-03-24 21:31:27 +01:00
speedstep-lib.c	cpufreq: speedstep: remove unneeded semicolon	2020-10-28 18:04:07 +01:00
speedstep-lib.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 166	2019-05-30 11:26:39 -07:00
speedstep-smi.c	cpufreq: Convert to new X86 CPU match macros	2020-03-24 21:31:27 +01:00
sti-cpufreq.c	cpufreq: Add __init annotation to module init funcs	2022-09-26 11:15:04 +05:30
sun50i-cpufreq-nvmem.c	cpufreq: sun50i: Add explicit include for cpu.h	2023-04-13 17:46:35 -05:00
tegra20-cpufreq.c	Devicetree updates for v6.4, part 2:	2023-04-27 10:09:05 -07:00
tegra124-cpufreq.c	Devicetree updates for v6.4, part 2:	2023-04-27 10:09:05 -07:00
tegra186-cpufreq.c	cpufreq: tegra186: Use flexible array to simplify memory allocation	2022-12-01 14:49:50 +05:30
tegra194-cpufreq.c	cpufreq: tegra194: Fix an error handling path in tegra194_cpufreq_probe()	2023-05-11 14:32:50 +05:30
ti-cpufreq.c	cpufreq: ti-cpufreq: Add support for AM62A7	2023-05-29 10:33:59 +05:30
vexpress-spc-cpufreq.c	cpufreq: vexpress: Drop unused variable	2021-10-04 11:25:21 +05:30