mirror of
https://mirrors.bfsu.edu.cn/git/linux.git
synced 2024-12-05 01:54:09 +08:00
f2ea2578df
- Add missing dma_fence_put() in virtio_gpu_execbuffer_ioctl(). - Fix memory leak in virtio_gpu_cleanup_object(). -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEuXvWqAysSYEJGuVH/lWMcqZwE8MFAl8z7XwACgkQ/lWMcqZw E8MKcxAAmqdx1mZDgunV0O8aU/PWFaA+2C2zef7bFxP496pXAEaxLcmj+ExDtE8k A4x0QNNMWTAuAXHsYbJOjYmkx6ceqIb8sqqZsyl+sNOapHq/NuBz7DE2g2ON53+D jisrw6M7uHd+rKbdYKUqLAq7cohQoyLJ89XbzhL3iQSyRf6spVMIr3a9ed3tUHrU ksWD+Qj0z77FD0ZN4PPYa4IysHJ0N55eU03PifK4Qkk6rAOFOJSV2lMyWiI9LvlY yUmd9rB+QROyIvX39CO/I8/DHQO8f+bWpNwWtauB4Gb+jQo8R03blyN8FXWH+p8B FZpi6qurtaeIHDiZ1Z41gSPcAR0C7Xk9O7pPIgt8OjXSzN5Z5k1a/kVBVKy20Lel /YNR1CnRHNLmiYTF5OvoFlHz0jJY+2acKDilSJWSaGvh8ZAFx0E0wwcxvSDLGEex IjB6XjL8TdasiWbBxNGs0NinCRfcDuQJ82C06yFVHjHJC0HwIShsgIlT9np98BC9 75abp01ZEapv/tXKHV71sPZuzzXo3JXdLC4or0l6h0dliZO40BQJL2DLSBmyi/tm q4LYrZp42BVonha41eThbKZAdoDONiWrF15+oIHmSV5p705moaMgLnZ1UAc8Orn7 hcuX5eInjvqoOKqbnAF5u/nYlPVwJ6C+GMTPDrsJVWpVDRccNR0= =XbOz -----END PGP SIGNATURE----- Merge tag 'drm-misc-fixes-2020-08-12' of git://anongit.freedesktop.org/drm/drm-misc into drm-fixes drm-misc-fixes for v5.9-rc1: - Add missing dma_fence_put() in virtio_gpu_execbuffer_ioctl(). - Fix memory leak in virtio_gpu_cleanup_object(). Signed-off-by: Dave Airlie <airlied@redhat.com> From: Maarten Lankhorst <maarten.lankhorst@linux.intel.com> Link: https://patchwork.freedesktop.org/patch/msgid/d50eb2e0-75c8-b724-006f-5e7b391961ff@linux.intel.com
527 lines
13 KiB
C
527 lines
13 KiB
C
/*
|
|
* Copyright (C) 2015 Red Hat, Inc.
|
|
* All Rights Reserved.
|
|
*
|
|
* Authors:
|
|
* Dave Airlie
|
|
* Alon Levy
|
|
*
|
|
* Permission is hereby granted, free of charge, to any person obtaining a
|
|
* copy of this software and associated documentation files (the "Software"),
|
|
* to deal in the Software without restriction, including without limitation
|
|
* the rights to use, copy, modify, merge, publish, distribute, sublicense,
|
|
* and/or sell copies of the Software, and to permit persons to whom the
|
|
* Software is furnished to do so, subject to the following conditions:
|
|
*
|
|
* The above copyright notice and this permission notice shall be included in
|
|
* all copies or substantial portions of the Software.
|
|
*
|
|
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
|
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
|
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
|
|
* THE COPYRIGHT HOLDER(S) OR AUTHOR(S) BE LIABLE FOR ANY CLAIM, DAMAGES OR
|
|
* OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE,
|
|
* ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR
|
|
* OTHER DEALINGS IN THE SOFTWARE.
|
|
*/
|
|
|
|
#include <linux/file.h>
|
|
#include <linux/sync_file.h>
|
|
#include <linux/uaccess.h>
|
|
|
|
#include <drm/drm_file.h>
|
|
#include <drm/virtgpu_drm.h>
|
|
|
|
#include "virtgpu_drv.h"
|
|
|
|
void virtio_gpu_create_context(struct drm_device *dev, struct drm_file *file)
|
|
{
|
|
struct virtio_gpu_device *vgdev = dev->dev_private;
|
|
struct virtio_gpu_fpriv *vfpriv = file->driver_priv;
|
|
char dbgname[TASK_COMM_LEN];
|
|
|
|
mutex_lock(&vfpriv->context_lock);
|
|
if (vfpriv->context_created)
|
|
goto out_unlock;
|
|
|
|
get_task_comm(dbgname, current);
|
|
virtio_gpu_cmd_context_create(vgdev, vfpriv->ctx_id,
|
|
strlen(dbgname), dbgname);
|
|
vfpriv->context_created = true;
|
|
|
|
out_unlock:
|
|
mutex_unlock(&vfpriv->context_lock);
|
|
}
|
|
|
|
static int virtio_gpu_map_ioctl(struct drm_device *dev, void *data,
|
|
struct drm_file *file)
|
|
{
|
|
struct virtio_gpu_device *vgdev = dev->dev_private;
|
|
struct drm_virtgpu_map *virtio_gpu_map = data;
|
|
|
|
return virtio_gpu_mode_dumb_mmap(file, vgdev->ddev,
|
|
virtio_gpu_map->handle,
|
|
&virtio_gpu_map->offset);
|
|
}
|
|
|
|
/*
|
|
* Usage of execbuffer:
|
|
* Relocations need to take into account the full VIRTIO_GPUDrawable size.
|
|
* However, the command as passed from user space must *not* contain the initial
|
|
* VIRTIO_GPUReleaseInfo struct (first XXX bytes)
|
|
*/
|
|
static int virtio_gpu_execbuffer_ioctl(struct drm_device *dev, void *data,
|
|
struct drm_file *file)
|
|
{
|
|
struct drm_virtgpu_execbuffer *exbuf = data;
|
|
struct virtio_gpu_device *vgdev = dev->dev_private;
|
|
struct virtio_gpu_fpriv *vfpriv = file->driver_priv;
|
|
struct virtio_gpu_fence *out_fence;
|
|
int ret;
|
|
uint32_t *bo_handles = NULL;
|
|
void __user *user_bo_handles = NULL;
|
|
struct virtio_gpu_object_array *buflist = NULL;
|
|
struct sync_file *sync_file;
|
|
int in_fence_fd = exbuf->fence_fd;
|
|
int out_fence_fd = -1;
|
|
void *buf;
|
|
|
|
if (vgdev->has_virgl_3d == false)
|
|
return -ENOSYS;
|
|
|
|
if ((exbuf->flags & ~VIRTGPU_EXECBUF_FLAGS))
|
|
return -EINVAL;
|
|
|
|
exbuf->fence_fd = -1;
|
|
|
|
virtio_gpu_create_context(dev, file);
|
|
if (exbuf->flags & VIRTGPU_EXECBUF_FENCE_FD_IN) {
|
|
struct dma_fence *in_fence;
|
|
|
|
in_fence = sync_file_get_fence(in_fence_fd);
|
|
|
|
if (!in_fence)
|
|
return -EINVAL;
|
|
|
|
/*
|
|
* Wait if the fence is from a foreign context, or if the fence
|
|
* array contains any fence from a foreign context.
|
|
*/
|
|
ret = 0;
|
|
if (!dma_fence_match_context(in_fence, vgdev->fence_drv.context))
|
|
ret = dma_fence_wait(in_fence, true);
|
|
|
|
dma_fence_put(in_fence);
|
|
if (ret)
|
|
return ret;
|
|
}
|
|
|
|
if (exbuf->flags & VIRTGPU_EXECBUF_FENCE_FD_OUT) {
|
|
out_fence_fd = get_unused_fd_flags(O_CLOEXEC);
|
|
if (out_fence_fd < 0)
|
|
return out_fence_fd;
|
|
}
|
|
|
|
if (exbuf->num_bo_handles) {
|
|
bo_handles = kvmalloc_array(exbuf->num_bo_handles,
|
|
sizeof(uint32_t), GFP_KERNEL);
|
|
if (!bo_handles) {
|
|
ret = -ENOMEM;
|
|
goto out_unused_fd;
|
|
}
|
|
|
|
user_bo_handles = u64_to_user_ptr(exbuf->bo_handles);
|
|
if (copy_from_user(bo_handles, user_bo_handles,
|
|
exbuf->num_bo_handles * sizeof(uint32_t))) {
|
|
ret = -EFAULT;
|
|
goto out_unused_fd;
|
|
}
|
|
|
|
buflist = virtio_gpu_array_from_handles(file, bo_handles,
|
|
exbuf->num_bo_handles);
|
|
if (!buflist) {
|
|
ret = -ENOENT;
|
|
goto out_unused_fd;
|
|
}
|
|
kvfree(bo_handles);
|
|
bo_handles = NULL;
|
|
}
|
|
|
|
buf = vmemdup_user(u64_to_user_ptr(exbuf->command), exbuf->size);
|
|
if (IS_ERR(buf)) {
|
|
ret = PTR_ERR(buf);
|
|
goto out_unused_fd;
|
|
}
|
|
|
|
if (buflist) {
|
|
ret = virtio_gpu_array_lock_resv(buflist);
|
|
if (ret)
|
|
goto out_memdup;
|
|
}
|
|
|
|
out_fence = virtio_gpu_fence_alloc(vgdev);
|
|
if(!out_fence) {
|
|
ret = -ENOMEM;
|
|
goto out_unresv;
|
|
}
|
|
|
|
if (out_fence_fd >= 0) {
|
|
sync_file = sync_file_create(&out_fence->f);
|
|
if (!sync_file) {
|
|
dma_fence_put(&out_fence->f);
|
|
ret = -ENOMEM;
|
|
goto out_memdup;
|
|
}
|
|
|
|
exbuf->fence_fd = out_fence_fd;
|
|
fd_install(out_fence_fd, sync_file->file);
|
|
}
|
|
|
|
virtio_gpu_cmd_submit(vgdev, buf, exbuf->size,
|
|
vfpriv->ctx_id, buflist, out_fence);
|
|
dma_fence_put(&out_fence->f);
|
|
virtio_gpu_notify(vgdev);
|
|
return 0;
|
|
|
|
out_unresv:
|
|
if (buflist)
|
|
virtio_gpu_array_unlock_resv(buflist);
|
|
out_memdup:
|
|
kvfree(buf);
|
|
out_unused_fd:
|
|
kvfree(bo_handles);
|
|
if (buflist)
|
|
virtio_gpu_array_put_free(buflist);
|
|
|
|
if (out_fence_fd >= 0)
|
|
put_unused_fd(out_fence_fd);
|
|
|
|
return ret;
|
|
}
|
|
|
|
static int virtio_gpu_getparam_ioctl(struct drm_device *dev, void *data,
|
|
struct drm_file *file)
|
|
{
|
|
struct virtio_gpu_device *vgdev = dev->dev_private;
|
|
struct drm_virtgpu_getparam *param = data;
|
|
int value;
|
|
|
|
switch (param->param) {
|
|
case VIRTGPU_PARAM_3D_FEATURES:
|
|
value = vgdev->has_virgl_3d == true ? 1 : 0;
|
|
break;
|
|
case VIRTGPU_PARAM_CAPSET_QUERY_FIX:
|
|
value = 1;
|
|
break;
|
|
default:
|
|
return -EINVAL;
|
|
}
|
|
if (copy_to_user(u64_to_user_ptr(param->value), &value, sizeof(int)))
|
|
return -EFAULT;
|
|
|
|
return 0;
|
|
}
|
|
|
|
static int virtio_gpu_resource_create_ioctl(struct drm_device *dev, void *data,
|
|
struct drm_file *file)
|
|
{
|
|
struct virtio_gpu_device *vgdev = dev->dev_private;
|
|
struct drm_virtgpu_resource_create *rc = data;
|
|
struct virtio_gpu_fence *fence;
|
|
int ret;
|
|
struct virtio_gpu_object *qobj;
|
|
struct drm_gem_object *obj;
|
|
uint32_t handle = 0;
|
|
struct virtio_gpu_object_params params = { 0 };
|
|
|
|
if (vgdev->has_virgl_3d) {
|
|
virtio_gpu_create_context(dev, file);
|
|
params.virgl = true;
|
|
params.target = rc->target;
|
|
params.bind = rc->bind;
|
|
params.depth = rc->depth;
|
|
params.array_size = rc->array_size;
|
|
params.last_level = rc->last_level;
|
|
params.nr_samples = rc->nr_samples;
|
|
params.flags = rc->flags;
|
|
} else {
|
|
if (rc->depth > 1)
|
|
return -EINVAL;
|
|
if (rc->nr_samples > 1)
|
|
return -EINVAL;
|
|
if (rc->last_level > 1)
|
|
return -EINVAL;
|
|
if (rc->target != 2)
|
|
return -EINVAL;
|
|
if (rc->array_size > 1)
|
|
return -EINVAL;
|
|
}
|
|
|
|
params.format = rc->format;
|
|
params.width = rc->width;
|
|
params.height = rc->height;
|
|
params.size = rc->size;
|
|
/* allocate a single page size object */
|
|
if (params.size == 0)
|
|
params.size = PAGE_SIZE;
|
|
|
|
fence = virtio_gpu_fence_alloc(vgdev);
|
|
if (!fence)
|
|
return -ENOMEM;
|
|
ret = virtio_gpu_object_create(vgdev, ¶ms, &qobj, fence);
|
|
dma_fence_put(&fence->f);
|
|
if (ret < 0)
|
|
return ret;
|
|
obj = &qobj->base.base;
|
|
|
|
ret = drm_gem_handle_create(file, obj, &handle);
|
|
if (ret) {
|
|
drm_gem_object_release(obj);
|
|
return ret;
|
|
}
|
|
drm_gem_object_put(obj);
|
|
|
|
rc->res_handle = qobj->hw_res_handle; /* similiar to a VM address */
|
|
rc->bo_handle = handle;
|
|
return 0;
|
|
}
|
|
|
|
static int virtio_gpu_resource_info_ioctl(struct drm_device *dev, void *data,
|
|
struct drm_file *file)
|
|
{
|
|
struct drm_virtgpu_resource_info *ri = data;
|
|
struct drm_gem_object *gobj = NULL;
|
|
struct virtio_gpu_object *qobj = NULL;
|
|
|
|
gobj = drm_gem_object_lookup(file, ri->bo_handle);
|
|
if (gobj == NULL)
|
|
return -ENOENT;
|
|
|
|
qobj = gem_to_virtio_gpu_obj(gobj);
|
|
|
|
ri->size = qobj->base.base.size;
|
|
ri->res_handle = qobj->hw_res_handle;
|
|
drm_gem_object_put(gobj);
|
|
return 0;
|
|
}
|
|
|
|
static int virtio_gpu_transfer_from_host_ioctl(struct drm_device *dev,
|
|
void *data,
|
|
struct drm_file *file)
|
|
{
|
|
struct virtio_gpu_device *vgdev = dev->dev_private;
|
|
struct virtio_gpu_fpriv *vfpriv = file->driver_priv;
|
|
struct drm_virtgpu_3d_transfer_from_host *args = data;
|
|
struct virtio_gpu_object_array *objs;
|
|
struct virtio_gpu_fence *fence;
|
|
int ret;
|
|
u32 offset = args->offset;
|
|
|
|
if (vgdev->has_virgl_3d == false)
|
|
return -ENOSYS;
|
|
|
|
virtio_gpu_create_context(dev, file);
|
|
objs = virtio_gpu_array_from_handles(file, &args->bo_handle, 1);
|
|
if (objs == NULL)
|
|
return -ENOENT;
|
|
|
|
ret = virtio_gpu_array_lock_resv(objs);
|
|
if (ret != 0)
|
|
goto err_put_free;
|
|
|
|
fence = virtio_gpu_fence_alloc(vgdev);
|
|
if (!fence) {
|
|
ret = -ENOMEM;
|
|
goto err_unlock;
|
|
}
|
|
virtio_gpu_cmd_transfer_from_host_3d
|
|
(vgdev, vfpriv->ctx_id, offset, args->level,
|
|
&args->box, objs, fence);
|
|
dma_fence_put(&fence->f);
|
|
virtio_gpu_notify(vgdev);
|
|
return 0;
|
|
|
|
err_unlock:
|
|
virtio_gpu_array_unlock_resv(objs);
|
|
err_put_free:
|
|
virtio_gpu_array_put_free(objs);
|
|
return ret;
|
|
}
|
|
|
|
static int virtio_gpu_transfer_to_host_ioctl(struct drm_device *dev, void *data,
|
|
struct drm_file *file)
|
|
{
|
|
struct virtio_gpu_device *vgdev = dev->dev_private;
|
|
struct virtio_gpu_fpriv *vfpriv = file->driver_priv;
|
|
struct drm_virtgpu_3d_transfer_to_host *args = data;
|
|
struct virtio_gpu_object_array *objs;
|
|
struct virtio_gpu_fence *fence;
|
|
int ret;
|
|
u32 offset = args->offset;
|
|
|
|
objs = virtio_gpu_array_from_handles(file, &args->bo_handle, 1);
|
|
if (objs == NULL)
|
|
return -ENOENT;
|
|
|
|
if (!vgdev->has_virgl_3d) {
|
|
virtio_gpu_cmd_transfer_to_host_2d
|
|
(vgdev, offset,
|
|
args->box.w, args->box.h, args->box.x, args->box.y,
|
|
objs, NULL);
|
|
} else {
|
|
virtio_gpu_create_context(dev, file);
|
|
ret = virtio_gpu_array_lock_resv(objs);
|
|
if (ret != 0)
|
|
goto err_put_free;
|
|
|
|
ret = -ENOMEM;
|
|
fence = virtio_gpu_fence_alloc(vgdev);
|
|
if (!fence)
|
|
goto err_unlock;
|
|
|
|
virtio_gpu_cmd_transfer_to_host_3d
|
|
(vgdev,
|
|
vfpriv ? vfpriv->ctx_id : 0, offset,
|
|
args->level, &args->box, objs, fence);
|
|
dma_fence_put(&fence->f);
|
|
}
|
|
virtio_gpu_notify(vgdev);
|
|
return 0;
|
|
|
|
err_unlock:
|
|
virtio_gpu_array_unlock_resv(objs);
|
|
err_put_free:
|
|
virtio_gpu_array_put_free(objs);
|
|
return ret;
|
|
}
|
|
|
|
static int virtio_gpu_wait_ioctl(struct drm_device *dev, void *data,
|
|
struct drm_file *file)
|
|
{
|
|
struct drm_virtgpu_3d_wait *args = data;
|
|
struct drm_gem_object *obj;
|
|
long timeout = 15 * HZ;
|
|
int ret;
|
|
|
|
obj = drm_gem_object_lookup(file, args->handle);
|
|
if (obj == NULL)
|
|
return -ENOENT;
|
|
|
|
if (args->flags & VIRTGPU_WAIT_NOWAIT) {
|
|
ret = dma_resv_test_signaled_rcu(obj->resv, true);
|
|
} else {
|
|
ret = dma_resv_wait_timeout_rcu(obj->resv, true, true,
|
|
timeout);
|
|
}
|
|
if (ret == 0)
|
|
ret = -EBUSY;
|
|
else if (ret > 0)
|
|
ret = 0;
|
|
|
|
drm_gem_object_put(obj);
|
|
return ret;
|
|
}
|
|
|
|
static int virtio_gpu_get_caps_ioctl(struct drm_device *dev,
|
|
void *data, struct drm_file *file)
|
|
{
|
|
struct virtio_gpu_device *vgdev = dev->dev_private;
|
|
struct drm_virtgpu_get_caps *args = data;
|
|
unsigned size, host_caps_size;
|
|
int i;
|
|
int found_valid = -1;
|
|
int ret;
|
|
struct virtio_gpu_drv_cap_cache *cache_ent;
|
|
void *ptr;
|
|
|
|
if (vgdev->num_capsets == 0)
|
|
return -ENOSYS;
|
|
|
|
/* don't allow userspace to pass 0 */
|
|
if (args->size == 0)
|
|
return -EINVAL;
|
|
|
|
spin_lock(&vgdev->display_info_lock);
|
|
for (i = 0; i < vgdev->num_capsets; i++) {
|
|
if (vgdev->capsets[i].id == args->cap_set_id) {
|
|
if (vgdev->capsets[i].max_version >= args->cap_set_ver) {
|
|
found_valid = i;
|
|
break;
|
|
}
|
|
}
|
|
}
|
|
|
|
if (found_valid == -1) {
|
|
spin_unlock(&vgdev->display_info_lock);
|
|
return -EINVAL;
|
|
}
|
|
|
|
host_caps_size = vgdev->capsets[found_valid].max_size;
|
|
/* only copy to user the minimum of the host caps size or the guest caps size */
|
|
size = min(args->size, host_caps_size);
|
|
|
|
list_for_each_entry(cache_ent, &vgdev->cap_cache, head) {
|
|
if (cache_ent->id == args->cap_set_id &&
|
|
cache_ent->version == args->cap_set_ver) {
|
|
spin_unlock(&vgdev->display_info_lock);
|
|
goto copy_exit;
|
|
}
|
|
}
|
|
spin_unlock(&vgdev->display_info_lock);
|
|
|
|
/* not in cache - need to talk to hw */
|
|
virtio_gpu_cmd_get_capset(vgdev, found_valid, args->cap_set_ver,
|
|
&cache_ent);
|
|
virtio_gpu_notify(vgdev);
|
|
|
|
copy_exit:
|
|
ret = wait_event_timeout(vgdev->resp_wq,
|
|
atomic_read(&cache_ent->is_valid), 5 * HZ);
|
|
if (!ret)
|
|
return -EBUSY;
|
|
|
|
/* is_valid check must proceed before copy of the cache entry. */
|
|
smp_rmb();
|
|
|
|
ptr = cache_ent->caps_cache;
|
|
|
|
if (copy_to_user(u64_to_user_ptr(args->addr), ptr, size))
|
|
return -EFAULT;
|
|
|
|
return 0;
|
|
}
|
|
|
|
struct drm_ioctl_desc virtio_gpu_ioctls[DRM_VIRTIO_NUM_IOCTLS] = {
|
|
DRM_IOCTL_DEF_DRV(VIRTGPU_MAP, virtio_gpu_map_ioctl,
|
|
DRM_RENDER_ALLOW),
|
|
|
|
DRM_IOCTL_DEF_DRV(VIRTGPU_EXECBUFFER, virtio_gpu_execbuffer_ioctl,
|
|
DRM_RENDER_ALLOW),
|
|
|
|
DRM_IOCTL_DEF_DRV(VIRTGPU_GETPARAM, virtio_gpu_getparam_ioctl,
|
|
DRM_RENDER_ALLOW),
|
|
|
|
DRM_IOCTL_DEF_DRV(VIRTGPU_RESOURCE_CREATE,
|
|
virtio_gpu_resource_create_ioctl,
|
|
DRM_RENDER_ALLOW),
|
|
|
|
DRM_IOCTL_DEF_DRV(VIRTGPU_RESOURCE_INFO, virtio_gpu_resource_info_ioctl,
|
|
DRM_RENDER_ALLOW),
|
|
|
|
/* make transfer async to the main ring? - no sure, can we
|
|
* thread these in the underlying GL
|
|
*/
|
|
DRM_IOCTL_DEF_DRV(VIRTGPU_TRANSFER_FROM_HOST,
|
|
virtio_gpu_transfer_from_host_ioctl,
|
|
DRM_RENDER_ALLOW),
|
|
DRM_IOCTL_DEF_DRV(VIRTGPU_TRANSFER_TO_HOST,
|
|
virtio_gpu_transfer_to_host_ioctl,
|
|
DRM_RENDER_ALLOW),
|
|
|
|
DRM_IOCTL_DEF_DRV(VIRTGPU_WAIT, virtio_gpu_wait_ioctl,
|
|
DRM_RENDER_ALLOW),
|
|
|
|
DRM_IOCTL_DEF_DRV(VIRTGPU_GET_CAPS, virtio_gpu_get_caps_ioctl,
|
|
DRM_RENDER_ALLOW),
|
|
};
|