korg/linux
0
0
Fork 0
mirror of https://mirrors.bfsu.edu.cn/git/linux.git synced 2024-11-11 21:38:32 +08:00
Code Issues Packages Projects Releases Wiki Activity
0b089c1ef7
linux/drivers/ide
History
Kees Cook 3f649ab728 treewide: Remove uninitialized_var() usage 
Using uninitialized_var() is dangerous as it papers over real bugs[1]
(or can in the future), and suppresses unrelated compiler warnings
(e.g. "unused variable"). If the compiler thinks it is uninitialized,
either simply initialize the variable or make compiler changes.

In preparation for removing[2] the[3] macro[4], remove all remaining
needless uses with the following script:

git grep '\buninitialized_var\b' | cut -d: -f1 | sort -u | \
	xargs perl -pi -e \
		's/\buninitialized_var\(([^\)]+)\)/\1/g;
		 s:\s*/\* (GCC be quiet|to make compiler happy) \*/$::g;'

drivers/video/fbdev/riva/riva_hw.c was manually tweaked to avoid
pathological white-space.

No outstanding warnings were found building allmodconfig with GCC 9.3.0
for x86_64, i386, arm64, arm, powerpc, powerpc64le, s390x, mips, sparc64,
alpha, and m68k.

[1] https://lore.kernel.org/lkml/20200603174714.192027-1-glider@google.com/
[2] https://lore.kernel.org/lkml/CA+55aFw+Vbj0i=1TGqCR5vQkCzWJ0QxK6CernOU6eedsudAixw@mail.gmail.com/
[3] https://lore.kernel.org/lkml/CA+55aFwgbgqhbp1fkxvRKEpzyR5J8n1vKT1VZdz9knmPuXhOeg@mail.gmail.com/
[4] https://lore.kernel.org/lkml/CA+55aFz2500WfbKXAx8s67wrm9=yVJu65TpLgN_ybYNv0VEOKA@mail.gmail.com/

Reviewed-by: Leon Romanovsky <leonro@mellanox.com> # drivers/infiniband and mlx4/mlx5
Acked-by: Jason Gunthorpe <jgg@mellanox.com> # IB
Acked-by: Kalle Valo <kvalo@codeaurora.org> # wireless drivers
Reviewed-by: Chao Yu <yuchao0@huawei.com> # erofs
Signed-off-by: Kees Cook <keescook@chromium.org>
2020-07-16 12:35:15 -07:00
..
aec62xx.c treewide: Add SPDX license identifier for more missed files 2019-05-21 10:50:45 +02:00
ali14xx.c treewide: Add SPDX license identifier for more missed files 2019-05-21 10:50:45 +02:00
alim15x3.c alim15x3: move irq-restore before pci_dev_put() 2018-06-05 16:26:46 -04:00
amd74xx.c treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500 2019-06-19 17:09:55 +02:00
atiixp.c treewide: Add SPDX license identifier for more missed files 2019-05-21 10:50:45 +02:00
buddha.c zorro: ZTWO_VADDR() should return "void __iomem *" 2013-11-26 11:09:07 +01:00
cmd64x.c cmd64x: potential buffer overflow in cmd64x_program_timings() 2020-01-20 13:38:27 +01:00
cmd640.c treewide: Add SPDX license identifier for more missed files 2019-05-21 10:50:45 +02:00
cs5520.c ide: remove deprecated use of pci api 2015-04-17 15:32:07 -04:00
cs5530.c
cs5535.c treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500 2019-06-19 17:09:55 +02:00
cs5536.c treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 333 2019-06-05 17:37:06 +02:00
cy82c693.c treewide: Add SPDX license identifier for more missed files 2019-05-21 10:50:45 +02:00
delkin_cb.c
dtc2278.c treewide: Add SPDX license identifier for more missed files 2019-05-21 10:50:45 +02:00
falconide.c m68k/atari: Convert Falcon IDE drivers to platform drivers 2019-11-18 10:18:59 +01:00
gayle.c ide: drop owner assignment from platform_drivers 2014-10-20 16:20:38 +02:00
hpt366.c treewide: Add SPDX license identifier for more missed files 2019-05-21 10:50:45 +02:00
ht6560b.c ide: ht6560b: Fix cast to pointer from integer of different size 2020-01-20 13:38:26 +01:00
icside.c treewide: Add SPDX license identifier for more missed files 2019-05-21 10:50:45 +02:00
ide_platform.c treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152 2019-05-30 11:26:32 -07:00
ide-4drives.c treewide: Add SPDX license identifier for more missed files 2019-05-21 10:50:45 +02:00
ide-acpi.c treewide: Remove uninitialized_var() usage 2020-07-16 12:35:15 -07:00
ide-atapi.c treewide: Remove uninitialized_var() usage 2020-07-16 12:35:15 -07:00
ide-cd_ioctl.c Revert "ide: unexport DISK_EVENT_MEDIA_CHANGE for ide-gd and ide-cd" 2019-04-12 13:35:25 -06:00
ide-cd_verbose.c License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00
ide-cd.c ide-cd: rename cdrom_read_tocentry 2020-05-04 10:13:42 -06:00
ide-cd.h block: Switch struct packet_command to use struct scsi_sense_hdr 2018-08-02 15:22:13 -06:00
ide-cs.c
ide-devsets.c ide: don't use req->special 2018-11-10 08:03:52 -07:00
ide-disk_ioctl.c License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00
ide-disk_proc.c ide: replace ->proc_fops with ->proc_show 2018-05-16 07:24:30 +02:00
ide-disk.c compat_ioctl: move HDIO ioctl handling into drivers/ide 2020-01-03 09:42:52 +01:00
ide-disk.h License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00
ide-dma-sff.c treewide: Add SPDX license identifier for missed files 2019-05-21 10:50:45 +02:00
ide-dma.c ide: kill ide_toggle_bounce 2018-05-07 07:15:41 +02:00
ide-eh.c treewide: Add SPDX license identifier for missed files 2019-05-21 10:50:45 +02:00
ide-floppy_ioctl.c compat_ioctl: move HDIO ioctl handling into drivers/ide 2020-01-03 09:42:52 +01:00
ide-floppy_proc.c ide: replace ->proc_fops with ->proc_show 2018-05-16 07:24:30 +02:00
ide-floppy.c compat_ioctl: ide: floppy: add handler 2020-01-03 09:33:24 +01:00
ide-floppy.h compat_ioctl: ide: floppy: add handler 2020-01-03 09:33:24 +01:00
ide-gd.c scsi: compat_ioctl: cdrom: Replace .ioctl with .compat_ioctl in four appropriate places 2020-02-24 15:06:07 -05:00
ide-gd.h License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00
ide-generic.c treewide: simplify Kconfig dependencies for removed archs 2018-03-26 15:55:57 +02:00
ide-io-std.c treewide: Remove uninitialized_var() usage 2020-07-16 12:35:15 -07:00
ide-io.c treewide: Remove uninitialized_var() usage 2020-07-16 12:35:15 -07:00
ide-ioctls.c compat_ioctl: move HDIO ioctl handling into drivers/ide 2020-01-03 09:42:52 +01:00
ide-iops.c ide: remove unnecessary touch_softlockup_watchdog 2020-01-20 13:38:26 +01:00
ide-legacy.c treewide: Add SPDX license identifier for missed files 2019-05-21 10:50:45 +02:00
ide-lib.c treewide: Add SPDX license identifier for missed files 2019-05-21 10:50:45 +02:00
ide-park.c ide: ensure atapi sense request aren't preempted 2019-01-31 08:25:09 -07:00
ide-pci-generic.c
ide-pio-blacklist.c License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00
ide-pm.c ide: don't acquire queue_lock in ide_complete_pm_rq 2018-11-16 09:17:02 -07:00
ide-pnp.c treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 47 2019-05-24 17:27:13 +02:00
ide-probe.c treewide: Add SPDX license identifier for missed files 2019-05-21 10:50:45 +02:00
ide-proc.c proc: convert everything to "struct proc_ops" 2020-02-04 03:05:26 +00:00
ide-scan-pci.c drivers/ide: Fix build regression. 2020-04-04 18:07:59 -07:00
ide-sysfs.c treewide: Remove uninitialized_var() usage 2020-07-16 12:35:15 -07:00
ide-tape.c compat_ioctl: move HDIO ioctl handling into drivers/ide 2020-01-03 09:42:52 +01:00
ide-taskfile.c ide: Remove uninitialized_var() usage 2020-07-16 12:32:25 -07:00
ide-timings.c treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 156 2019-05-30 11:26:35 -07:00
ide-xfer-mode.c treewide: Add SPDX license identifier for missed files 2019-05-21 10:50:45 +02:00
ide.c treewide: Add SPDX license identifier for more missed files 2019-05-21 10:50:45 +02:00
it821x.c treewide: kzalloc() -> kcalloc() 2018-06-12 16:19:22 -07:00
it8172.c
it8213.c treewide: Add SPDX license identifier for more missed files 2019-05-21 10:50:45 +02:00
jmicron.c
Kconfig treewide: replace '---help---' in Kconfig files with 'help' 2020-06-14 01:57:21 +09:00
macide.c
Makefile ide: remove no longer used au1xxx-ide driver 2020-03-24 15:53:38 +01:00
ns87415.c treewide: Add SPDX license identifier for more missed files 2019-05-21 10:50:45 +02:00
opti621.c treewide: Add SPDX license identifier for more missed files 2019-05-21 10:50:45 +02:00
palm_bk3710.c treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 61 2019-05-24 17:36:45 +02:00
pdc202xx_new.c treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152 2019-05-30 11:26:32 -07:00
pdc202xx_old.c treewide: Add SPDX license identifier for more missed files 2019-05-21 10:50:45 +02:00
piix.c
pmac.c ide: remove set but not used variable 'hwif' 2020-01-20 13:38:26 +01:00
q40ide.c
qd65xx.c ide: qd65xx: Fix cast to pointer from integer of different size 2020-01-20 13:38:27 +01:00
qd65xx.h License cleanup: add SPDX GPL-2.0 license identifier to files with no license 2017-11-02 11:10:55 +01:00
rapide.c treewide: Add SPDX license identifier for more missed files 2019-05-21 10:50:45 +02:00
rz1000.c treewide: Add SPDX license identifier for more missed files 2019-05-21 10:50:45 +02:00
sc1200.c
serverworks.c ide: serverworks: potential overflow in svwks_set_pio_mode() 2020-01-20 13:38:27 +01:00
setup-pci.c ide: pci: free PCI BARs on initialization failure 2017-10-03 14:02:57 -05:00
siimage.c ide: Use dev_get_drvdata where possible 2019-07-23 13:04:54 -07:00
sis5513.c ide: mark expected switch fall-throughs 2018-08-13 11:48:54 -07:00
sl82c105.c treewide: Add SPDX license identifier for more missed files 2019-05-21 10:50:45 +02:00
slc90e66.c treewide: Add SPDX license identifier for more missed files 2019-05-21 10:50:45 +02:00
tc86c001.c
triflex.c treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 333 2019-06-05 17:37:06 +02:00
trm290.c ide: constify ide_dma_ops structures 2016-01-18 14:12:33 -05:00
tx4938ide.c ide: Use pr_warn instead of pr_warning 2019-10-18 15:00:21 +02:00
tx4939ide.c Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/ide 2020-01-30 07:39:10 -08:00
umc8672.c treewide: Remove uninitialized_var() usage 2020-07-16 12:35:15 -07:00
via82cxxx.c ide: Use dev_get_drvdata where possible 2019-07-23 13:04:54 -07:00