Mateusz Jończyk be6c3152d6 rtc: Check return value from mc146818_get_time() ... [ Upstream commit 0dd8d6cb9e ] There are 4 users of mc146818_get_time() and none of them was checking the return value from this function. Change this. Print the appropriate warnings in callers of mc146818_get_time() instead of in the function mc146818_get_time() itself, in order not to add strings to rtc-mc146818-lib.c, which is kind of a library. The callers of alpha_rtc_read_time() and cmos_read_time() may use the contents of (struct rtc_time *) even when the functions return a failure code. Therefore, set the contents of (struct rtc_time *) to 0x00, which looks more sensible then 0xff and aligns with the (possibly stale?) comment in cmos_read_time: /* * If pm_trace abused the RTC for storage, set the timespec to 0, * which tells the caller that this RTC value is unusable. */ For consistency, do this in mc146818_get_time(). Note: hpet_rtc_interrupt() may call mc146818_get_time() many times a second. It is very unlikely, though, that the RTC suddenly stops working and mc146818_get_time() would consistently fail. Only compile-tested on alpha. Signed-off-by: Mateusz Jończyk <mat.jonczyk@o2.pl> Cc: Richard Henderson <rth@twiddle.net> Cc: Ivan Kokshaysky <ink@jurassic.park.msu.ru> Cc: Matt Turner <mattst88@gmail.com> Cc: Thomas Gleixner <tglx@linutronix.de> Cc: Ingo Molnar <mingo@redhat.com> Cc: Borislav Petkov <bp@alien8.de> Cc: Dave Hansen <dave.hansen@linux.intel.com> Cc: Alessandro Zummo <a.zummo@towertech.it> Cc: Alexandre Belloni <alexandre.belloni@bootlin.com> Cc: linux-alpha@vger.kernel.org Cc: x86@kernel.org Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com> Link: https://lore.kernel.org/r/20211210200131.153887-4-mat.jonczyk@o2.pl Signed-off-by: Sasha Levin <sashal@kernel.org>		2022-04-13 20:59:14 +02:00
..
boot	alpha: fix spelling mistakes	2021-07-25 22:33:04 -07:00
configs	alpha: defconfig: add necessary configs for boot testing	2021-07-25 22:33:03 -07:00
include	alpha: move __udiv_qrnnd library function to arch/alpha/lib/	2021-09-18 14:45:48 -07:00
kernel	rtc: Check return value from mc146818_get_time()	2022-04-13 20:59:14 +02:00
lib	alpha: move __udiv_qrnnd library function to arch/alpha/lib/	2021-09-18 14:45:48 -07:00
math-emu	alpha: move __udiv_qrnnd library function to arch/alpha/lib/	2021-09-18 14:45:48 -07:00
mm	signal/alpha: si_trapno is only used with SIGFPE and SIGTRAP TRAP_UNK	2021-07-23 13:10:26 -05:00
Kbuild	alpha: move core-y in arch/alpha/Makefile to arch/alpha/Kbuild	2021-05-26 23:11:47 +09:00
Kconfig	alpha: enable GENERIC_PCI_IOMAP unconditionally	2021-09-19 10:37:00 -07:00
Kconfig.debug	treewide: replace '---help---' in Kconfig files with 'help'	2020-06-14 01:57:21 +09:00
Makefile	alpha: move core-y in arch/alpha/Makefile to arch/alpha/Kbuild	2021-05-26 23:11:47 +09:00